Application Insights: Add Favorites and Web Test Locations APIs #2416

d3r3kk · 2018-02-04T07:31:32Z

Web Test Locations API:
Application Insights has web tests already defined in their REST API, but the locations for web tests were not discoverable for users at the time we wrote that spec. This PR brings the web test location query to our customers to make this information available.

Favorites API:
Application Insights components contain many reportable items and each of those items are highly configurable. We've given our users the ability to store their commonly used queries and reports as favorites within the Application Insights component. This PR exposes the management of these favorites to the REST API.

Misc:
Correct some minor testing failures with webTest and components APIs.

PR information

The title of the PR is clear and informative.
There are a small number of commits...
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-02-04T07:33:23Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@c184e9c

AutorestCI · 2018-02-04T07:34:55Z

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@f05b00f

olydis · 2018-02-06T04:45:46Z

@ravbhatnagar new APIs

ravbhatnagar · 2018-02-12T21:12:50Z

...applicationinsights/resource-manager/microsoft.insights/stable/2015-05-01/favorites_API.json

+    "ApplicationInsightsComponentFavorite": {
+      "description": "Properties that define a favorite that is associated to an Application Insights component.",
+      "properties": {
+        "Name": {


camel case all property names

The service I am defining via Swagger returns “PascalCase” property names and not “camelCase” as defined in our Swagger guidelines.

I can convert the swagger document property names to camelCase but I believe that breaks the auto-generated C# code?

Whatever the outcome of the API design discussion, the swagger must be true to what the service actually returns. If the service is using PascalCase, then you should add suppressions to tell the linter that you are indeed doing this on purpose. This particular guidelines is about the API design, not about the swagger describing the service :).

Thanks for the feedback @johanste, I will add the necessary linter suppressions.

Done. I updated suppressions that were already there.

ravbhatnagar · 2018-02-12T21:14:14Z

...applicationinsights/resource-manager/microsoft.insights/stable/2015-05-01/favorites_API.json

+          "type": "string",
+          "description": "The user-defined name of the favorite."
+        },
+        "Config": {


only certain top level properties are allowed by ARM. All RP specific resource properties should go inside the properties envelope. Is this new API or something which already exists on the service side?

This is not a new API, it already exists.

I believe I understand this. The ARM API requires things to be structured this way (CDS service returns properties that must be encased within the 'ARM' top-level properties).

However, our API exists outside of this structure, and returns these top level structures today and does not return the top-level envelope that ARM provides. Does this mean we do not require the top-level ARM envelope?

For instance, I see that our 'Components' API includes in its "definitions" the top-level 'Resource' container, but I don't see it being used anywhere there. Is this the requirement then, to define it but not use it in this case?

ravbhatnagar · 2018-02-12T21:15:21Z

...applicationinsights/resource-manager/microsoft.insights/stable/2015-05-01/favorites_API.json

+  "definitions": {
+    "ApplicationInsightsComponentFavorite": {
+      "description": "Properties that define a favorite that is associated to an Application Insights component.",
+      "properties": {


id and type top level properties missing

ravbhatnagar · 2018-02-15T21:26:42Z

@d3r3kk -Lets set up a call to understand this and see if would be correct to fix them considering these are existing.
Please set up a call and loop in folks from Azure API review board as well - @johanste @devigned @NiklasGustafsson. Also please bucket all the AI APIs that have similar issues and we can discuss them together. I think there is another PR for AI which have these issues.

d3r3kk · 2018-02-20T00:13:12Z

@ravbhatnagar agreed, I would like to ensure that we get this resolved very soon too! I'll reach out via Outlook and try and get a meeting in place shortly.

devigned · 2018-02-20T20:33:54Z

...applicationinsights/resource-manager/microsoft.insights/stable/2015-05-01/favorites_API.json

+          ],
+          "x-ms-enum": {
+            "name": "FavoriteType",
+            "modelAsString": false


If an enum will ever have additional values, it should be modeled as string. If it will only have these values forever, then modelAsString false is appropriate. Please use this guidance for each of the enums.

I will investigate the field and determine if it will ever be extended and alter it to "modelAsString": true if this is the case.

Changed to modelAsString as we may need to add other favorite types in the future.

@d3r3kk it sounds like you meant to set this to true? 🙂

ravbhatnagar · 2018-02-21T02:00:54Z

Signing off from ARM side. Although there are compliance issues here, these APIs have been in prod for several years. Ongoing conversation with AI team on whether its possible to fix these in a new api-version.

lmazuel · 2018-02-21T19:37:25Z

@AutorestCI rebuild azure-sdk-for-python

AutorestCI · 2018-02-21T19:38:38Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2022

AutorestCI · 2018-02-21T23:28:14Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1145

d3r3kk · 2018-02-21T23:29:51Z

Completed my updates. Could I get a review sign off from @johanste , @devigned , or @NiklasGustafsson ?

Note that I added 3 suppressions for noisy warnings from files not from my PR. (description/title missing and response schema - all warnings for redundant or false negative failures).

Thanks!

devigned · 2018-02-22T19:34:55Z

@olydis any other feedback you'd like to impart prior to merging?

olydis

just some minor comments, looking good overall!

olydis · 2018-02-22T20:51:36Z

...applicationinsights/resource-manager/microsoft.insights/stable/2015-05-01/favorites_API.json

+            "$ref": "./examples/FavoritesList.json"
+          }
+        },
+        "x-ms-pageable": {


the declared response type is not of pageable shape (object with value property of type array like in this random example - what you have is a bare array), i.e. either the schema is wrong or this annotation 🙂

I checked the code in our service, but it never returns a paged item - only returns the entire list of favorites without chunking them into pages.
Removed the x-ms-pageable annotation.

I imagine this is also part of how we may be out of compliance with the ARM schemas at the moment (we are aware of this and future updates to the service are slated to bring us back into compliance, hence the back and forth with the ARM team earlier).

olydis · 2018-02-22T20:56:22Z

...applicationinsights/resource-manager/microsoft.insights/stable/2015-05-01/favorites_API.json

+          ],
+          "x-ms-enum": {
+            "name": "FavoriteType",
+            "modelAsString": false


@d3r3kk it sounds like you meant to set this to true? 🙂

olydis · 2018-02-22T20:59:11Z

...applicationinsights/resource-manager/microsoft.insights/stable/2015-05-01/favorites_API.json

+        "shared",
+        "user"
+      ],
+      "description": "The type of favorite. Value can be either shared or user.",


x-ms-enum missing, also please don't duplicate the enum information in the description 🙂

Only SourceTypeParameter needs to be modelled as a string, not FavoriteTypeParameter (sorry for any confusion on past comments).

Also, I added the x-ms-enum field in the missing instance.

no worries, thanks for clarifying 🙂

- favor 'web test' names/descriptions over 'synthetic monitor' as web test is more customer-centric naming - create example data for the web test api

- ensure tests run against the applicationinsights folder successfully

…ites - generating API in CSharp generated errors

…rite types are possible in future.

…no global suppressions where possible).

…ers.

- Remove x-ms-pageable annotation from our list operation, in the service code we never paganate our data. - Add x-ms-enum annotation to one enum data type where it was missing.

d3r3kk · 2018-02-23T06:18:58Z

Thanks for the review @olydis , appreciated. Not sure why I didn't get notification of the PR in my email (I've likely syphoned off reviews for this repo someplace special!). Should be good for a renewed review.

* Add purge operations to AppInsights management plane (#2528) * Add purge to management plane API * Adding purge status operation * Change purge statue to enum * capitalize response status * [AppInsights Data Plane] Fix table schema (#2527) * Remove internal schena column * Fix row schema * Application Insights: Add Favorites and Web Test Locations APIs (#2416) * Initial addition of favorites and locations API * Complete web test locations API - favor 'web test' names/descriptions over 'synthetic monitor' as web test is more customer-centric naming - create example data for the web test api * Spelling update * Updated parameters for favorite API * Add favorites API and examples - ensure tests run against the applicationinsights folder successfully * Add collectionFormat to comma-separated tags list parameter for favorites - generating API in CSharp generated errors * Enum for favorite type should be set to modelAsString as further favorite types are possible in future. * Update suppressions to include specific instances I need suppressed (no global suppressions where possible). * Suppress some noisey test warnings from API specifications from my peers. * PR suggestions - Remove x-ms-pageable annotation from our list operation, in the service code we never paganate our data. - Add x-ms-enum annotation to one enum data type where it was missing. * Event Hub: Added missing API to respective API version Swaggers (#2457) * Added the missing API discovered in ARM_RP_Fundamentals to the respective API version swagger and review comments * added tag for 2014-09 * Update the output-folder to match azure-sdk-for-net paths in Vision package (#2529) * Added enableBatchedOperations property to ServiceBus Queue (#2534) * [Don't Merge, Service roll out 2/28/2018] Swagger For new rdbms API change for new biz model (#2414) * Add new version for mysql and pgsql * Correct readme version * Correct create properties parameter * Correct PG namespace and some other comment * Update Examples folder to examples * Correct property name cases in the examples * Corrected the ServerResult objects in CRUD samples * Correct property values for server response in samples * make createtime and lastmodifiedtime for logfileproperties to readonly * Web Python conf (#2549) * Add a directive for node and TS (#2550) * Swagger specs for all existing versions of Microsoft.PolicyInsights (#2523) * Swagger specs for all existing versions of Microsoft.PolicyInsights * Add support for --validate; make where clauses explicit in existing (approval request pending) suppressions; add new suppression for equivalent paths error (approval request pending) * Fix $top in examples; fix casing in examples * Fix two more instances of $top type in examples * Fix metadata examples by adding content type header and changing the body to a single string * Remove EQUIVALENT_PATH suppressions; add extendedProperties as additionalProperties; add @odata.count to operations; remove "type" from "rows" in first 2017-08-09-preview and add descriptions * Fix remaining examples with bad casings * Fix additionalParameters definition; fix duplicate paths * Remove redundant operations path/definitions from one of the swagger files for each version (one per namespace is sufficient as long as both files are fed into autorest as a bundle) * DataMigration py conf (#2553) * Fix recommendation resource properties, add disable recommendation APIs (#2548) * Add Billing Account resource to Billing RP. (#2517) * Add "Classic Account" ARM resource. * 1. Change classic account property name from "userPrincipalName" to "principalName" 2. Add examples * Fix API version in examples. * Add example links. * ClassicAccount->BillingAccount * Removing "uuid" - billing account name may be a concatenation of uuid and additional keys. * Remove unused parameters. * 1. Add new version to readme.md 2. Fix validation warnings * Fix descriptions. * Fix type mismatch error. * Adding missing parameter in example. * Fix ms-examples name. * Compute spec change for zone resilient images (#2551) * Compute spec change for zone resilient images * Address feedback from the previous iteration * [DO NOT MERGE]update swaggers for azure elastic pool operation (#2520) * update swaggers for azure database and elastic pool operation * update ListDatabaseOperations and ListElasticPoolOperations examples * Only update the swagger for elastic pool operations * end * remove two not needed folders. Fix the error in ListElasticPoolOperation * Update the cancel operations swagger on database and pool, and corresponding examples * fix indentation in cancelOperations.json and cancelPoolOperations.json * Update Azure Database Migration Service to add Managed Instance as target (#2531) * Copy over 2017-11-15-preview folder in preparation for adding 2018-03-15-preview api version. * Update Azure Database Migration Service to add Managed Instance as target * Take out GeoRestore option (#2559) * [Monitor] Fixing issue with metricsnamespace incorrecly specified as client level argument #2565 (#2566) * [Monitor] Make all attributes of EventData class readonly (#2254) * [Monitor] Fixing issue with metricnamespace specification as client level argument #2565 * [Azure Search] Change output path for .NET data plane SDK (#2554) This is part of a planned refactoring that will split the Azure Search .NET data plane SDK into separate packages. * Fix links in the PR template (#2571) * Remove unused API (#2564) Please note this is not a GA API and has been deprecated for a while. There is no current user for it. * Adding preview/stable to the example layout. (#2561) * Adding preview/stable to the example layout. * Fixing formatting * fixed Go SDK path for automation (#2562) * [Monitor] Fixing issue with metrics api queryparameter name (#2575) (#2577) * add databricks activity (#2568) * Swagger completeness for Redis Cache (#2537) * Default string modeled as parameter for auto generation to work correctly * Adding CheckNameAvailability and listUpgradeNotifications into swagger for redis * Fixing code review comments * remove "/" at end for list apis * Name change for notification * Fixing code review comments in PR * Fixing examples that are breaking the build * Add missing type specifier to enum definition. (#2580) * Change group name for operations path, and rename response type definition (#2563) * Swagger specs for all existing versions of Microsoft.PolicyInsights * Add support for --validate; make where clauses explicit in existing (approval request pending) suppressions; add new suppression for equivalent paths error (approval request pending) * Fix $top in examples; fix casing in examples * Fix two more instances of $top type in examples * Fix metadata examples by adding content type header and changing the body to a single string * Remove EQUIVALENT_PATH suppressions; add extendedProperties as additionalProperties; add @odata.count to operations; remove "type" from "rows" in first 2017-08-09-preview and add descriptions * Fix remaining examples with bad casings * Fix additionalParameters definition; fix duplicate paths * Remove redundant operations path/definitions from one of the swagger files for each version (one per namespace is sufficient as long as both files are fed into autorest as a bundle) * Change group name for operations path, and rename response type definition * Change group name for operations path, and rename response type definition (old API versions) * ApiManagement 2018-01-01 version spec (#2292) * Copy the 2017-03-01 files * 2018-01-01 specific changes revert x-ms-enum and update description * 202 on create or update, network status and backend flatten 202 on create or update, networkstatus backend flatten Head for ApiRevision * Fix ValidationRegex of Ids and length * Fix the TagResource contract * Make PUT operation on portalsettings resources ARM-compliant Fix examples * Removed x-ms-client-flatten * NextLinkName and fix Check Entity Exist * Bring back default responses and fix examples * [Do not merge] CDN in all languages in conf (#2514) * CDN in all languages in conf * Review from Node and Amar * Use "net" in tag and not "csharp" * Remove wrong C# comment from Readme * Update Ruby to match real repo * Fix Ruby folder * Azure migrate GA and public preview rest api specs. (#2446) * Azure migrate GA and public preview rest api specs. * Resolving PR comments and semantic errors * Modifying dictionary definition in rest api specs * Defining dictionary in data model * add delete restore points API (#2593) * fix name for backward compatibility * fix name for backward compatibility 2 * fix return type name * fix message - sdk review comment * add delete restore points API and change to async for create API * [Refactor] Client name should be more specific (#2596) As per request: Azure/azure-sdk-for-python#2048 (review) * Add DNS 2017-10-01 API version (#2558) * Add DNS 2017-10-01 API version * Copy 2017-09-01 DNS API version to 2017-10-01 * Add 2017-10-01 DNS API version * Add x-ms-client-name for recordsetnamesuffix for RecordSets_ListAllByDnsZone * Update Sql-ResourceManager readme for list and cancel database/pool operation (#2592) * Update Sql-ResourceManager readme for a previous pull request on updating list and cancel operation on database and pool * fix a type in readme * keep the default tag as unchanged for now * ApiManagement. Fix reference (#2606) * ApiManagement. Fix reference * apimdiagnostics. * syntax error fix * Sampling settings added to logger entity (#2600) * remove async keyword since mocha does not run the tests correctly. (#2609) * Build Network with Autorest.Python 3.0 (#2611) * Reorganize policyinsights; change modelAsString for x-ms-enum to true (#2599) * Swagger specs for all existing versions of Microsoft.PolicyInsights * Add support for --validate; make where clauses explicit in existing (approval request pending) suppressions; add new suppression for equivalent paths error (approval request pending) * Fix $top in examples; fix casing in examples * Fix two more instances of $top type in examples * Fix metadata examples by adding content type header and changing the body to a single string * Remove EQUIVALENT_PATH suppressions; add extendedProperties as additionalProperties; add @odata.count to operations; remove "type" from "rows" in first 2017-08-09-preview and add descriptions * Fix remaining examples with bad casings * Fix additionalParameters definition; fix duplicate paths * Remove redundant operations path/definitions from one of the swagger files for each version (one per namespace is sufficient as long as both files are fed into autorest as a bundle) * Change group name for operations path, and rename response type definition * Change group name for operations path, and rename response type definition (old API versions) * Reorganize files; change modelAsString for x-ms-enum to true Reorganize files (remove resource type based subfolders; rename conflicting example files to have resource type name; change swagger spec files and MD file based on new file locations and names); change modelAsString for x-ms-enum to true based on API review board recommendation * Dummy change to kick the CI again * update roledefinition filters to be in sync with the filters present in service (#2586) * fix the hardcoding of api version for classicadmin in sdk * fix 2017 version preview file * update filter to make it in sync with service * update filter to make it in sync with service * Fix java code generation for resources (#2613) * Add on error deployment ARM (#2560) * Add on error deployment ARM * Update readme.md file * Add provisioning state for the on error deployment * Add on error deployment examples * fix json * json formatting * Fix schema for examples * 2018-01-01 sync of api changes from 2017-03-01 (#2585) * Copy changes from 2017-03-01 to 2018-01-01 * 2018-01-01 version specific changes * [Cognitive Services] March release (add usages operation, addnew/decomission some APIs) (#2544) * March release initial checkin 1. Add usages operation; 2. Add new APIs; 3. Remove decommisioned APIs * Add WebLM back Add WebLM back * Adding ZRS support for snapshots, new apiversion 2018-04-01 (#2552) * adding disk.json zrs support for snapshots * change modelAsString to true to support new enums * adding create option restore * adding example files * adding examples folder and moving files * adding file * Update readme.md * adding 200 responses... * Adding 2 new APIs for VMSS: Redeploy and PerformMaintenance (#2589) * Fix SDK breaking change in 2017-10-01 DNS Swagger (#2612) * Fix SDK breaking change in 2017-10-01 DNS Swagger and add linter error suppressions * Add scoping to error suppressions in 2017-10-01 DNS Swagger * ApiMgmt Py conf (#2624) * Change the default tag to 2017-10 (#2516) * Add swagger for dataWarehouseUserActivities API (#2389) * Add swagger for dataWarehouseUserActivities Add swagger for dataWarehouseUserActivities * add example file add example file * correct case sensitive name datawarehouseUserActivities to dataWarehouseUserActivities * add dataWarehouseUserActivityName add dataWarehouseUserActivityName * remove "value" GET ".../activities/current" should be a get single API, so it should not have "value" * Replace tab spaces with blank spaces * add missing "body" * Reducing CI Log output Verbosity (#2619) * Reducing CI Log output Verbosity Removing "-v" option from Swagger -> SDK jobs. Updating the reporter used by `mocha` to use the "min" reporter. Documenation of available options is here: http://ricostacruz.com/mocha/#reporters * Using most up-to-date OAV * Adding back Swagger -> SDK verbosity. * Adding OperationalInsights Purge, PurgeStatus operations (#2541) * Adding OperationalInsights Purge, PurgeStatus operations * Modifying long running operation * Diagnostics and Tags are per Api Revision (#2622) * API managment: make the same description for API 2016-07-07 SubscriptionIdParameter. (#2631) * Swagger for Salesforce Marketing Cloud Connector, ServiceUri in Dynamics LS, and SSL support in MongoDB LS (#2579) * Add example for creating Revisions (#2633) * [Cognitive Services] Change type of limit/currentValue to double from integer (#2627) Change limit/currentValue to double from integer * Rename BillingAccount->EnrollmentAccount. (#2626) * Remove entities-view-parameter from swagger (#2602) * Add Microsoft.Databricks workspaces swagger (#2594) * copy of managedapplications.json * change to databricks.json * renaming. * databricks api * address comments: add patch tags, change GenericResource to TrackedResouce, add some common parameters. * move sku from TrackedResource to Workspace. * move resourceGroupName and WorkspaceName to method level * fix error response. * add listWorkspacesByResourceGroup nad listWorkspacesBySubscription. * Adding Container Exec Spec (#2584) * Adding exec api to swagger operation * fixing small syntax error * Updating correct examples for async operation * fixing ARM header field * remvoing extra async operations * Update Python version * Remove advisor Java block from CognitiveServices readme.md (#2641) * Adding changes to support Private DNS Public Preview (#2587) * Copy 2017-10-01 DNS API version to 2018-03-01-preview * Add 2018-03-01-preview DNS API version * updating examples to version 2018-03-01-preview * Adding private zone example * removing the required property on zoneType also fixing example * Adding scoping to error suppressions * Update iotdps.json (#425) * Added Tags filter for budgets and updated the api version (#2625) * Added Tags filter for budgets and updated the api version Added Tags filter for budgets and updated the api version * Updated comments Updated comments * Incorporated review comments Incorporated review comments * Incorporated review comments Incorporated review comments * Incorporated review comment Incorporated review comment * Group DPSCertificate->List with other operations (#2643) * fixing relative paths to definitons and commondefinitions.json * Update iotdps.json "operationId": "DpsCertificates_List", -> "operationId": "DpsCertificate_List", so the list operation is grouped with the others on docs * Fix generated doc structure (#2634) * Plug disks 2018-04-01 for multi api versionning (#2648) * correct tier enum for postgres (#2629) * XMSParameterLocation Fixes (#2649) * Add node config to keyvault for Swagger to SDK (#2650) * Make OSDisk in storage profile optional (#2652) * Fix SDK breaking change in 2017-10-01 DNS Swagger ref #2612 (#2656) * Allow Ruby failure on CI (#2653) * Updating Travis to enforce branch strategy (#2657) * Updating Travis to enforce branch strategy * Fixing some typos * One more shot * Negating logic * Refactor sql readme.md (#2640) * Refactor sql readme.md - Rename schema-* to package-pure-* in order to follow convention for python multi-version - Rename package-2017-10-preview to package-composite-v1. The reasons for this are explained in package-2017-03-01-preview tag. The next tag that I add in the near future will be package-composite-v2, which will represent a breaking change & major version bump for clients. - Improved description of various sections - Whitespace/header consistency * Added package-pure-2017-10 including Go support * Commented on Go api-versions * Removed bad python section * Fixed typo in 2017-10 go package * Add more enum values for Identity/type in generic resource swagger (#2617) * Add more enum values for Identity/type in generic resource swagger Resource types like "Microsoft.Compute/VirtualMachines" have more than one enum value for Identity/type. Updating generic resource swagger so it is up-to-date. * Revert changes in swagger spec for 2017 API Version * [Monitor] Fixing incorrect specification of top parameter for Metrics API (#2655) (#2662) * [Monitor] Make all attributes of EventData class readonly (#2254) * [Monitor] Fixing issue with metricnamespace specification as client level argument #2565 * [Monitor] Fixing incorrect specification of top parameter for Metrics API (#2655) * Cleaning up branchStrategy messaging (#2663) * Cleaning up branchStrategy messaging * Fixing typo * Improve Microsoft.Insights schema generation (#2632) * Improve Microsoft.Insights schema generation - Case of microsoft.insights updated to Microsoft.Insights throughout - Added schema tag to readme.md to limit the input files * Properly move folder to update case of name * Adding 2018-01-22 version for ProvisioningServices and IotHubs (#2542) * adding DPS camelCase changes, IoT Hub camelCase changes, basic sku * adding 2018-01-22 changes for dps and iothub * Add partner name for managmentparnter action response (#2665) * Adding preview version of Event Hubs Cluster to Azure REST API specs. (#2272) * Adding preview version of Event Hubs Cluster to Azure REST API specs. * Adding capacity property to EH Cluster examples. * Differentiating update semantics with patch semantics. * RP-Cluster API: Revamping namespaces enumeration in cluster. * Adding cluster sku property bag and moving capacity to sku. Also adding metricId property to the custom properties bag. * RP-Cluster: Modifiying EHCluster references to Cluster references. Adding changes to readme file as well. * RP-Cluster: Adding Event Hubs operations API to Cluster swagger. * RP-Cluster: Removing leftover EHNamespaces definitions. * Cluster: Distinguishing between Cluster and Configuration clients in operation ids. * [AKS] update list of supported VM sizes (#2668) * [AKS] update list of supported VM sizes * Sync up ACS VM sizes with AKS sizes * Fixing error in naming convention for rows and cols (#2651) * Support azureFunctionReceivers in actionGroup APIs (#2659) * [AKS] specify byte format for base64-encoded kubeconfig (#2669) * Adding API Specs for Long Term Retention V2 (#2256) * Adding API Specs for Long Term Retention V2 This change adds the swagger documentation for the Long Term Retention V2 feature along with examples for each of the APIs.. This includes the following APIs: Get an LTR Backup Get all LTR Backups under a database Get all LTR Backups under a server Get all LTR Backups under a location Delete an LTR Backup Set a database's LTR Policy Get a database's LTR Policy * Remove empty properties and update retention description This update is a response to the few comments that Anu left on the PR. It removes an empty properties entry and updates the retention descriptions to explain that they use an ISO 8601 standard. * Description and Entity Name Changes Made some slight changes to the entity names to better align with LTR V1 and added some better descriptors to some property descriptions. * Fixing Incorrect Description The weekOfYear parameter is not in an ISO 8601 format, it is just an integer between 1 and 52. Fixing that accordingly. * Remove Conflicting Definitions Need to remove backupLongTermRetentionPolicies so it doesn't conflict with the new backupLongTermRetentionPolicies. * Remove Reference to backupLongTermRetentionPolicies.json Need to remove the reference to backupLongTermRetentionPolicies.json in the readme. * Update ResourceId Updated the resource ID for longTermRetentionBackups so servers and databases are now longTermRetentionServers and longTermRetentionDatabases, respectively. This better aligns with REST. * Re-Adding LongTermRetentionPolicyGet.json LongTermRetentionPolicyGet.json was accidentally deleted in the last commit. * Fix Travis CI Errors Made some changes to the examples to fix the Travis CI errors. * Updating more references to BackupLongTermRetentionPolic(y|ies) * Re-adding backupLongTermRetentionPolicies.json * removing .travis.yml that was accidentally added * Revert "removing .travis.yml that was accidentally added" This reverts commit 3b80fa0. * Revert "Re-adding backupLongTermRetentionPolicies.json" This reverts commit b98cf6c. * undoing accidental .travis.yml * Fixing errors in model PR_ONLY=true Travis CI run * Fixing another Travis CI error * Removing .travis.yml from the change and changing LongTermRetentionPolicy to BackupLongTermRetentionPolicy to keep it consistent * resetting backupLongTermRetentionPolicies.json * Update more references of LongTermRetentionPolicy to BackupLongTermRetentionPolicy * updating readme.md comment * Add package-version for ADF (#2674) * Remove azure-validation from readme file (#2676) * Add CODEOWNERS file (#2673) This file will be used to automatically request PR reviews from SMEs on the service teams. It is autogenerated based on previous PR submitters. * Add Go tag for api management, api version 2018-01-01 (#2677) * Add Go tag for api management, api version 2018-01-01 * Generate go to preview path

AutorestCI mentioned this pull request Feb 4, 2018

Automatic PR of restapi_auto_d3r3kk_appinsights-faves-locations into master Azure/azure-sdk-for-python#1901

Closed

AutorestCI mentioned this pull request Feb 4, 2018

Automatic PR of restapi_auto_d3r3kk_appinsights-faves-locations into dev Azure/azure-sdk-for-go#1047

Closed

azuresdkci assigned olydis Feb 4, 2018

olydis added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 6, 2018

ravbhatnagar reviewed Feb 12, 2018

View reviewed changes

devigned reviewed Feb 20, 2018

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Conditionally-Merged and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 21, 2018

AutorestCI mentioned this pull request Feb 21, 2018

[AutoPR applicationinsights/resource-manager] Application Insights: Add Favorites and Web Test Locations APIs Azure/azure-sdk-for-python#2021

Closed

d3r3kk force-pushed the appinsights-faves-locations branch from 0b82ba5 to 7e3377e Compare February 21, 2018 23:26

AutorestCI mentioned this pull request Feb 21, 2018

[AutoPR applicationinsights/resource-manager] Application Insights: Add Favorites and Web Test Locations APIs Azure/azure-sdk-for-go#1127

Closed

olydis suggested changes Feb 22, 2018

View reviewed changes

d3r3kk added 6 commits February 22, 2018 22:03

Initial addition of favorites and locations API

ef5770d

Complete web test locations API

71be3f5

- favor 'web test' names/descriptions over 'synthetic monitor' as web test is more customer-centric naming - create example data for the web test api

Spelling update

5f53013

Updated parameters for favorite API

373476b

Add favorites API and examples

50f3b9a

- ensure tests run against the applicationinsights folder successfully

Add collectionFormat to comma-separated tags list parameter for favor…

35801f2

…ites - generating API in CSharp generated errors

d3r3kk added 4 commits February 22, 2018 22:03

Enum for favorite type should be set to modelAsString as further favo…

8a56399

…rite types are possible in future.

Update suppressions to include specific instances I need suppressed (…

93ad2b6

…no global suppressions where possible).

Suppress some noisey test warnings from API specifications from my pe…

cc43a1f

…ers.

PR suggestions

8b41209

- Remove x-ms-pageable annotation from our list operation, in the service code we never paganate our data. - Add x-ms-enum annotation to one enum data type where it was missing.

d3r3kk force-pushed the appinsights-faves-locations branch from 1669acc to 8b41209 Compare February 23, 2018 06:03

olydis approved these changes Feb 23, 2018

View reviewed changes

olydis merged commit 2a65f23 into Azure:master Feb 23, 2018

d3r3kk deleted the appinsights-faves-locations branch February 23, 2018 21:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Application Insights: Add Favorites and Web Test Locations APIs #2416

Application Insights: Add Favorites and Web Test Locations APIs #2416

d3r3kk commented Feb 4, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Feb 4, 2018

AutorestCI commented Feb 4, 2018

olydis commented Feb 6, 2018

ravbhatnagar Feb 12, 2018

d3r3kk Feb 20, 2018

johanste Feb 20, 2018

d3r3kk Feb 20, 2018

d3r3kk Feb 21, 2018

ravbhatnagar Feb 12, 2018

zakimaksyutov Feb 13, 2018

d3r3kk Feb 20, 2018

ravbhatnagar Feb 12, 2018

ravbhatnagar commented Feb 15, 2018 •

edited

Loading

d3r3kk commented Feb 20, 2018

devigned Feb 20, 2018

d3r3kk Feb 20, 2018

d3r3kk Feb 21, 2018

olydis Feb 22, 2018

ravbhatnagar commented Feb 21, 2018

lmazuel commented Feb 21, 2018

AutorestCI commented Feb 21, 2018 •

edited

Loading

AutorestCI commented Feb 21, 2018 •

edited

Loading

d3r3kk commented Feb 21, 2018

devigned commented Feb 22, 2018

olydis left a comment

olydis Feb 22, 2018

d3r3kk Feb 23, 2018

olydis Feb 22, 2018

olydis Feb 22, 2018

d3r3kk Feb 23, 2018

olydis Feb 23, 2018

d3r3kk commented Feb 23, 2018

Application Insights: Add Favorites and Web Test Locations APIs #2416

Application Insights: Add Favorites and Web Test Locations APIs #2416

Conversation

d3r3kk commented Feb 4, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Feb 4, 2018

AutorestCI commented Feb 4, 2018

olydis commented Feb 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ravbhatnagar commented Feb 15, 2018 • edited Loading

d3r3kk commented Feb 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ravbhatnagar commented Feb 21, 2018

lmazuel commented Feb 21, 2018

AutorestCI commented Feb 21, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Feb 21, 2018 • edited Loading

Automation for azure-sdk-for-go

d3r3kk commented Feb 21, 2018

devigned commented Feb 22, 2018

olydis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

d3r3kk commented Feb 23, 2018

d3r3kk commented Feb 4, 2018 •

edited by azuresdkci

Loading

ravbhatnagar commented Feb 15, 2018 •

edited

Loading

AutorestCI commented Feb 21, 2018 •

edited

Loading

AutorestCI commented Feb 21, 2018 •

edited

Loading