Fixing entities which should be per ApiRevision instead of just ApiId

[solankisamir]

The following entities are per api revision

• Operations
• Policies
• Diagnostics
• Tags

The following entities are per API

• Products
• Releases
• Revisions

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

[solankisamir]

@promoisha @vfedonkin @darrelmiller can you take a look at the spec.

[AutorestCI]

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2135

[AutorestCI]

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpg3bt856x/rest/specification/apimanagement/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpg3bt856x/sdk', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.89', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4255; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4255/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4255)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.89->2.1.89)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-03"} .
Processing batch task - {"tag":"package-2016-10"} .
Processing batch task - {"tag":"package-2016-07"} .
FATAL: swagger-document/compose - FAILED
FATAL: Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (---
  -
  Subscription credentials which uniquely identify Microsoft Azure subscription.
  The subscription ID forms part of the URI for every service call.
, ---
  -
  Subscription credentials which uniquely identify the Microsoft Azure
  subscription. The subscription ID forms part of the URI for every service
  call.
).
Process() cancelled due to exception : '$.parameters.SubscriptionIdParameter.description' has incompatible values (---
  -
  Subscription credentials which uniquely identify Microsoft Azure subscription.
  The subscription ID forms part of the URI for every service call.
, ---
  -
  Subscription credentials which uniquely identify the Microsoft Azure
  subscription. The subscription ID forms part of the URI for every service
  call.
).
Failure during batch task - {"tag":"package-2016-07"} -- Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (---
  -
  Subscription credentials which uniquely identify Microsoft Azure subscription.
  The subscription ID forms part of the URI for every service call.
, ---
  -
  Subscription credentials which uniquely identify the Microsoft Azure
  subscription. The subscription ID forms part of the URI for every service
  call.
)..
  Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (---
  -
  Subscription credentials which uniquely identify Microsoft Azure subscription.
  The subscription ID forms part of the URI for every service call.
, ---
  -
  Subscription credentials which uniquely identify the Microsoft Azure
  subscription. The subscription ID forms part of the URI for every service
  call.
).

[solankisamir]

@sergey-shandar the failure is not related to my pr, we are hitting some rate limits on github.
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/351121786

Can you review the PR? It would be great if I can incorporate these fixes in the .NET PR Azure/azure-sdk-for-net#4115

[sergey-shandar]

LGTM