Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADLA - ADLS] - Revert path parameters #2417

Merged
merged 2 commits into from
Feb 5, 2018
Merged

[ADLA - ADLS] - Revert path parameters #2417

merged 2 commits into from
Feb 5, 2018

Conversation

ro-joowan
Copy link
Contributor

@ro-joowan ro-joowan commented Feb 4, 2018 •
edited
Loading

Summary: This PR is to revert partially this merged PR (#239) to prevent unnecessary breaking changes at the SDK (and not at the API) level.

  • I was not aware that by defining global parameters, the effective change in the SDK generation is that they become properties of the Client object instead of remaining as method parameters. This is not the behavior that I was expecting, and this causes unnecessary breaking changes. Therefore, I am reverting that change here.

  • I was not aware that some of the job URLs were case sensitive, so reverting these changes as well. I will add the change back in a new API version.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@4939c86

@AutorestCI AutorestCI mentioned this pull request Feb 4, 2018
Closed
@AutorestCI
Copy link

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@9b8ab4a

@AutorestCI AutorestCI mentioned this pull request Feb 4, 2018
Closed
@AutorestCI
Copy link

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@00a7319

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datalake-analytics/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datalake-analytics/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datalake-store/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@5c4ddaa

@ro-joowan ro-joowan mentioned this pull request Feb 5, 2018
Merged
9 tasks
@jhendrixMSFT
Copy link
Member

Note that instead of having to repeat the param definitions you can use the x-ms-parameter-location extension to specify that these params belong on the method not the client.

@ro-joowan
Copy link
Contributor Author

@jhendrixMSFT Thank you for pointing that out! I'll make that change.

@ro-joowan
Adding x-ms-parameter-location
f2b55d5 
* ADLA and ADLS Account APIs
* For ResourceGroupNameParameter
* For AccountNameParameter
@ro-joowan
Reverting URL change from previous PR
feeb7c5
@ro-joowan ro-joowan force-pushed the revert-path-parameters branch from 570176c to feeb7c5 Compare February 5, 2018 18:01
@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datalake-analytics/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datalake-analytics/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datalake-store/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@jhendrixMSFT jhendrixMSFT merged commit 0b96633 into Azure:master Feb 5, 2018
@ro-joowan ro-joowan deleted the revert-path-parameters branch February 5, 2018 19:50
This was referenced Feb 5, 2018
Merged
Closed
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Merge pull request #2417 from Azure/benvi/swagger-cleanup
744ff8c 
Microsoft.Communication Swagger tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ro-joowan @AutorestCI @azuresdkciprbot @jhendrixMSFT