Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic PR of restapi_auto_ro-joowan_account-refactor into master #1889

Closed
wants to merge 1 commit into from

Conversation

AutorestCI
Copy link
Contributor

ADLA Account - Fixing OData parameter
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect Swagger

:param str base_url: Service URL
"""

def __init__(
self, credentials, subscription_id, base_url=None):
self, credentials, subscription_id, resource_group_name, account_name, base_url=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ro-joowan This means your Swagger is incorrect and defines an incorrect parameter-location

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ro-joowan ro-joowan Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmazuel Correct. I fixed this in a PR that came right after this one: Azure/azure-rest-api-specs#2417

@lmazuel lmazuel closed this Feb 6, 2018
@lmazuel lmazuel deleted the restapi_auto_ro-joowan_account-refactor branch February 6, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants