[Hub Generated] Review request for Microsoft.ServiceFabric to add version preview/2023-07-01-preview #25002

a-santamaria · 2023-07-27T01:15:04Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
I commit to follow the Breaking Change Policy.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

If you want for the ARM team to review this PR, you must add the ARMReview label.
The automation may automatically add the ARMReview label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For additional help, see https://aka.ms/azsdk/support/spectools.

openapi-workflow-bot · 2023-07-27T01:15:07Z

Hi, @a-santamaria! Thank you for your pull request. To help get your PR merged:

Ensure you reviewed the checklists in the PR description.

Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

openapi-pipeline-app · 2023-07-27T01:15:07Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 15 Errors, 2 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
managedapplication.json	2023-07-01-preview(8f31050)	2022-01-01(main)
managedapplication.json	2023-07-01-preview(8f31050)	2023-03-01-preview(main)
managedcluster.json	2023-07-01-preview(8f31050)	2022-01-01(main)
managedcluster.json	2023-07-01-preview(8f31050)	2023-03-01-preview(main)
nodetype.json	2023-07-01-preview(8f31050)	2022-01-01(main)
nodetype.json	2023-07-01-preview(8f31050)	2023-03-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured? Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L37:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes' removed or restructured? Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L37:5
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1179:7 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1006:7
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L738:7 Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L671:7
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1225:11 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1052:11
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L150:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L150:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L187:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L187:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L208:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L208:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L214:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L214:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L275:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L265:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1165:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L995:5
`❌` 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1355:11 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1178:11
`❌` 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1473:9 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1261:9
`❌` 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L871:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L719:5
`❌` 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1607:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1311:5

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured? Old: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L37:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes' removed or restructured? Old: Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json#L37:5

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 3 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-2023-07-preview	package-2023-07-preview(8f31050)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getmaintenancewindowstatus' in:'managedMaintenanceWindowStatus_Get'. Consider updating the operationId Location: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L396
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'applymaintenancewindow' in:'managedApplyMaintenanceWindow_Post'. Consider updating the operationId Location: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L439
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Maintenance Window Status Location: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L454

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'ManagedClusterVersion_List' does not match the response definition in the individual GET operation 'ManagedClusterVersion_Get' . Location: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L561
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'ManagedClusterVersion_ListByEnvironment' does not match the response definition in the individual GET operation 'ManagedClusterVersion_GetByEnvironment' . Location: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L601
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getazresiliencystatus' in:'managedAzResiliencyStatus_Get'. Consider updating the operationId Location: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L353

️❌Avocado: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourcegroups/{}/providers/Microsoft.ServiceFabric/managedClusters` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/servicefabricmanagedclusters/resource-manager/readme.md json: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourcegroups/{}/providers/Microsoft.ServiceFabric/managedClusters/{}/nodeTypes` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/servicefabricmanagedclusters/resource-manager/readme.md json: Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-07-27T01:15:08Z

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 80c21c1. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.ServiceFabricManagedClusters [View full logs] [Release SDK Changes]
- Azure.ResourceManager.ServiceFabricManagedClusters.1.1.0-alpha.20230831.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 80c21c1. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.0.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.0.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.0.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-servicefabricmanagedclusters [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group ManagedApplyMaintenanceWindowOperations
info	[Changelog]   - Added operation group ManagedMaintenanceWindowStatusOperations
info	[Changelog]   - Model ManagedCluster has a new parameter ddos_protection_plan_id
info	[Changelog]   - Model ManagedCluster has a new parameter public_ip_prefix_id
info	[Changelog]   - Model NodeType has a new parameter dscp_configuration_id
info	[Changelog]   - Model NodeType has a new parameter nat_gateway_id
info	[Changelog]   - Model NodeType has a new parameter service_artifact_reference_id
info	[Changelog]   - Model NodeType has a new parameter vm_image_plan

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 80c21c1. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️servicefabricmanagedclusters [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 80c21c1. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.servicefabricmanagedclusters.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.servicefabricmanagedclusters.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-07-27T01:15:08Z

Generated ApiView

Language	Package Name	ApiView Link
.Net	Azure.ResourceManager.ServiceFabricManagedClusters	https://apiview.dev/Assemblies/Review/00a28050034a49c3902e3809d448587f

openapi-workflow-bot · 2023-07-27T01:21:29Z

Hi @a-santamaria! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

You cannot proceed with merging this PR until you complete one of the following action items:

ACTION ITEM ALTERNATIVE A: Fix the breaking change.
Please consult the documentation provided in the relevant validation failures.

ACTION ITEM ALTERNATIVE B: Request approval.
Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.

ACTION ITEM ALTERNATIVE C: Report false positive.
If you think there are no breaking changes, i.e. the validation should pass yet it fails, then proceed as explained in ACTION ITEM ALTERNATIVE B.
This applies even if the breaking change tool fails with internal runtime error. In such case a manual breaking change review is necessary.

a-santamaria · 2023-07-27T16:03:41Z

/azp run unifiedPipeline

azure-pipelines · 2023-07-27T16:03:47Z

No commit pushedDate could be found for PR 25002 in repo Azure/azure-rest-api-specs

a-santamaria · 2023-07-27T16:17:32Z

/azp run

azure-pipelines · 2023-07-27T16:17:42Z

Azure Pipelines successfully started running 2 pipeline(s).

a-santamaria · 2023-07-27T16:18:36Z

/azp run unifiedPipeline

azure-pipelines · 2023-07-27T16:18:42Z

No pipelines are associated with this pull request.

a-santamaria · 2023-07-27T16:30:23Z

/azp run unifiedPipeline

azure-pipelines · 2023-07-27T16:30:28Z

No pipelines are associated with this pull request.

a-santamaria · 2023-07-27T16:33:43Z

/azp run

azure-pipelines · 2023-07-27T16:33:49Z

No commit pushedDate could be found for PR 25002 in repo Azure/azure-rest-api-specs

a-santamaria · 2023-08-16T18:02:17Z

Please fix other linter errors introduced by the PR https://github.com/Azure/azure-rest-api-specs/pull/25002/checks?check_run_id=15921551602

@TimLovellSmith the linter error in [must fix] is:
SyncPostReturn | 200 response for a synchronous POST operation must have a response schema specified.Location: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L433

@rkmanda indicated that this is: "False alarm, we fixed this in the staging pipeline and will upgrade to production soon"

a-santamaria · 2023-08-28T18:51:14Z

/pr RequestMerge

sjanamma · 2023-08-29T02:11:15Z

@a-santamaria - Please make sure the R has met the auto merging requirements - https://github.com/Azure/azure-rest-api-specs/pull/25002/checks?check_run_id=15921553176

sjanamma · 2023-08-29T14:13:30Z

Not ready for merge. Please review the requirements https://github.com/Azure/azure-rest-api-specs/pull/25002/checks?check_run_id=15921553176

openapi-pipeline-app · 2023-08-29T17:16:04Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

a-santamaria · 2023-08-29T17:22:04Z

@a-santamaria - Please make sure the R has met the auto merging requirements - https://github.com/Azure/azure-rest-api-specs/pull/25002/checks?check_run_id=15921553176

@sjanamma below is the explanation why the checks are failing:

❌ Swagger LintDiff:
check: SyncPostReturn | 200 response for a synchronous POST operation must have a response schema specified.Location:
@rkmanda indicated that this is: "False alarm, we fixed this in the staging pipeline and will upgrade to production soon"

❌ Swagger Avocado:

check: MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.ServiceFabric/managedClusters is not in the default tag. Please make sure the missing API swaggers are in the default tag.

this is because we rename the path from resourcegroups to resourceGroups to fix the casing. We already got approval for this

❌ Approved-Suppression
the suppressions were suggested by @rkmanda as mentioned in previous comments:

on put request that are long running operations we were getting flagged because we don't return 201. The model we have is described below (which we validated with ARM when we initially created it):

For new cluster, return 200 with ProvisioningState = Creating
For existing cluster, return 202 Accepted + Location header, which links to a ManagedClusterOperationResult resource that:
returns 202 if the update operation is still running
returns 200 if the update operation is completed (resource transition to terminal state)

@rkmanda, suggested to add add this suppression "If your service is old and you are carrying forward the 202 pattern, add a suppression and we will approve it."

konrad-jamrozik · 2023-08-31T22:12:42Z

/azp run

azure-pipelines · 2023-08-31T22:12:54Z

Azure Pipelines successfully started running 2 pipeline(s).

konrad-jamrozik · 2023-08-31T22:20:42Z

@a-santamaria the Avocado check is no longer required to merge a PR. You can confirm this by observing the check Automated merging requirements met no longer mentions Avocado and by lack of the Required label beside Avocado in the list of failing checks at the bottom of the PR. Please proceed as explained in the Next Steps to Merge comment and the diagram: https://aka.ms/azsdk/pr-diagram. Thanks!

sjanamma

approved for merging

openapi-pipeline-app · 2023-08-31T22:23:03Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

…sion preview/2023-07-01-preview (#25002) * copy from 2023-03-01-preview * update specs with api 2023-07-01-preview * update examples * remove ddosProtectionPlanId * fix example names * run prettier * fix ManagedApplyMaintenanceWindowPut_example response * fix spell check * add headers in 202 responses * fix cSpell path * fix casting * add suppressions rules * add ddosProtectionPlanId * fix ARM comments --------- Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>

Alfredo Santamaria Gomez added 4 commits July 26, 2023 16:09

copy from 2023-03-01-preview

276ef36

update specs with api 2023-07-01-preview

1c80b66

update examples

57356be

remove ddosProtectionPlanId

65f34ff

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version resource-manager labels Jul 27, 2023

fix example names

2cec029

run prettier

3a7a3e6

a-santamaria marked this pull request as ready for review July 27, 2023 16:31

openapi-assignment-bot bot assigned rkmanda Jul 27, 2023

AzureRestAPISpecReview added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 27, 2023

TimLovellSmith added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 15, 2023

ms-henglu added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 25, 2023

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 25, 2023

ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 25, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 25, 2023

github-actions bot added the MergeRequested label Aug 28, 2023

a-santamaria changed the title ~~[Hub Generated] Review request for Microsoft.ServiceFabric to add version preview/2023-03-01-preview~~ [Hub Generated] Review request for Microsoft.ServiceFabric to add version preview/2023-07-01-preview Aug 28, 2023

a-santamaria closed this Aug 29, 2023

a-santamaria reopened this Aug 29, 2023

sjanamma added Approved-Suppression and removed SuppressionReviewRequired labels Aug 29, 2023

openapi-pipeline-app bot added the SuppressionReviewRequired label Aug 31, 2023

sjanamma approved these changes Aug 31, 2023

View reviewed changes

sjanamma merged commit 80c21c1 into main Aug 31, 2023
25 of 30 checks passed

sjanamma deleted the a-santamaria--sfmc-2023-07-01-preview branch August 31, 2023 22:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.ServiceFabric to add version preview/2023-07-01-preview #25002

[Hub Generated] Review request for Microsoft.ServiceFabric to add version preview/2023-07-01-preview #25002

a-santamaria commented Jul 27, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jul 27, 2023

openapi-pipeline-app bot commented Jul 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jul 27, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jul 27, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jul 27, 2023

a-santamaria commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

a-santamaria commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

a-santamaria commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

a-santamaria commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

a-santamaria commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

a-santamaria commented Aug 16, 2023

a-santamaria commented Aug 28, 2023

sjanamma commented Aug 29, 2023

sjanamma commented Aug 29, 2023

openapi-pipeline-app bot commented Aug 29, 2023 •

edited

Loading

a-santamaria commented Aug 29, 2023

konrad-jamrozik commented Aug 31, 2023

azure-pipelines bot commented Aug 31, 2023

konrad-jamrozik commented Aug 31, 2023 •

edited

Loading

sjanamma left a comment

openapi-pipeline-app bot commented Aug 31, 2023

[Hub Generated] Review request for Microsoft.ServiceFabric to add version preview/2023-07-01-preview #25002

[Hub Generated] Review request for Microsoft.ServiceFabric to add version preview/2023-07-01-preview #25002

Conversation

a-santamaria commented Jul 27, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

ARM API changes review

Breaking change review

Getting help

openapi-workflow-bot bot commented Jul 27, 2023

openapi-pipeline-app bot commented Jul 27, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jul 27, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jul 27, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Jul 27, 2023

a-santamaria commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

a-santamaria commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

a-santamaria commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

a-santamaria commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

a-santamaria commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

a-santamaria commented Aug 16, 2023

a-santamaria commented Aug 28, 2023

sjanamma commented Aug 29, 2023

sjanamma commented Aug 29, 2023

openapi-pipeline-app bot commented Aug 29, 2023 • edited Loading

a-santamaria commented Aug 29, 2023

konrad-jamrozik commented Aug 31, 2023

azure-pipelines bot commented Aug 31, 2023

konrad-jamrozik commented Aug 31, 2023 • edited Loading

sjanamma left a comment

Choose a reason for hiding this comment

openapi-pipeline-app bot commented Aug 31, 2023

a-santamaria commented Jul 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jul 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jul 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jul 27, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 29, 2023 •

edited

Loading

konrad-jamrozik commented Aug 31, 2023 •

edited

Loading