Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.ServiceFabric to add version preview/2023-07-01-preview #25002

Merged
merged 14 commits into from
Aug 31, 2023

fix ARM comments

8f31050
Select commit
Loading
Failed to load commit list.
Merged

[Hub Generated] Review request for Microsoft.ServiceFabric to add version preview/2023-07-01-preview #25002

fix ARM comments
8f31050
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Breaking Change(Cross-Version) completed Aug 31, 2023 in 2m 22s

Breaking Change(Cross-Version) failed

CrossVersionBreakingChange: 15 Errors, 2 Warnings
The check status is neutral due to the check was suppressed by label Approved-BreakingChange. If you have any question, pls contact vscswagger@microsoft.com
View more details.

Details

compared swaggers (via Oad v0.10.4)] new version base version
managedapplication.json 2023-07-01-preview(8f31050) 2022-01-01(main)
managedapplication.json 2023-07-01-preview(8f31050) 2023-03-01-preview(main)
managedcluster.json 2023-07-01-preview(8f31050) 2022-01-01(main)
managedcluster.json 2023-07-01-preview(8f31050) 2023-03-01-preview(main)
nodetype.json 2023-07-01-preview(8f31050) 2022-01-01(main)
nodetype.json 2023-07-01-preview(8f31050) 2023-03-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured?
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L37:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes' removed or restructured?
Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L37:5
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1179:7
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1006:7
1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L738:7
Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L671:7
1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1225:11
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1052:11
1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L150:13
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L150:13
1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L187:13
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L187:13
1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L208:13
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L208:13
1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L214:13
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L214:13
1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L275:13
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L265:13
1034 - AddedRequiredProperty The new version has new required property 'sku' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1165:5
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L995:5
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1355:11
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1178:11
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1473:9
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1261:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L871:5
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L719:5
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1607:5
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1311:5
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L394:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L398:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L508:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L512:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L686:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L690:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L794:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L798:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L975:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L979:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L1089:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L1093:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L218:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L222:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L321:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L325:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L810:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L437:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L441:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L549:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L553:15
💬 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L37:5
💬 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L346:5
💬 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L389:5
💬 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L432:5
💬 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L37:5
💬 1041 - AddedPropertyInResponse The new version has a new property 'serviceDnsName' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L2305:7
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedapplication.json#L2238:7
💬 1041 - AddedPropertyInResponse The new version has a new property 'zonalUpdateMode' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1242:7
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1069:7
💬 1041 - AddedPropertyInResponse The new version has a new property 'useCustomVnet' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1242:7
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1069:7
💬 1041 - AddedPropertyInResponse The new version has a new property 'publicIPPrefixId' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1242:7
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1069:7
💬 1041 - AddedPropertyInResponse The new version has a new property 'ddosProtectionPlanId' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1242:7
Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1069:7
💬 1041 - AddedPropertyInResponse The new version has a new property 'applicationGatewayBackendAddressPoolId' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L629:7
Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L571:7
💬 1041 - AddedPropertyInResponse The new version has a new property 'zones' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L781:7
Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L692:7
💬 1041 - AddedPropertyInResponse The new version has a new property 'isSpotVM' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L781:7
Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L692:7
💬 1041 - AddedPropertyInResponse The new version has a new property 'hostGroupId' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L781:7
Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L692:7


The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured?
Old: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L37:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes' removed or restructured?
Old: Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json#L37:5
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L394:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L398:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L508:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L512:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L686:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L690:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L794:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L798:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L975:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L979:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L1089:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedapplication.json#L1093:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L218:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L222:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L321:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L325:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L810:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L437:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L441:15
💬 1013 - AddingHeader The new version adds a required header 'Azure-AsyncOperation'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L549:15
💬 1013 - AddingHeader The new version adds a required header 'Location'.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L553:15
💬 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L37:5
💬 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L389:5
💬 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L432:5
💬 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L37:5
💬 1041 - AddedPropertyInResponse The new version has a new property 'ddosProtectionPlanId' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1242:7
Old: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1133:7
💬 1041 - AddedPropertyInResponse The new version has a new property 'serviceArtifactReferenceId' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L781:7
Old: Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json#L761:7
💬 1041 - AddedPropertyInResponse The new version has a new property 'dscpConfigurationId' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L781:7
Old: Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json#L761:7
💬 1045 - AddedOptionalProperty The new version has a new optional property 'ddosProtectionPlanId' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/managedcluster.json#L1242:7
Old: Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json#L1133:7
💬 1045 - AddedOptionalProperty The new version has a new optional property 'serviceArtifactReferenceId' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L781:7
Old: Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json#L761:7
💬 1045 - AddedOptionalProperty The new version has a new optional property 'dscpConfigurationId' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2023-07-01-preview/nodetype.json#L781:7
Old: Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json#L761:7