Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature #25631

Conversation

berndverst
Copy link
Contributor

@berndverst berndverst commented Sep 1, 2023

ARM (Control Plane) API Specification Update Pull Request

  • Adds declarative Dapr PubSub Subscription support by providing Create/Replace, Get and Delete APIs following the established Dapr Component API patterns.

See Container Apps RP PR: https://msazure.visualstudio.com/One/_git/AAPT-Antares-Containerapps/pullrequest/8563796

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Bernd Verst <github@bernd.dev>
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 1, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 1, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
CommonDefinitions.json 2023-08-01-preview(d672541) 2023-05-01(main)
CommonDefinitions.json 2023-08-01-preview(d672541) 2023-05-02-preview(main)
️❌LintDiff: 8 Errors, 14 Warnings failed [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-preview-2023-08 package-preview-2023-08(d672541) package-preview-2023-08(release-app-Microsoft.App-2023-08-01-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
FATAL openapiValidatorPluginFunc: Failed validating:Error: Dependency Cycle Found: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json -> file:///mnt/vss/_work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json
Location: azure-rest-api-specs/blob/d672541da973e036f910a80c36375d59dfbd22ea/#L1
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L913
RPC-Policy-V1-03
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L913
RPC-Policy-V1-03
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L928
RPC-Policy-V1-03
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L960
RPC-Policy-V1-03
ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L18
RPC-Uri-V1-05
ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L67
RPC-Uri-V1-05
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L125
RPC-Async-V1-11, RPC-Put-V1-11
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L929
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L980
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L27
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L30
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L40
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L79
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L96
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L134
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L137
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L163
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L202
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L205
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/ManagedEnvironmentsDaprSubscriptions.json#L222


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L97
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L281
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L412
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L435
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L497
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L497
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L497
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L518
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L522
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L526
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L589
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L606
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L606
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L606
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L715
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L730
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1075
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1189
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1204
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1217
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1278
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1297
PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1315
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L156
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L230
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L350
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L731
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L747
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1076
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json#L1080
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 1, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking




️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 5c8778beaa6d305823bc145e1fe17e64e2f0eb01. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]  notice
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.1.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-appcontainers [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation ContainerAppsAPIClientOperationsMixin.get_custom_domain_verification_id
    info	[Changelog]   - Added operation group BuildersOperations
    info	[Changelog]   - Added operation group BuildsOperations
    info	[Changelog]   - Added operation group DaprSubscriptionsOperations
    info	[Changelog]   - Added operation group ManagedEnvironmentUsagesOperations
    info	[Changelog]   - Added operation group PatchesOperations
    info	[Changelog]   - Added operation group UsagesOperations
    info	[Changelog]   - Model AuthConfig has a new parameter encryption_settings
    info	[Changelog]   - Model AvailableWorkloadProfileProperties has a new parameter gpus
    info	[Changelog]   - Model CertificateProperties has a new parameter type
    info	[Changelog]   - Model DaprComponent has a new parameter service_component_bind
    info	[Changelog]   - Model Ingress has a new parameter additional_port_mappings
    info	[Changelog]   - Model Login has a new parameter token_store
    info	[Changelog]   - Model ManagedEnvironment has a new parameter app_insights_configuration
    info	[Changelog]   - Model ManagedEnvironment has a new parameter open_telemetry_configuration
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 5c8778beaa6d305823bc145e1fe17e64e2f0eb01. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-appcontainers [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 5c8778beaa6d305823bc145e1fe17e64e2f0eb01. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New enum type `BuildProvisioningState` with values `BuildProvisioningStateCanceled`, `BuildProvisioningStateCreating`, `BuildProvisioningStateDeleting`, `BuildProvisioningStateFailed`, `BuildProvisioningStateSucceeded`, `BuildProvisioningStateUpdating`
    info	[Changelog] - New enum type `BuildStatus` with values `BuildStatusCanceled`, `BuildStatusFailed`, `BuildStatusInProgress`, `BuildStatusNotStarted`, `BuildStatusSucceeded`
    info	[Changelog] - New enum type `BuilderProvisioningState` with values `BuilderProvisioningStateCanceled`, `BuilderProvisioningStateCreating`, `BuilderProvisioningStateDeleting`, `BuilderProvisioningStateFailed`, `BuilderProvisioningStateSucceeded`, `BuilderProvisioningStateUpdating`
    info	[Changelog] - New enum type `CertificateType` with values `CertificateTypeImagePullTrustedCA`, `CertificateTypeServerSSLCertificate`
    info	[Changelog] - New enum type `DetectionStatus` with values `DetectionStatusFailed`, `DetectionStatusRegistryLoginFailed`, `DetectionStatusSucceeded`
    info	[Changelog] - New enum type `PatchApplyStatus` with values `PatchApplyStatusCanceled`, `PatchApplyStatusCreatingRevision`, `PatchApplyStatusImagePushPullFailed`, `PatchApplyStatusManuallySkipped`, `PatchApplyStatusNotStarted`, `PatchApplyStatusRebaseFailed`, `PatchApplyStatusRebaseInProgress`, `PatchApplyStatusRevisionCreationFailed`, `PatchApplyStatusSucceeded`
    info	[Changelog] - New enum type `PatchProvisioningState` with values `PatchProvisioningStateCanceled`, `PatchProvisioningStateFailed`, `PatchProvisioningStateSucceeded`
    info	[Changelog] - New enum type `PatchType` with values `PatchTypeFrameworkAndOSSecurity`, `PatchTypeFrameworkSecurity`, `PatchTypeOSSecurity`, `PatchTypeOther`
    info	[Changelog] - New function `NewBuildersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*BuildersClient, error)`
    info	[Changelog] - New function `*BuildersClient.BeginCreateOrUpdate(context.Context, string, string, BuilderResource, *BuildersClientBeginCreateOrUpdateOptions) (*runtime.Poller[BuildersClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*BuildersClient.BeginDelete(context.Context, string, string, *BuildersClientBeginDeleteOptions) (*runtime.Poller[BuildersClientDeleteResponse], error)`
    info	[Changelog] - New function `*BuildersClient.Get(context.Context, string, string, *BuildersClientGetOptions) (BuildersClientGetResponse, error)`
    info	[Changelog] - New function `*BuildersClient.NewListByResourceGroupPager(string, *BuildersClientListByResourceGroupOptions) *runtime.Pager[BuildersClientListByResourceGroupResponse]`
    info	[Changelog] - New function `*BuildersClient.NewListBySubscriptionPager(*BuildersClientListBySubscriptionOptions) *runtime.Pager[BuildersClientListBySubscriptionResponse]`
    info	[Changelog] - New function `*BuildersClient.BeginUpdate(context.Context, string, string, BuilderResourceUpdate, *BuildersClientBeginUpdateOptions) (*runtime.Poller[BuildersClientUpdateResponse], error)`
    info	[Changelog] - New function `NewBuildsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*BuildsClient, error)`
    info	[Changelog] - New function `*BuildsClient.BeginCreateOrUpdate(context.Context, string, string, string, BuildResource, *BuildsClientBeginCreateOrUpdateOptions) (*runtime.Poller[BuildsClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*BuildsClient.BeginDelete(context.Context, string, string, string, *BuildsClientBeginDeleteOptions) (*runtime.Poller[BuildsClientDeleteResponse], error)`
    info	[Changelog] - New function `*BuildsClient.Get(context.Context, string, string, string, *BuildsClientGetOptions) (BuildsClientGetResponse, error)`
    info	[Changelog] - New function `*BuildsClient.NewListByBuilderResourcePager(string, string, *BuildsClientListByBuilderResourceOptions) *runtime.Pager[BuildsClientListByBuilderResourceResponse]`
    info	[Changelog] - New function `*ClientFactory.NewBuildersClient() *BuildersClient`
    info	[Changelog] - New function `*ClientFactory.NewBuildsClient() *BuildsClient`
    info	[Changelog] - New function `*ClientFactory.NewDaprSubscriptionsClient() *DaprSubscriptionsClient`
    info	[Changelog] - New function `*ClientFactory.NewManagedEnvironmentUsagesClient() *ManagedEnvironmentUsagesClient`
    info	[Changelog] - New function `*ClientFactory.NewPatchesClient() *PatchesClient`
    info	[Changelog] - New function `*ClientFactory.NewUsagesClient() *UsagesClient`
    info	[Changelog] - New function `*ContainerAppsAPIClient.GetCustomDomainVerificationID(context.Context, *ContainerAppsAPIClientGetCustomDomainVerificationIDOptions) (ContainerAppsAPIClientGetCustomDomainVerificationIDResponse, error)`
    info	[Changelog] - New function `NewDaprSubscriptionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DaprSubscriptionsClient, error)`
    info	[Changelog] - New function `*DaprSubscriptionsClient.CreateOrUpdate(context.Context, string, string, string, DaprSubscription, *DaprSubscriptionsClientCreateOrUpdateOptions) (DaprSubscriptionsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*DaprSubscriptionsClient.Delete(context.Context, string, string, string, *DaprSubscriptionsClientDeleteOptions) (DaprSubscriptionsClientDeleteResponse, error)`
    info	[Changelog] - New function `*DaprSubscriptionsClient.Get(context.Context, string, string, string, *DaprSubscriptionsClientGetOptions) (DaprSubscriptionsClientGetResponse, error)`
    info	[Changelog] - New function `*DaprSubscriptionsClient.NewListPager(string, string, *DaprSubscriptionsClientListOptions) *runtime.Pager[DaprSubscriptionsClientListResponse]`
    info	[Changelog] - New function `NewManagedEnvironmentUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedEnvironmentUsagesClient, error)`
    info	[Changelog] - New function `*ManagedEnvironmentUsagesClient.NewListPager(string, string, *ManagedEnvironmentUsagesClientListOptions) *runtime.Pager[ManagedEnvironmentUsagesClientListResponse]`
    info	[Changelog] - New function `NewPatchesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PatchesClient, error)`
    info	[Changelog] - New function `*PatchesClient.BeginApply(context.Context, string, string, string, *PatchesClientBeginApplyOptions) (*runtime.Poller[PatchesClientApplyResponse], error)`
    info	[Changelog] - New function `*PatchesClient.BeginDelete(context.Context, string, string, string, *PatchesClientBeginDeleteOptions) (*runtime.Poller[PatchesClientDeleteResponse], error)`
    info	[Changelog] - New function `*PatchesClient.Get(context.Context, string, string, string, *PatchesClientGetOptions) (PatchesClientGetResponse, error)`
    info	[Changelog] - New function `*PatchesClient.ListByBuilderResource(context.Context, string, string, *PatchesClientListByBuilderResourceOptions) (PatchesClientListByBuilderResourceResponse, error)`
    info	[Changelog] - New function `*PatchesClient.BeginSkipConfigure(context.Context, string, string, string, bool, *PatchesClientBeginSkipConfigureOptions) (*runtime.Poller[PatchesClientSkipConfigureResponse], error)`
    info	[Changelog] - New function `NewUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UsagesClient, error)`
    info	[Changelog] - New function `*UsagesClient.NewListPager(string, *UsagesClientListOptions) *runtime.Pager[UsagesClientListResponse]`
    info	[Changelog] - New struct `AppInsightsConfiguration`
    info	[Changelog] - New struct `BlobStorageTokenStore`
    info	[Changelog] - New struct `BuildCollection`
    info	[Changelog] - New struct `BuildConfiguration`
    info	[Changelog] - New struct `BuildProperties`
    info	[Changelog] - New struct `BuildResource`
    info	[Changelog] - New struct `BuilderCollection`
    info	[Changelog] - New struct `BuilderProperties`
    info	[Changelog] - New struct `BuilderResource`
    info	[Changelog] - New struct `BuilderResourceUpdate`
    info	[Changelog] - New struct `BuilderResourceUpdateProperties`
    info	[Changelog] - New struct `ContainerRegistry`
    info	[Changelog] - New struct `ContainerRegistryWithCustomImage`
    info	[Changelog] - New struct `DaprComponentServiceBinding`
    info	[Changelog] - New struct `DaprServiceBindMetadata`
    info	[Changelog] - New struct `DaprSubscription`
    info	[Changelog] - New struct `DaprSubscriptionBulkSubscribeOptions`
    info	[Changelog] - New struct `DaprSubscriptionProperties`
    info	[Changelog] - New struct `DaprSubscriptionRouteRule`
    info	[Changelog] - New struct `DaprSubscriptionRoutes`
    info	[Changelog] - New struct `DaprSubscriptionsCollection`
    info	[Changelog] - New struct `DataDogConfiguration`
    info	[Changelog] - New struct `DestinationsConfiguration`
    info	[Changelog] - New struct `EncryptionSettings`
    info	[Changelog] - New struct `EnvironmentVariable`
    info	[Changelog] - New struct `HTTPGet`
    info	[Changelog] - New struct `IngressPortMapping`
    info	[Changelog] - New struct `ListUsagesResult`
    info	[Changelog] - New struct `LogsConfiguration`
    info	[Changelog] - New struct `MetricsConfiguration`
    info	[Changelog] - New struct `OpenTelemetryConfiguration`
    info	[Changelog] - New struct `PatchCollection`
    info	[Changelog] - New struct `PatchDetails`
    info	[Changelog] - New struct `PatchDetailsNewLayer`
    info	[Changelog] - New struct `PatchDetailsOldLayer`
    info	[Changelog] - New struct `PatchProperties`
    info	[Changelog] - New struct `PatchResource`
    info	[Changelog] - New struct `PreBuildStep`
    info	[Changelog] - New struct `TokenStore`
    info	[Changelog] - New struct `TracesConfiguration`
    info	[Changelog] - New struct `Usage`
    info	[Changelog] - New struct `UsageName`
    info	[Changelog] - New field `EncryptionSettings` in struct `AuthConfigProperties`
    info	[Changelog] - New field `Gpus` in struct `AvailableWorkloadProfileProperties`
    info	[Changelog] - New field `Type` in struct `CertificateProperties`
    info	[Changelog] - New field `ServiceComponentBind` in struct `DaprComponentProperties`
    info	[Changelog] - New field `AdditionalPortMappings` in struct `Ingress`
    info	[Changelog] - New field `TokenStore` in struct `Login`
    info	[Changelog] - New field `AppInsightsConfiguration`, `OpenTelemetryConfiguration` in struct `ManagedEnvironmentProperties`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 171 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 5c8778beaa6d305823bc145e1fe17e64e2f0eb01. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-appcontainers [View full logs]  [Preview SDK Changes]
    Only show 120 items here, please refer to log for details.
    info	[Changelog]   - Added Interface BlobStorageTokenStore
    info	[Changelog]   - Added Interface BuildCollection
    info	[Changelog]   - Added Interface BuildConfiguration
    info	[Changelog]   - Added Interface BuilderCollection
    info	[Changelog]   - Added Interface BuilderResource
    info	[Changelog]   - Added Interface BuilderResourceUpdate
    info	[Changelog]   - Added Interface BuildersCreateOrUpdateHeaders
    info	[Changelog]   - Added Interface BuildersCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface BuildersDeleteHeaders
    info	[Changelog]   - Added Interface BuildersDeleteOptionalParams
    info	[Changelog]   - Added Interface BuildersGetOptionalParams
    info	[Changelog]   - Added Interface BuildersListByResourceGroupNextOptionalParams
    info	[Changelog]   - Added Interface BuildersListByResourceGroupOptionalParams
    info	[Changelog]   - Added Interface BuildersListBySubscriptionNextOptionalParams
    info	[Changelog]   - Added Interface BuildersListBySubscriptionOptionalParams
    info	[Changelog]   - Added Interface BuildersUpdateHeaders
    info	[Changelog]   - Added Interface BuildersUpdateOptionalParams
    info	[Changelog]   - Added Interface BuildResource
    info	[Changelog]   - Added Interface BuildsCreateOrUpdateHeaders
    info	[Changelog]   - Added Interface BuildsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface BuildsDeleteHeaders
    info	[Changelog]   - Added Interface BuildsDeleteOptionalParams
    info	[Changelog]   - Added Interface BuildsGetOptionalParams
    info	[Changelog]   - Added Interface BuildsListByBuilderResourceNextOptionalParams
    info	[Changelog]   - Added Interface BuildsListByBuilderResourceOptionalParams
    info	[Changelog]   - Added Interface ContainerRegistry
    info	[Changelog]   - Added Interface ContainerRegistryWithCustomImage
    info	[Changelog]   - Added Interface DaprComponentServiceBinding
    info	[Changelog]   - Added Interface DaprServiceBindMetadata
    info	[Changelog]   - Added Interface DaprSubscription
    info	[Changelog]   - Added Interface DaprSubscriptionBulkSubscribeOptions
    info	[Changelog]   - Added Interface DaprSubscriptionRouteRule
    info	[Changelog]   - Added Interface DaprSubscriptionRoutes
    info	[Changelog]   - Added Interface DaprSubscriptionsCollection
    info	[Changelog]   - Added Interface DaprSubscriptionsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface DaprSubscriptionsDeleteOptionalParams
    info	[Changelog]   - Added Interface DaprSubscriptionsGetOptionalParams
    info	[Changelog]   - Added Interface DaprSubscriptionsListNextOptionalParams
    info	[Changelog]   - Added Interface DaprSubscriptionsListOptionalParams
    info	[Changelog]   - Added Interface DataDogConfiguration
    info	[Changelog]   - Added Interface DestinationsConfiguration
    info	[Changelog]   - Added Interface EncryptionSettings
    info	[Changelog]   - Added Interface EnvironmentVariable
    info	[Changelog]   - Added Interface GetCustomDomainVerificationIdOptionalParams
    info	[Changelog]   - Added Interface HttpGet
    info	[Changelog]   - Added Interface IngressPortMapping
    info	[Changelog]   - Added Interface ListUsagesResult
    info	[Changelog]   - Added Interface LogsConfiguration
    info	[Changelog]   - Added Interface ManagedEnvironmentUsagesListNextOptionalParams
    info	[Changelog]   - Added Interface ManagedEnvironmentUsagesListOptionalParams
    info	[Changelog]   - Added Interface MetricsConfiguration
    info	[Changelog]   - Added Interface OpenTelemetryConfiguration
    info	[Changelog]   - Added Interface PatchCollection
    info	[Changelog]   - Added Interface PatchDetails
    info	[Changelog]   - Added Interface PatchDetailsNewLayer
    info	[Changelog]   - Added Interface PatchDetailsOldLayer
    info	[Changelog]   - Added Interface PatchesApplyHeaders
    info	[Changelog]   - Added Interface PatchesApplyOptionalParams
    info	[Changelog]   - Added Interface PatchesDeleteHeaders
    info	[Changelog]   - Added Interface PatchesDeleteOptionalParams
    info	[Changelog]   - Added Interface PatchesGetOptionalParams
    info	[Changelog]   - Added Interface PatchesListByBuilderResourceOptionalParams
    info	[Changelog]   - Added Interface PatchesSkipConfigureHeaders
    info	[Changelog]   - Added Interface PatchesSkipConfigureOptionalParams
    info	[Changelog]   - Added Interface PatchProperties
    info	[Changelog]   - Added Interface PatchResource
    info	[Changelog]   - Added Interface PreBuildStep
    info	[Changelog]   - Added Interface TokenStore
    info	[Changelog]   - Added Interface TracesConfiguration
    info	[Changelog]   - Added Interface Usage
    info	[Changelog]   - Added Interface UsageName
    info	[Changelog]   - Added Interface UsagesListNextOptionalParams
    info	[Changelog]   - Added Interface UsagesListOptionalParams
    info	[Changelog]   - Added Type Alias BuilderProvisioningState
    info	[Changelog]   - Added Type Alias BuildersCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias BuildersGetResponse
    info	[Changelog]   - Added Type Alias BuildersListByResourceGroupNextResponse
    info	[Changelog]   - Added Type Alias BuildersListByResourceGroupResponse
    info	[Changelog]   - Added Type Alias BuildersListBySubscriptionNextResponse
    info	[Changelog]   - Added Type Alias BuildersListBySubscriptionResponse
    info	[Changelog]   - Added Type Alias BuildersUpdateResponse
    info	[Changelog]   - Added Type Alias BuildProvisioningState
    info	[Changelog]   - Added Type Alias BuildsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias BuildsGetResponse
    info	[Changelog]   - Added Type Alias BuildsListByBuilderResourceNextResponse
    info	[Changelog]   - Added Type Alias BuildsListByBuilderResourceResponse
    info	[Changelog]   - Added Type Alias BuildStatus
    info	[Changelog]   - Added Type Alias CertificateType
    info	[Changelog]   - Added Type Alias DaprSubscriptionsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias DaprSubscriptionsGetResponse
    info	[Changelog]   - Added Type Alias DaprSubscriptionsListNextResponse
    info	[Changelog]   - Added Type Alias DaprSubscriptionsListResponse
    info	[Changelog]   - Added Type Alias DetectionStatus
    info	[Changelog]   - Added Type Alias GetCustomDomainVerificationIdResponse
    info	[Changelog]   - Added Type Alias ManagedEnvironmentUsagesListNextResponse
    info	[Changelog]   - Added Type Alias ManagedEnvironmentUsagesListResponse
    info	[Changelog]   - Added Type Alias PatchApplyStatus
    info	[Changelog]   - Added Type Alias PatchesApplyResponse
    info	[Changelog]   - Added Type Alias PatchesGetResponse
    info	[Changelog]   - Added Type Alias PatchesListByBuilderResourceResponse
    info	[Changelog]   - Added Type Alias PatchProvisioningState
    info	[Changelog]   - Added Type Alias PatchType
    info	[Changelog]   - Added Type Alias UsagesListNextResponse
    info	[Changelog]   - Added Type Alias UsagesListResponse
    info	[Changelog]   - Interface AuthConfig has a new optional parameter encryptionSettings
    info	[Changelog]   - Interface AvailableWorkloadProfileProperties has a new optional parameter gpus
    info	[Changelog]   - Interface CertificateProperties has a new optional parameter type
    info	[Changelog]   - Interface DaprComponent has a new optional parameter serviceComponentBind
    info	[Changelog]   - Interface Ingress has a new optional parameter additionalPortMappings
    info	[Changelog]   - Interface Login has a new optional parameter tokenStore
    info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter appInsightsConfiguration
    info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter openTelemetryConfiguration
    info	[Changelog]   - Added Enum KnownBuilderProvisioningState
    info	[Changelog]   - Added Enum KnownBuildProvisioningState
    info	[Changelog]   - Added Enum KnownBuildStatus
    info	[Changelog]   - Added Enum KnownCertificateType
    info	[Changelog]   - Added Enum KnownDetectionStatus
    info	[Changelog]   - Added Enum KnownPatchApplyStatus
    info	[Changelog]   - Added Enum KnownPatchProvisioningState
    info	[Changelog]   - Added Enum KnownPatchType
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 5c8778beaa6d305823bc145e1fe17e64e2f0eb01. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.1.0` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from 5c8778beaa6d305823bc145e1fe17e64e2f0eb01. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.app.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.app.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 1, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/appcontainers/armappcontainers https://apiview.dev/Assemblies/Review/fe4f23ddd5024578bb67ee8bc4fc863a
Java azure-resourcemanager-appcontainers https://apiview.dev/Assemblies/Review/b12710930a8c47278af2e553f1f8f59b
JavaScript @azure/arm-appcontainers https://apiview.dev/Assemblies/Review/e2b64387662042c3940b5b2997634ee3
Swagger Microsoft.App https://apiview.dev/Assemblies/Review/2357fe906cc64ef4ba03fba33b18bb4f

Signed-off-by: Bernd Verst <github@bernd.dev>
@berndverst berndverst force-pushed the release-app-Microsoft.App-2023-08-01-preview branch from 8b43e1b to 0a955a4 Compare September 6, 2023 23:52
Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Bernd Verst <github@bernd.dev>
@berndverst berndverst marked this pull request as ready for review September 8, 2023 01:32
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 8, 2023
@berndverst
Copy link
Contributor Author

@rkmanda could you please suppress the LintDiff failure (add the Approved-LintDiff label) as per https://eng.ms/docs/products/azure-developer-experience/design/specs-pr-guides/pr-suppressions process?

I do not see anything wrong with the swagger I wrote and as you can see, the Container Apps RPs use the same pattern (and had the same validation error) previously as well.

@rkmanda
Copy link
Member

rkmanda commented Sep 16, 2023

The use of generic schema is forbidden in ARM unless there is a business scenario that absolutely cannot work without this support. Please book an ARM modeling office hours meeting to explain your scenario and get an approval.

@rkmanda rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 16, 2023
@openapi-workflow-bot
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2023
Signed-off-by: Bernd Verst <github@bernd.dev>
@berndverst berndverst removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 26, 2023
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 26, 2023
@berndverst
Copy link
Contributor Author

berndverst commented Sep 26, 2023

Per API Review discussion upgrades to v5 types.

Generic fields are required - this API is wrapper around the open source product Dapr (dapr.io), and specifically this Kubernetes CRD definition (with a custom converter / validator in the RP):
https://github.com/dapr/dapr/blob/master/charts/dapr/crds/subscription.yaml

Both generic fields and the Boolean field is what the open source users of this product expect. So this will remain unchanged.

@raosuhas
Copy link

Just FYI , I have asked the team to investigate why the incorrect Lint error is being flagged.

@raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 29, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 29, 2023
@raosuhas
Copy link

Team is still investigating so please go ahead with the next steps. You can ignore the Lint Errors

v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch.

This reverts commit 6a43aac.
@berndverst
Copy link
Contributor Author

Please note that using v5 types in this PR causes the Python, GO SDK and others to complain about erroneous duplicate definitions of ProxyResource - reverting it back to v3 types addresses this. We will use v5 when starting a net new API version in the future.

@berndverst
Copy link
Contributor Author

/pr RequestMerge

@sjanamma sjanamma merged commit 7c3a071 into Azure:release-app-Microsoft.App-2023-08-01-preview Oct 5, 2023
26 of 27 checks passed
zizw123 pushed a commit that referenced this pull request Nov 9, 2023
* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add type to Certificate (#25380)

* Add type to Certificate

* lint

* Add gpus property to AvailableWorkloadProfiles. (#25328)

* Add gpus property to AvailableWorkloadProfiles.

* Fix.

* Pauld/re add build and builder (#25442)

* cherry picked the build and builder updates

* some more cleanup

* added arm id format, removed extra properties, and named the resource provisioning states

* Add OT and AI config (#25350)

* Add OT and AI config

* resolve comments

* Add service bind properties to dapr component (#25781)

* dapr component sb-bind definition add

* fix

* ran npx prettier

* npx prettier

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* Adding patching scenario ARM API (#25446)

* cherry picked the build and builder updates

* some more cleanup

* Adding patching scenario and samples

* Added to readme

* Lint fix

* Linting

* Linting error fix

* Addressed comments and added extra properties

* Linting

* Fixing patch skip post action

* Linting

* Addressing comments

* Reverting patchDetails changes

* Fixing pipeline error

* Linting

* Removed invalid required tag

* Fixed examples

* Addressed comments

---------

Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com>
Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com>

* Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631)

* ACA Dapr Subscription: WIP

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add Dapr Subscription examples

Signed-off-by: Bernd Verst <github@bernd.dev>

* complete examples

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add DaprSubscription descriptions

Signed-off-by: Bernd Verst <github@bernd.dev>

* include updated readme

Signed-off-by: Bernd Verst <github@bernd.dev>

* fix casing

Signed-off-by: Bernd Verst <github@bernd.dev>

* formatting

Signed-off-by: Bernd Verst <github@bernd.dev>

* Use Types v5

Signed-off-by: Bernd Verst <github@bernd.dev>

* Revert "Use Types v5"

v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch.

This reverts commit 6a43aac.

---------

Signed-off-by: Bernd Verst <github@bernd.dev>

* Support log streaming on build resource (#25902)

* updated the build resource to support build upload and log streaming, with a token to be passed in via header

* add x-ms-secret and update buildendpoint -> endpoint

* retrieve log stream and upload endpoint tokens through post requests, as they are secrets

* remove secret flag from tokenendpoint property, as we expect users to retrieve it

* rename file

* updated format of how build object returns auth token

* fix example

* added expiration date to token response

* fix auth token to also include build resource information

* renamed getAuthToken -> listAuthToken and removed resource information from token response

* fix examples

* updated samples to be more accurate

* Update serviceBinds with clientType and customizedKeys (#26111)

* Update serviceBinds with clientType and customizedKeys

* force ci

* fix missing }

---------

Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>

* Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107)

* Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview

Signed-off-by: Bernd Verst <github@bernd.dev>

* Update deletion return code

* Fix variable name

* Remove invalid status code from example

* prettify

* Register new resource in readme

* Remove existing import cycle

* Use integers not integer strings

* Fix delete status codes

* More changes

* Update examples

* Revert "Remove existing import cycle" which causes unrelated failures

This reverts commit 8ce1a74.

---------

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add API spec for ContainerApp Resiliency (#25732)

Signed-off-by: Hal Spang <halspang@microsoft.com>

* Add extendedlocation for job (#26196)

* Add extendedlocation for job

* Add sample for container apps on connectedEnvironment

* Fixes for examples

* Fix connected environment example

* Update old examples

* removing SourceToCloud patching from 08-01-preview (#26245)

* Add diagnostic routes to Container App Jobs (#26227)

* Add diagnostic routes to Container App Jobs

* Update

* Update

* Update

* Update

* Update

* Update

* Update operationIds

---------

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Update app resiliency rest api spec (#26357)

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>

* Fix ACA component resiliency examples (#26441)

* Fix arm review comments for container app (#26455)

* update

* update

* update

* Fix SDK build error for Microsoft.App (#26416)

* Fix SDK build error for Microsoft.App

* Update

* update

* update

* update

---------

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix arm review comments for container app (#26479)

* fix

* update

* update

* Fix detectorProperties request path (#26431)

* fix list exception

* change param to enum

* fix lint error

* revert not working changes

* fix enum

* rearrange

---------

Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>

* Enable dynamicJsonColumns for log analytics configuration (#26432)

* Enable dynamicJsonColumn for log analysis configuration

* Add missed s

* Fix code style

* Update container app usages value to float (#26448)

* update

* update

* update

* Fix App Resiliency retry example (#26560)

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>

* Fix lint warning for container app (#26523)

* fix warning

* fix warning

* upate

---------

Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Hal Spang <halspang@microsoft.com>
Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com>
Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com>
Co-authored-by: Bernd Verst <bernd.verst@microsoft.com>
Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: halspang <70976921+halspang@users.noreply.github.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Yash Nisar <yashnisar@microsoft.com>
Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com>
Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
sjanamma pushed a commit that referenced this pull request Nov 30, 2023
* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add type to Certificate (#25380)

* Add type to Certificate

* lint

* Add gpus property to AvailableWorkloadProfiles. (#25328)

* Add gpus property to AvailableWorkloadProfiles.

* Fix.

* Pauld/re add build and builder (#25442)

* cherry picked the build and builder updates

* some more cleanup

* added arm id format, removed extra properties, and named the resource provisioning states

* Add OT and AI config (#25350)

* Add OT and AI config

* resolve comments

* Add service bind properties to dapr component (#25781)

* dapr component sb-bind definition add

* fix

* ran npx prettier

* npx prettier

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* Adding patching scenario ARM API (#25446)

* cherry picked the build and builder updates

* some more cleanup

* Adding patching scenario and samples

* Added to readme

* Lint fix

* Linting

* Linting error fix

* Addressed comments and added extra properties

* Linting

* Fixing patch skip post action

* Linting

* Addressing comments

* Reverting patchDetails changes

* Fixing pipeline error

* Linting

* Removed invalid required tag

* Fixed examples

* Addressed comments

---------

Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com>
Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com>

* Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631)

* ACA Dapr Subscription: WIP

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add Dapr Subscription examples

Signed-off-by: Bernd Verst <github@bernd.dev>

* complete examples

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add DaprSubscription descriptions

Signed-off-by: Bernd Verst <github@bernd.dev>

* include updated readme

Signed-off-by: Bernd Verst <github@bernd.dev>

* fix casing

Signed-off-by: Bernd Verst <github@bernd.dev>

* formatting

Signed-off-by: Bernd Verst <github@bernd.dev>

* Use Types v5

Signed-off-by: Bernd Verst <github@bernd.dev>

* Revert "Use Types v5"

v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch.

This reverts commit 6a43aac.

---------

Signed-off-by: Bernd Verst <github@bernd.dev>

* Support log streaming on build resource (#25902)

* updated the build resource to support build upload and log streaming, with a token to be passed in via header

* add x-ms-secret and update buildendpoint -> endpoint

* retrieve log stream and upload endpoint tokens through post requests, as they are secrets

* remove secret flag from tokenendpoint property, as we expect users to retrieve it

* rename file

* updated format of how build object returns auth token

* fix example

* added expiration date to token response

* fix auth token to also include build resource information

* renamed getAuthToken -> listAuthToken and removed resource information from token response

* fix examples

* updated samples to be more accurate

* Update serviceBinds with clientType and customizedKeys (#26111)

* Update serviceBinds with clientType and customizedKeys

* force ci

* fix missing }

---------

Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>

* Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107)

* Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview

Signed-off-by: Bernd Verst <github@bernd.dev>

* Update deletion return code

* Fix variable name

* Remove invalid status code from example

* prettify

* Register new resource in readme

* Remove existing import cycle

* Use integers not integer strings

* Fix delete status codes

* More changes

* Update examples

* Revert "Remove existing import cycle" which causes unrelated failures

This reverts commit 8ce1a74.

---------

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add API spec for ContainerApp Resiliency (#25732)

Signed-off-by: Hal Spang <halspang@microsoft.com>

* Add extendedlocation for job (#26196)

* Add extendedlocation for job

* Add sample for container apps on connectedEnvironment

* Fixes for examples

* Fix connected environment example

* Update old examples

* removing SourceToCloud patching from 08-01-preview (#26245)

* Add diagnostic routes to Container App Jobs (#26227)

* Add diagnostic routes to Container App Jobs

* Update

* Update

* Update

* Update

* Update

* Update

* Update operationIds

---------

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Update app resiliency rest api spec (#26357)

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>

* Fix ACA component resiliency examples (#26441)

* Fix arm review comments for container app (#26455)

* update

* update

* update

* Fix SDK build error for Microsoft.App (#26416)

* Fix SDK build error for Microsoft.App

* Update

* update

* update

* update

---------

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix arm review comments for container app (#26479)

* fix

* update

* update

* Fix detectorProperties request path (#26431)

* fix list exception

* change param to enum

* fix lint error

* revert not working changes

* fix enum

* rearrange

---------

Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>

* Enable dynamicJsonColumns for log analytics configuration (#26432)

* Enable dynamicJsonColumn for log analysis configuration

* Add missed s

* Fix code style

* Update container app usages value to float (#26448)

* update

* update

* update

* Fix App Resiliency retry example (#26560)

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>

* Fix lint warning for container app (#26523)

* fix warning

* fix warning

* upate

* update tests for jobs

* update tests for jobs

* fix name and resource values in examples

* fix name and resource values in examples

* fix name and resource values in examples

* fix name and resource values in examples

---------

Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Hal Spang <halspang@microsoft.com>
Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com>
Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com>
Co-authored-by: Bernd Verst <bernd.verst@microsoft.com>
Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: halspang <70976921+halspang@users.noreply.github.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Yash Nisar <yashnisar@microsoft.com>
Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com>
Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
zman-ms pushed a commit that referenced this pull request Jan 10, 2024
* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add type to Certificate (#25380)

* Add type to Certificate

* lint

* Add gpus property to AvailableWorkloadProfiles. (#25328)

* Add gpus property to AvailableWorkloadProfiles.

* Fix.

* Pauld/re add build and builder (#25442)

* cherry picked the build and builder updates

* some more cleanup

* added arm id format, removed extra properties, and named the resource provisioning states

* Add OT and AI config (#25350)

* Add OT and AI config

* resolve comments

* Add service bind properties to dapr component (#25781)

* dapr component sb-bind definition add

* fix

* ran npx prettier

* npx prettier

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* Adding patching scenario ARM API (#25446)

* cherry picked the build and builder updates

* some more cleanup

* Adding patching scenario and samples

* Added to readme

* Lint fix

* Linting

* Linting error fix

* Addressed comments and added extra properties

* Linting

* Fixing patch skip post action

* Linting

* Addressing comments

* Reverting patchDetails changes

* Fixing pipeline error

* Linting

* Removed invalid required tag

* Fixed examples

* Addressed comments

---------

Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com>
Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com>

* Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631)

* ACA Dapr Subscription: WIP

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add Dapr Subscription examples

Signed-off-by: Bernd Verst <github@bernd.dev>

* complete examples

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add DaprSubscription descriptions

Signed-off-by: Bernd Verst <github@bernd.dev>

* include updated readme

Signed-off-by: Bernd Verst <github@bernd.dev>

* fix casing

Signed-off-by: Bernd Verst <github@bernd.dev>

* formatting

Signed-off-by: Bernd Verst <github@bernd.dev>

* Use Types v5

Signed-off-by: Bernd Verst <github@bernd.dev>

* Revert "Use Types v5"

v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch.

This reverts commit 6a43aac.

---------

Signed-off-by: Bernd Verst <github@bernd.dev>

* Support log streaming on build resource (#25902)

* updated the build resource to support build upload and log streaming, with a token to be passed in via header

* add x-ms-secret and update buildendpoint -> endpoint

* retrieve log stream and upload endpoint tokens through post requests, as they are secrets

* remove secret flag from tokenendpoint property, as we expect users to retrieve it

* rename file

* updated format of how build object returns auth token

* fix example

* added expiration date to token response

* fix auth token to also include build resource information

* renamed getAuthToken -> listAuthToken and removed resource information from token response

* fix examples

* updated samples to be more accurate

* Update serviceBinds with clientType and customizedKeys (#26111)

* Update serviceBinds with clientType and customizedKeys

* force ci

* fix missing }

---------

Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>

* Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107)

* Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview

Signed-off-by: Bernd Verst <github@bernd.dev>

* Update deletion return code

* Fix variable name

* Remove invalid status code from example

* prettify

* Register new resource in readme

* Remove existing import cycle

* Use integers not integer strings

* Fix delete status codes

* More changes

* Update examples

* Revert "Remove existing import cycle" which causes unrelated failures

This reverts commit 8ce1a74.

---------

Signed-off-by: Bernd Verst <github@bernd.dev>

* Add API spec for ContainerApp Resiliency (#25732)

Signed-off-by: Hal Spang <halspang@microsoft.com>

* Add extendedlocation for job (#26196)

* Add extendedlocation for job

* Add sample for container apps on connectedEnvironment

* Fixes for examples

* Fix connected environment example

* Update old examples

* removing SourceToCloud patching from 08-01-preview (#26245)

* Add diagnostic routes to Container App Jobs (#26227)

* Add diagnostic routes to Container App Jobs

* Update

* Update

* Update

* Update

* Update

* Update

* Update operationIds

---------

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Update app resiliency rest api spec (#26357)

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>

* Fix ACA component resiliency examples (#26441)

* Fix arm review comments for container app (#26455)

* update

* update

* update

* Fix SDK build error for Microsoft.App (#26416)

* Fix SDK build error for Microsoft.App

* Update

* update

* update

* update

---------

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix arm review comments for container app (#26479)

* fix

* update

* update

* Fix detectorProperties request path (#26431)

* fix list exception

* change param to enum

* fix lint error

* revert not working changes

* fix enum

* rearrange

---------

Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>

* Enable dynamicJsonColumns for log analytics configuration (#26432)

* Enable dynamicJsonColumn for log analysis configuration

* Add missed s

* Fix code style

* Update container app usages value to float (#26448)

* update

* update

* update

* Fix App Resiliency retry example (#26560)

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>

* Fix lint warning for container app (#26523)

* fix warning

* fix warning

* upate

---------

Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Hal Spang <halspang@microsoft.com>
Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com>
Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com>
Co-authored-by: Bernd Verst <bernd.verst@microsoft.com>
Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: halspang <70976921+halspang@users.noreply.github.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Yash Nisar <yashnisar@microsoft.com>
Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com>
Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants