Release app microsoft.app 2023 08 01 preview #26352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preview to version 2023-08-01-preview
* Add type to Certificate * lint
* Add gpus property to AvailableWorkloadProfiles. * Fix.
* cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states
* Add OT and AI config * resolve comments
* dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
* cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com>
…feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <github@bernd.dev> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <github@bernd.dev> * complete examples Signed-off-by: Bernd Verst <github@bernd.dev> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <github@bernd.dev> * include updated readme Signed-off-by: Bernd Verst <github@bernd.dev> * fix casing Signed-off-by: Bernd Verst <github@bernd.dev> * formatting Signed-off-by: Bernd Verst <github@bernd.dev> * Use Types v5 Signed-off-by: Bernd Verst <github@bernd.dev> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <github@bernd.dev>
* updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate
* Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
…se app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <github@bernd.dev> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Hal Spang <halspang@microsoft.com>
* Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples
* Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| AuthConfigs.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| AuthConfigs.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| AvailableWorkloadProfiles.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| AvailableWorkloadProfiles.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| BillingMeters.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| BillingMeters.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| CommonDefinitions.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| CommonDefinitions.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| ConnectedEnvironments.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| ConnectedEnvironments.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| ConnectedEnvironmentsCertificates.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| ConnectedEnvironmentsCertificates.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| ConnectedEnvironmentsDaprComponents.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| ConnectedEnvironmentsDaprComponents.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| ConnectedEnvironmentsStorages.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| ConnectedEnvironmentsStorages.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| ContainerApps.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| ContainerApps.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| ContainerAppsRevisions.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| ContainerAppsRevisions.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| Diagnostics.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| Diagnostics.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| Global.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| Global.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| Jobs.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| Jobs.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| ManagedEnvironments.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| ManagedEnvironments.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| ManagedEnvironmentsDaprComponents.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| ManagedEnvironmentsDaprComponents.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| ManagedEnvironmentsStorages.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| ManagedEnvironmentsStorages.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| SourceControls.json | 2023-08-01-preview(bce2de7) | 2023-05-01(main) |
| SourceControls.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| Subscriptions.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
| Usages.json | 2023-08-01-preview(bce2de7) | 2023-05-02-preview(main) |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 53 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-preview-2023-08 | package-preview-2023-08(bce2de7) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/AuthConfigs.json#L18 |
|
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/AuthConfigs.json#L67 |
|
The resource name parameter 'authConfigName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/AuthConfigs.json#L67 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.App/preview/2023-08-01-preview/AuthConfigs.json#L119 |
|
Property name should be camel case. Location: Microsoft.App/preview/2023-08-01-preview/AuthConfigs.json#L601 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.App/preview/2023-08-01-preview/BillingMeters.json#L37 |
|
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironments.json#L100 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironments.json#L198 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironments.json#L208 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironments.json#L255 |
|
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironments.json#L311 |
|
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsCertificates.json#L18 |
|
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsCertificates.json#L68 |
|
The resource name parameter 'certificateName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsCertificates.json#L68 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsCertificates.json#L121 |
|
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsDaprComponents.json#L18 |
|
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsDaprComponents.json#L67 |
|
The resource name parameter 'componentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsDaprComponents.json#L67 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsDaprComponents.json#L119 |
|
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsDaprComponents.json#L235 |
|
The resource name parameter 'componentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsDaprComponents.json#L235 |
|
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsStorages.json#L18 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsStorages.json#L47 |
|
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsStorages.json#L65 |
|
The resource name parameter 'storageName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsStorages.json#L65 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.App/preview/2023-08-01-preview/ConnectedEnvironmentsStorages.json#L118 |
|
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-08-01-preview/ContainerApps.json#L99 |
|
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.App/preview/2023-08-01-preview/ContainerApps.json#L131 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-08-01-preview/ContainerApps.json#L198 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.App/preview/2023-08-01-preview/ContainerApps.json#L221 |
️❌Avocado: 1 Errors, 1 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.App/connectedEnvironments/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/app/resource-manager/readme.md json: Microsoft.App/preview/2022-06-01-preview/ConnectedEnvironments.json |
| The JSON file has a circular reference. readme: specification/app/resource-manager/readme.md json: Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Oct 24, 2023
* fix warning * fix warning * upate
Juliehzl
added
the
WaitForARMFeedback
openapi-workflow-bot
bot
removed
the
ARMChangesRequested
For warnings to use latest v4 types, I have tried but JS SDK owner asked to use v3 in #26523 (comment). And for boolean check, the enum value is get approved in #26432. So I don't want to change it. And all our PRs are reviewed in previous separated PR. Why do arm side still have so many additional changes now instead of in previous one? If you still have review comments, pls tell us one time. Fixing review feedback one by one waste so much and we cannot wait for it. |
|
We are urgent to merge and release. pls help merge asap. this PR has been open for several weeks! |
Duplicated from below, also, was anti-pattern already existed in the stable version? If so, please remove this suppression, we can just approve as it is. An item will be auto raised to track the fix, going forward, you should have a plan to fix this anti-pattern. Refers to: specification/app/resource-manager/readme.md:69 in bce2de7. [](commit_id = bce2de7, deletion_comment = False) |
|
The rest of the PR is good, as they've already been reviewed in separate PRs. |
zizw123
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
The suppression you mentioned is added in PR https://github.com/Azure/azure-rest-api-specs/pull/25442/files which is also arm reviewer signed off and arm reviewer added Approved-Suppression. Without the suppression, we will get lint error as below: The mentioned builders/build resource type is newly added in this api version, but the error response format already is same with other existing resource type. As I do not have permission to write to feature branch release-app-Microsoft.App-2023-08-01-preview. I would prefer keeping it as it is now. |
Juliehzl
added
the
WaitForARMFeedback
openapi-workflow-bot
bot
removed
the
ARMChangesRequested
I see, in this case, we can leave as it is, approving |
zizw123
added
Approved-Suppression
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/pr RequestMerge |
zizw123
approved these changes
Nov 9, 2023
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Nov 9, 2023
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Adds base for updating Microsoft.App from version preview/2023-05-02-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * Add type to Certificate (#25380) * Add type to Certificate * lint * Add gpus property to AvailableWorkloadProfiles. (#25328) * Add gpus property to AvailableWorkloadProfiles. * Fix. * Pauld/re add build and builder (#25442) * cherry picked the build and builder updates * some more cleanup * added arm id format, removed extra properties, and named the resource provisioning states * Add OT and AI config (#25350) * Add OT and AI config * resolve comments * Add service bind properties to dapr component (#25781) * dapr component sb-bind definition add * fix * ran npx prettier * npx prettier --------- Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> * Adding patching scenario ARM API (#25446) * cherry picked the build and builder updates * some more cleanup * Adding patching scenario and samples * Added to readme * Lint fix * Linting * Linting error fix * Addressed comments and added extra properties * Linting * Fixing patch skip post action * Linting * Addressing comments * Reverting patchDetails changes * Fixing pipeline error * Linting * Removed invalid required tag * Fixed examples * Addressed comments --------- Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> * Update microsoft.app 2023-08-01-preview for new DaprSubscription API feature (#25631) * ACA Dapr Subscription: WIP Signed-off-by: Bernd Verst <github@bernd.dev> * Add Dapr Subscription examples Signed-off-by: Bernd Verst <github@bernd.dev> * complete examples Signed-off-by: Bernd Verst <github@bernd.dev> * Add DaprSubscription descriptions Signed-off-by: Bernd Verst <github@bernd.dev> * include updated readme Signed-off-by: Bernd Verst <github@bernd.dev> * fix casing Signed-off-by: Bernd Verst <github@bernd.dev> * formatting Signed-off-by: Bernd Verst <github@bernd.dev> * Use Types v5 Signed-off-by: Bernd Verst <github@bernd.dev> * Revert "Use Types v5" v5 causes several mysterious SDK build errors in this branch on this PR. To avoid this error we will stick to v3 for now. We will upgrade to v5 in a future net new branch. This reverts commit 6a43aac. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Support log streaming on build resource (#25902) * updated the build resource to support build upload and log streaming, with a token to be passed in via header * add x-ms-secret and update buildendpoint -> endpoint * retrieve log stream and upload endpoint tokens through post requests, as they are secrets * remove secret flag from tokenendpoint property, as we expect users to retrieve it * rename file * updated format of how build object returns auth token * fix example * added expiration date to token response * fix auth token to also include build resource information * renamed getAuthToken -> listAuthToken and removed resource information from token response * fix examples * updated samples to be more accurate * Update serviceBinds with clientType and customizedKeys (#26111) * Update serviceBinds with clientType and customizedKeys * force ci * fix missing } --------- Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> * Adds new Dapr Component Resiliency Feature to existing version `Release app microsoft.app 2023 08 01 preview` (#26107) * Add Dapr Component Resiliency Policies APIs to ContainerApps 2023-08-01-preview Signed-off-by: Bernd Verst <github@bernd.dev> * Update deletion return code * Fix variable name * Remove invalid status code from example * prettify * Register new resource in readme * Remove existing import cycle * Use integers not integer strings * Fix delete status codes * More changes * Update examples * Revert "Remove existing import cycle" which causes unrelated failures This reverts commit 8ce1a74. --------- Signed-off-by: Bernd Verst <github@bernd.dev> * Add API spec for ContainerApp Resiliency (#25732) Signed-off-by: Hal Spang <halspang@microsoft.com> * Add extendedlocation for job (#26196) * Add extendedlocation for job * Add sample for container apps on connectedEnvironment * Fixes for examples * Fix connected environment example * Update old examples * removing SourceToCloud patching from 08-01-preview (#26245) * Add diagnostic routes to Container App Jobs (#26227) * Add diagnostic routes to Container App Jobs * Update * Update * Update * Update * Update * Update * Update operationIds --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Update app resiliency rest api spec (#26357) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix ACA component resiliency examples (#26441) * Fix arm review comments for container app (#26455) * update * update * update * Fix SDK build error for Microsoft.App (#26416) * Fix SDK build error for Microsoft.App * Update * update * update * update --------- Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix arm review comments for container app (#26479) * fix * update * update * Fix detectorProperties request path (#26431) * fix list exception * change param to enum * fix lint error * revert not working changes * fix enum * rearrange --------- Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com> * Enable dynamicJsonColumns for log analytics configuration (#26432) * Enable dynamicJsonColumn for log analysis configuration * Add missed s * Fix code style * Update container app usages value to float (#26448) * update * update * update * Fix App Resiliency retry example (#26560) Signed-off-by: Yash Nisar <yashnisar@microsoft.com> * Fix lint warning for container app (#26523) * fix warning * fix warning * upate --------- Signed-off-by: Bernd Verst <github@bernd.dev> Signed-off-by: Hal Spang <halspang@microsoft.com> Signed-off-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: Michael Dai <michaelkira@live.cn> Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com> Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com> Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> Co-authored-by: Bernd Verst <bernd.verst@microsoft.com> Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: halspang <70976921+halspang@users.noreply.github.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Yash Nisar <yashnisar@microsoft.com> Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com> Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.