Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection #29251

Merged
merged 8 commits into from
Jun 18, 2024

Update

705762b
Select commit
Loading
Failed to load commit list.
Merged

Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection #29251

Update
705762b
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff succeeded Jun 13, 2024 in 16m 54s

Swagger LintDiff succeeded

LintDiff
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.2) new version base version
package-2024-01 package-2024-01(705762b) package-2024-01(release-network-Microsoft.Network-2024-01-01)

The following errors/warnings exist before current PR submission:

Rule Message
❌ ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L130
❌ ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L179
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L179
❌ ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L298
❌ ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L351
❌ ResourceNameRestriction The resource name parameter 'peeringName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L351
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L352
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L391
❌ PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L544
❌ ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L544
❌ ResourceNameRestriction The resource name parameter 'peeringName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L544
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L594
❌ PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L615
❌ ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L615
❌ ResourceNameRestriction The resource name parameter 'peeringName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L615
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L665
❌ PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L686
❌ ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L686
❌ ResourceNameRestriction The resource name parameter 'peeringName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L686
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L736
❌ MissingTypeObject The schema 'ExpressRouteCrossConnectionRoutesTableSummary' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L759
❌ MissingTypeObject The schema 'ExpressRouteCrossConnectionsRoutesTableSummaryListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L781
❌ MissingTypeObject The schema 'ExpressRouteCircuitReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L798
❌ MissingTypeObject The schema 'ExpressRouteCrossConnectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L807
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L819
❌ AllTrackedResourcesMustHaveDelete The resource ExpressRouteCrossConnection does not have a corresponding delete operation.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L862
❌ MissingTypeObject The schema 'ExpressRouteCrossConnection' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L862
❌ MissingTypeObject The schema 'ExpressRouteCrossConnectionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L882
❌ MissingTypeObject The schema 'ExpressRouteCrossConnectionPeeringProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L899
❌ MissingTypeObject The schema 'ExpressRouteCrossConnectionPeering' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L974
❌ MissingTypeObject The schema 'ExpressRouteCrossConnectionPeeringList' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L998
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L93
⚠️ RequiredReadOnlySystemData The response of operation:'ExpressRouteCrossConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L131
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L139
⚠️ RequiredReadOnlySystemData The response of operation:'ExpressRouteCrossConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L179
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L187
⚠️ RequiredReadOnlySystemData The response of operation:'ExpressRouteCrossConnections_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L240
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L248
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L307
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L360
⚠️ RequiredReadOnlySystemData The response of operation:'ExpressRouteCrossConnectionPeerings_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L414
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L422
⚠️ RequiredReadOnlySystemData The response of operation:'ExpressRouteCrossConnectionPeerings_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L469
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L477
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L553
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L624
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L695
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L783
View more details on openapi-pipeline-app