-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection #29251
Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection #29251
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.9) | new version | base version |
---|---|---|
expressRouteCrossConnection.json | 2024-01-01(705762b) | 2023-11-01(main) |
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-2024-01 | package-2024-01(705762b) | package-2024-01(release-network-Microsoft.Network-2024-01-01) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L130 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L179 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L179 |
ResourceNameRestriction |
The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L298 |
ResourceNameRestriction |
The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L351 |
ResourceNameRestriction |
The resource name parameter 'peeringName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L351 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L352 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L391 |
PathForResourceAction |
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L544 |
ResourceNameRestriction |
The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L544 |
ResourceNameRestriction |
The resource name parameter 'peeringName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L544 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L594 |
PathForResourceAction |
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L615 |
ResourceNameRestriction |
The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L615 |
ResourceNameRestriction |
The resource name parameter 'peeringName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L615 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L665 |
PathForResourceAction |
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L686 |
ResourceNameRestriction |
The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L686 |
ResourceNameRestriction |
The resource name parameter 'peeringName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L686 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L736 |
MissingTypeObject |
The schema 'ExpressRouteCrossConnectionRoutesTableSummary' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L759 |
MissingTypeObject |
The schema 'ExpressRouteCrossConnectionsRoutesTableSummaryListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L781 |
MissingTypeObject |
The schema 'ExpressRouteCircuitReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L798 |
MissingTypeObject |
The schema 'ExpressRouteCrossConnectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L807 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L819 |
AllTrackedResourcesMustHaveDelete |
The resource ExpressRouteCrossConnection does not have a corresponding delete operation. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L862 |
MissingTypeObject |
The schema 'ExpressRouteCrossConnection' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L862 |
MissingTypeObject |
The schema 'ExpressRouteCrossConnectionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L882 |
MissingTypeObject |
The schema 'ExpressRouteCrossConnectionPeeringProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L899 |
MissingTypeObject |
The schema 'ExpressRouteCrossConnectionPeering' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L974 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
...etwork/resource-manager/Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
check the CLA comments as the cla check is required |
@microsoft-github-policy-service agree company="Microsoft" |
…zhao_crossconnectionname
Pending answer on the thread started by @rkmanda. |
…nzhao1992/azure-rest-api-specs into jianzhao_crossconnectionname
/azp run |
Commenter does not have sufficient privileges for PR 29251 in repo Azure/azure-rest-api-specs |
/azp run |
Commenter does not have sufficient privileges for PR 29251 in repo Azure/azure-rest-api-specs |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
/pr RequestMerge |
@jianzhao1992 - You should be able to merge this PR yourself. ARM reviewers don't have control over your release branch: we only merge PRs to main and RPSaaSMaster. |
3a6c7d9
into
Azure:release-network-Microsoft.Network-2024-01-01
…ssRoute CrossConnection (#29251) * Add CrossConnection name as an optional query parameter for List CrossConnection * update example * Addressing comments * Change to OData filtering * Fix the parameter reference * Update --------- Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com>
…29302) * Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01 * Updates readme * Updates API version in new specs and examples * Add examples for Subnet peering and v6 Subnet peering. (#28827) Add examples for Subnet peering and v6 Subnet peering. --------- Co-authored-by: saurabh83 <saugu@microsoft.com> * Init (#29127) Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048) Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> * Added NoHealthyBackendsBehavior (#28868) Added the property "NoHealthyBackendsBehavior" to the Probe properties. * VirtualNetworkGatewayConnection using key vault for authentication. (#28760) * Add parameters for cert based auth connection * retrigger checks * retrigger checks * lintDiff * Trigger Build * revert PATCH changes * fix * change managed identity to v5 * add format and description * rresolving conflict * resolving readme file * Revert "VirtualNetworkGatewayConnection using key vault for authentication. (#28760)" This reverts commit c37ec24. * Lint diff error suppress * Guptavertika/release network microsoft.network official 2024 01 01 (#29367) * added networkidentifier under vnet->subet->serviceendpoint * added format :armid and updated description * corrected the type * fixed response * response type fixed example --------- Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> * Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339) (#29375) * Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357) (#29376) * Fix * Fix2 --------- Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251) * Add CrossConnection name as an optional query parameter for List CrossConnection * update example * Addressing comments * Change to OData filtering * Fix the parameter reference * Update --------- Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> * initial changes (#29235) * Changed type of networkIdentifier from PublicIPAddress to SubResource (#29469) * added networkidentifier under vnet->subet->serviceendpoint * added format :armid and updated description * corrected the type * fixed response * response type fixed example * Changed type of networkIdentifier from ./publicIpAddress.json#/definitions/PublicIPAddress to ./network.json#/definitions/SubResource --------- Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> --------- Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: Abhishek Shah <16267081+abhi7860@users.noreply.github.com> Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: daweiwang-microsoft <165709729+daweiwang-microsoft@users.noreply.github.com> Co-authored-by: Bhupesh Kumar Bhatt <52891188+bhupeshbhatt1985@users.noreply.github.com> Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jianzhao1992 <125631957+jianzhao1992@users.noreply.github.com> Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
#29473) * Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01 * Updates readme * Updates API version in new specs and examples * Add examples for Subnet peering and v6 Subnet peering. (#28827) Add examples for Subnet peering and v6 Subnet peering. --------- Co-authored-by: saurabh83 <saugu@microsoft.com> * Init (#29127) Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048) Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> * Added NoHealthyBackendsBehavior (#28868) Added the property "NoHealthyBackendsBehavior" to the Probe properties. * VirtualNetworkGatewayConnection using key vault for authentication. (#28760) * Add parameters for cert based auth connection * retrigger checks * retrigger checks * lintDiff * Trigger Build * revert PATCH changes * fix * change managed identity to v5 * add format and description * added networkidentifier under vnet->subet->serviceendpoint (#29292) * added networkidentifier under vnet->subet->serviceendpoint * resolving conflict (#29343) * Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357) * Fix * Fix2 --------- Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339) * Moving missed changes from 2023-11-01 packet capture swagger fix to latest api version * Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251) * Add CrossConnection name as an optional query parameter for List CrossConnection * update example * Addressing comments * Change to OData filtering * Fix the parameter reference * Update --------- Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> * initial changes (#29235) * adding supression for the breaking change in azure-sdk-for-go * adding correct package for this supression --------- Co-authored-by: GuptaVertika <149072034+GuptaVertika@users.noreply.github.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: Abhishek Shah <16267081+abhi7860@users.noreply.github.com> Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: daweiwang-microsoft <165709729+daweiwang-microsoft@users.noreply.github.com> Co-authored-by: Bhupesh Kumar Bhatt <52891188+bhupeshbhatt1985@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: jianzhao1992 <125631957+jianzhao1992@users.noreply.github.com> Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.