Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection #29251

Conversation

jianzhao1992
Copy link
Contributor

@jianzhao1992 jianzhao1992 commented May 28, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented May 28, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 28, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.9) new version base version
expressRouteCrossConnection.json 2024-01-01(705762b) 2023-11-01(main)
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-01 package-2024-01(705762b) package-2024-01(release-network-Microsoft.Network-2024-01-01)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L130
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L179
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L179
ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L298
ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L351
ResourceNameRestriction The resource name parameter 'peeringName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L351
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L352
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L391
PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L544
ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L544
ResourceNameRestriction The resource name parameter 'peeringName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L544
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L594
PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L615
ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L615
ResourceNameRestriction The resource name parameter 'peeringName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L615
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L665
PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L686
ResourceNameRestriction The resource name parameter 'crossConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L686
ResourceNameRestriction The resource name parameter 'peeringName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L686
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L736
MissingTypeObject The schema 'ExpressRouteCrossConnectionRoutesTableSummary' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L759
MissingTypeObject The schema 'ExpressRouteCrossConnectionsRoutesTableSummaryListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L781
MissingTypeObject The schema 'ExpressRouteCircuitReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L798
MissingTypeObject The schema 'ExpressRouteCrossConnectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L807
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L819
AllTrackedResourcesMustHaveDelete The resource ExpressRouteCrossConnection does not have a corresponding delete operation.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L862
MissingTypeObject The schema 'ExpressRouteCrossConnection' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L862
MissingTypeObject The schema 'ExpressRouteCrossConnectionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L882
MissingTypeObject The schema 'ExpressRouteCrossConnectionPeeringProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L899
MissingTypeObject The schema 'ExpressRouteCrossConnectionPeering' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/expressRouteCrossConnection.json#L974
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 28, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net failed [Detail]
  • Code Generator Failed in generating from 0301c0712b47b88b46130d9290973fedb57cbe9d. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • Microsoft.Azure.Management.Network [Preview SDK Changes]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild] /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild] /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    cmdout	[msbuild] /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️⚠️ azure-sdk-for-net-track2 warning [Detail]
  • ⚠️Warning in generating from 0301c0712b47b88b46130d9290973fedb57cbe9d. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • ️✔️Azure.ResourceManager.Network [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.InboundSecurityRule> Azure.ResourceManager.Network.NetworkVirtualApplianceResource.CreateOrUpdateInboundSecurityRule(Azure.WaitUntil, System.String, Azure.ResourceManager.Network.Models.InboundSecurityRule, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.InboundSecurityRule>> Azure.ResourceManager.Network.NetworkVirtualApplianceResource.CreateOrUpdateInboundSecurityRuleAsync(Azure.WaitUntil, System.String, Azure.ResourceManager.Network.Models.InboundSecurityRule, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.Pageable<Azure.ResourceManager.Network.ExpressRouteCrossConnectionResource> Azure.ResourceManager.Network.Mocking.MockableNetworkSubscriptionResource.GetExpressRouteCrossConnections(System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.AsyncPageable<Azure.ResourceManager.Network.ExpressRouteCrossConnectionResource> Azure.ResourceManager.Network.Mocking.MockableNetworkSubscriptionResource.GetExpressRouteCrossConnectionsAsync(System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.Models.InboundSecurityRule Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.InboundSecurityRule(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.ETag>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.InboundSecurityRules>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Network.Models.InboundSecurityRule' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Network/Debug/netstandard2.0/Azure.ResourceManager.Network.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0]
    Parse Suppression File Errors
    No suppression file added.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️🔄 azure-sdk-for-python inProgress [Detail]
️❌ azure-sdk-for-java failed [Detail]
  • Pipeline Framework Failed in generating from 0301c0712b47b88b46130d9290973fedb57cbe9d. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] [GENERATE][Error] Code generation failed.
    cmderr	[generate.py] Please first check if the failure happens only to Java automation, or for all SDK automations.
    cmderr	[generate.py] If it happens for all SDK automations, please double check your Swagger, and check whether there is errors in ModelValidation and LintDiff.
    cmderr	[generate.py] If it happens to Java alone, you can open an issue to https://github.com/Azure/autorest.java/issues. Please include the link of this Pull Request in the issue.
    ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated/pom.xml'
    error	GenerationError: The following packages are still pending.
    error		azure-resourcemanager-network-generated
  • azure-resourcemanager-network-generated
    error	FatalError: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated/pom.xml'. Please refer to the inner logs for details or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    error	ErrorStack: Error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated/pom.xml'.
    error	GenerationError: The following packages are still pending.
    error		azure-resourcemanager-network-generated
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 0301c0712b47b88b46130d9290973fedb57cbe9d. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/network/armnetwork [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `BastionHostSKUNamePremium` added to enum type `BastionHostSKUName`
    info	[Changelog] - New value `EndpointTypeAzureArcNetwork` added to enum type `EndpointType`
    info	[Changelog] - New enum type `ApplicationGatewaySKUFamily` with values `ApplicationGatewaySKUFamilyGeneration1`, `ApplicationGatewaySKUFamilyGeneration2`
    info	[Changelog] - New enum type `ConnectionAuthenticationType` with values `ConnectionAuthenticationTypeCertificate`, `ConnectionAuthenticationTypePSK`
    info	[Changelog] - New enum type `InboundSecurityRuleType` with values `InboundSecurityRuleTypeAutoExpire`, `InboundSecurityRuleTypePermanent`
    info	[Changelog] - New enum type `NicTypeInRequest` with values `NicTypeInRequestPrivateNic`, `NicTypeInRequestPublicNic`
    info	[Changelog] - New enum type `NicTypeInResponse` with values `NicTypeInResponseAdditionalNic`, `NicTypeInResponsePrivateNic`, `NicTypeInResponsePublicNic`
    info	[Changelog] - New enum type `ProbeNoHealthyBackendsBehavior` with values `ProbeNoHealthyBackendsBehaviorAllProbedDown`, `ProbeNoHealthyBackendsBehaviorAllProbedUp`
    info	[Changelog] - New enum type `SharingScope` with values `SharingScopeDelegatedServices`, `SharingScopeTenant`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDeploymentsClient() *FirewallPolicyDeploymentsClient`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDraftsClient() *FirewallPolicyDraftsClient`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyRuleCollectionGroupDraftsClient() *FirewallPolicyRuleCollectionGroupDraftsClient`
    info	[Changelog] - New function `NewFirewallPolicyDeploymentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDeploymentsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyDeploymentsClient.BeginDeploy(context.Context, string, string, *FirewallPolicyDeploymentsClientBeginDeployOptions) (*runtime.Poller[FirewallPolicyDeploymentsClientDeployResponse], error)`
    info	[Changelog] - New function `NewFirewallPolicyDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDraftsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.CreateOrUpdate(context.Context, string, string, FirewallPolicyDraft, *FirewallPolicyDraftsClientCreateOrUpdateOptions) (FirewallPolicyDraftsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.Delete(context.Context, string, string, *FirewallPolicyDraftsClientDeleteOptions) (FirewallPolicyDraftsClientDeleteResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.Get(context.Context, string, string, *FirewallPolicyDraftsClientGetOptions) (FirewallPolicyDraftsClientGetResponse, error)`
    info	[Changelog] - New function `NewFirewallPolicyRuleCollectionGroupDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyRuleCollectionGroupDraftsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.CreateOrUpdate(context.Context, string, string, string, FirewallPolicyRuleCollectionGroupDraft, *FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateOptions) (FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Delete(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientDeleteOptions) (FirewallPolicyRuleCollectionGroupDraftsClientDeleteResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Get(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientGetOptions) (FirewallPolicyRuleCollectionGroupDraftsClientGetResponse, error)`
    info	[Changelog] - New function `*InboundSecurityRuleClient.Get(context.Context, string, string, string, *InboundSecurityRuleClientGetOptions) (InboundSecurityRuleClientGetResponse, error)`
    info	[Changelog] - New function `*VirtualAppliancesClient.BeginRestart(context.Context, string, string, *VirtualAppliancesClientBeginRestartOptions) (*runtime.Poller[VirtualAppliancesClientRestartResponse], error)`
    info	[Changelog] - New struct `CertificateAuthentication`
    info	[Changelog] - New struct `ConnectionMonitorEndpointLocationDetails`
    info	[Changelog] - New struct `FirewallPolicyDraft`
    info	[Changelog] - New struct `FirewallPolicyDraftProperties`
    info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraft`
    info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraftProperties`
    info	[Changelog] - New struct `HeaderValueMatcher`
    info	[Changelog] - New struct `PacketCaptureSettings`
    info	[Changelog] - New struct `VirtualApplianceIPConfiguration`
    info	[Changelog] - New struct `VirtualApplianceIPConfigurationProperties`
    info	[Changelog] - New struct `VirtualApplianceInstanceIDs`
    info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfiguration`
    info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfigurationProperties`
    info	[Changelog] - New struct `VirtualAppliancePropertiesFormatNetworkProfile`
    info	[Changelog] - New field `HeaderValueMatcher` in struct `ApplicationGatewayHeaderConfiguration`
    info	[Changelog] - New field `Family` in struct `ApplicationGatewaySKU`
    info	[Changelog] - New field `EnableSessionRecording` in struct `BastionHostPropertiesFormat`
    info	[Changelog] - New field `LocationDetails`, `SubscriptionID` in struct `ConnectionMonitorEndpoint`
    info	[Changelog] - New field `EnableDirectPortRateLimit` in struct `ExpressRouteCircuitPropertiesFormat`
    info	[Changelog] - New field `Filter` in struct `ExpressRouteCrossConnectionsClientListOptions`
    info	[Changelog] - New field `Identity` in struct `FlowLog`
    info	[Changelog] - New field `Identity` in struct `FlowLogInformation`
    info	[Changelog] - New field `RuleType` in struct `InboundSecurityRuleProperties`
    info	[Changelog] - New field `AppliesOn`, `DestinationPortRanges`, `Name` in struct `InboundSecurityRules`
    info	[Changelog] - New field `PrivateIPAddressPrefixLength` in struct `InterfaceIPConfigurationPropertiesFormat`
    info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureParameters`
    info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureResultProperties`
    info	[Changelog] - New field `LocalPath` in struct `PacketCaptureStorageLocation`
    info	[Changelog] - New field `JsChallengeCookieExpirationInMins` in struct `PolicySettings`
    info	[Changelog] - New field `NoHealthyBackendsBehavior` in struct `ProbePropertiesFormat`
    info	[Changelog] - New field `NetworkIdentifier` in struct `ServiceEndpointPropertiesFormat`
    info	[Changelog] - New field `SharingScope` in struct `SubnetPropertiesFormat`
    info	[Changelog] - New field `DpdTimeoutSeconds` in struct `VPNSiteLinkConnectionProperties`
    info	[Changelog] - New field `NicType` in struct `VirtualApplianceNicProperties`
    info	[Changelog] - New field `NetworkProfile` in struct `VirtualAppliancePropertiesFormat`
    info	[Changelog] - New field `Identity` in struct `VirtualNetworkGateway`
    info	[Changelog] - New field `AuthenticationType`, `CertificateAuthentication` in struct `VirtualNetworkGatewayConnectionPropertiesFormat`
    info	[Changelog] - New field `EnableOnlyIPv6Peering`, `LocalAddressSpace`, `LocalSubnetNames`, `LocalVirtualNetworkAddressSpace`, `PeerCompleteVnets`, `RemoteSubnetNames` in struct `VirtualNetworkPeeringPropertiesFormat`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 91 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 0301c0712b47b88b46130d9290973fedb57cbe9d. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-network [Preview SDK Changes]
    • azure-arm-network-33.2.0.tgz
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation group FirewallPolicyDeployments
    info	[Changelog]   - Added operation group FirewallPolicyDrafts
    info	[Changelog]   - Added operation group FirewallPolicyRuleCollectionGroupDrafts
    info	[Changelog]   - Added operation InboundSecurityRuleOperations.get
    info	[Changelog]   - Added operation NetworkVirtualAppliances.beginRestart
    info	[Changelog]   - Added operation NetworkVirtualAppliances.beginRestartAndWait
    info	[Changelog]   - Added Interface CertificateAuthentication
    info	[Changelog]   - Added Interface ConnectionMonitorEndpointLocationDetails
    info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployHeaders
    info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraft
    info	[Changelog]   - Added Interface FirewallPolicyDraftsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraftsDeleteOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraftsGetOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraft
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsDeleteOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsGetOptionalParams
    info	[Changelog]   - Added Interface HeaderValueMatcher
    info	[Changelog]   - Added Interface InboundSecurityRuleGetOptionalParams
    info	[Changelog]   - Added Interface NetworkVirtualApplianceInstanceIds
    info	[Changelog]   - Added Interface NetworkVirtualAppliancePropertiesFormatNetworkProfile
    info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartHeaders
    info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartOptionalParams
    info	[Changelog]   - Added Interface PacketCaptureSettings
    info	[Changelog]   - Added Interface VirtualApplianceIPConfiguration
    info	[Changelog]   - Added Interface VirtualApplianceIPConfigurationProperties
    info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfiguration
    info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfigurationProperties
    info	[Changelog]   - Added Type Alias ApplicationGatewaySkuFamily
    info	[Changelog]   - Added Type Alias ConnectionAuthenticationType
    info	[Changelog]   - Added Type Alias FirewallPolicyDeploymentsDeployResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyDraftsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyDraftsGetResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsGetResponse
    info	[Changelog]   - Added Type Alias InboundSecurityRuleGetResponse
    info	[Changelog]   - Added Type Alias InboundSecurityRuleType
    info	[Changelog]   - Added Type Alias NetworkVirtualAppliancesRestartResponse
    info	[Changelog]   - Added Type Alias NicTypeInRequest
    info	[Changelog]   - Added Type Alias NicTypeInResponse
    info	[Changelog]   - Added Type Alias ProbeNoHealthyBackendsBehavior
    info	[Changelog]   - Added Type Alias SharingScope
    info	[Changelog]   - Interface ApplicationGatewayHeaderConfiguration has a new optional parameter headerValueMatcher
    info	[Changelog]   - Interface ApplicationGatewaySku has a new optional parameter family
    info	[Changelog]   - Interface BastionHost has a new optional parameter enableSessionRecording
    info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter locationDetails
    info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter subscriptionId
    info	[Changelog]   - Interface ExpressRouteCircuit has a new optional parameter enableDirectPortRateLimit
    info	[Changelog]   - Interface ExpressRouteCrossConnectionsListOptionalParams has a new optional parameter filter
    info	[Changelog]   - Interface FlowLog has a new optional parameter identity
    info	[Changelog]   - Interface FlowLogInformation has a new optional parameter identity
    info	[Changelog]   - Interface InboundSecurityRule has a new optional parameter ruleType
    info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter appliesOn
    info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter destinationPortRanges
    info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter name
    info	[Changelog]   - Interface NetworkInterfaceIPConfiguration has a new optional parameter privateIPAddressPrefixLength
    info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter networkProfile
    info	[Changelog]   - Interface PacketCapture has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCapture has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureStorageLocation has a new optional parameter localPath
    info	[Changelog]   - Interface PolicySettings has a new optional parameter jsChallengeCookieExpirationInMins
    info	[Changelog]   - Interface Probe has a new optional parameter noHealthyBackendsBehavior
    info	[Changelog]   - Interface ServiceEndpointPropertiesFormat has a new optional parameter networkIdentifier
    info	[Changelog]   - Interface Subnet has a new optional parameter sharingScope
    info	[Changelog]   - Interface VirtualApplianceNicProperties has a new optional parameter nicType
    info	[Changelog]   - Interface VirtualNetworkGateway has a new optional parameter identity
    info	[Changelog]   - Interface VirtualNetworkGatewayConnection has a new optional parameter authenticationType
    info	[Changelog]   - Interface VirtualNetworkGatewayConnection has a new optional parameter certificateAuthentication
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter enableOnlyIPv6Peering
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localAddressSpace
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localSubnetNames
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localVirtualNetworkAddressSpace
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter peerCompleteVnets
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter remoteSubnetNames
    info	[Changelog]   - Interface VpnSiteLinkConnection has a new optional parameter dpdTimeoutSeconds
    info	[Changelog]   - Added Enum KnownApplicationGatewaySkuFamily
    info	[Changelog]   - Added Enum KnownConnectionAuthenticationType
    info	[Changelog]   - Added Enum KnownInboundSecurityRuleType
    info	[Changelog]   - Added Enum KnownNicTypeInRequest
    info	[Changelog]   - Added Enum KnownNicTypeInResponse
    info	[Changelog]   - Added Enum KnownProbeNoHealthyBackendsBehavior
    info	[Changelog]   - Added Enum KnownSharingScope
    info	[Changelog]   - Enum KnownBastionHostSkuName has a new value Premium
    info	[Changelog]   - Enum KnownEndpointType has a new value AzureArcNetwork
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed in generating from 0301c0712b47b88b46130d9290973fedb57cbe9d. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    error	ConfigError: the 'breakingChangesLabel' configuration is missing or is incorrect from the 'swagger_to_sdk_config.json file. Please correct the value or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    error	ConfigError: the 'breakingChangesLabel' configuration is missing or is incorrect from the 'swagger_to_sdk_config.json file. Please correct the value or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 0301c0712b47b88b46130d9290973fedb57cbe9d. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    error	ConfigError: the 'breakingChangesLabel' configuration is missing or is incorrect from the 'swagger_to_sdk_config.json file. Please correct the value or report this issue through https://aka.ms/azsdk/support/specreview-channel.
  • ⚠️Az.network.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@rkmanda rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 8, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 8, 2024
@rkmanda rkmanda removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 10, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 10, 2024
@razvanbadea-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@razvanbadea-msft
Copy link
Contributor

check the CLA comments as the cla check is required

@jianzhao1992
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@ms-bogdan-rotaru
Copy link

Pending answer on the thread started by @rkmanda.

@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 12, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 12, 2024
@jianzhao1992
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 29251 in repo Azure/azure-rest-api-specs

@jianzhao1992
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 29251 in repo Azure/azure-rest-api-specs

@jianzhao1992 jianzhao1992 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 13, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 13, 2024
@jianzhao1992
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 14, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 14, 2024
@jianzhao1992
Copy link
Contributor Author

/pr RequestMerge

@mentat9
Copy link
Member

mentat9 commented Jun 18, 2024

@jianzhao1992 - You should be able to merge this PR yourself. ARM reviewers don't have control over your release branch: we only merge PRs to main and RPSaaSMaster.

@jianzhao1992 jianzhao1992 merged commit 3a6c7d9 into Azure:release-network-Microsoft.Network-2024-01-01 Jun 18, 2024
24 of 29 checks passed
jianzhao1992 added a commit that referenced this pull request Jun 18, 2024
…ssRoute CrossConnection (#29251)

* Add CrossConnection name as an optional query parameter for List CrossConnection

* update example

* Addressing comments

* Change to OData filtering

* Fix the parameter reference

* Update

---------

Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com>
rkmanda pushed a commit that referenced this pull request Jun 19, 2024
…29302)

* Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01

* Updates readme

* Updates API version in new specs and examples

* Add examples for Subnet peering and v6 Subnet peering. (#28827)

Add examples for Subnet peering and v6 Subnet peering.
---------

Co-authored-by: saurabh83 <saugu@microsoft.com>

* Init (#29127)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048)

Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com>

* Added NoHealthyBackendsBehavior (#28868)

Added the property "NoHealthyBackendsBehavior" to the Probe properties.

* VirtualNetworkGatewayConnection using key vault for authentication. (#28760)

* Add parameters for cert based auth connection

* retrigger checks

* retrigger checks

* lintDiff

* Trigger Build

* revert PATCH changes

* fix

* change managed identity to v5

* add format and description

* rresolving conflict

* resolving readme file

* Revert "VirtualNetworkGatewayConnection using key vault for authentication. (#28760)"

This reverts commit c37ec24.

* Lint diff error suppress

* Guptavertika/release network microsoft.network official 2024 01 01 (#29367)

* added networkidentifier under vnet->subet->serviceendpoint

* added format :armid and updated description

* corrected the type

* fixed response

* response type fixed example

---------

Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com>

* Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339) (#29375)

* Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357) (#29376)

* Fix

* Fix2

---------

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251)

* Add CrossConnection name as an optional query parameter for List CrossConnection

* update example

* Addressing comments

* Change to OData filtering

* Fix the parameter reference

* Update

---------

Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com>

* initial changes (#29235)

* Changed type of networkIdentifier from PublicIPAddress to SubResource (#29469)

* added networkidentifier under vnet->subet->serviceendpoint

* added format :armid and updated description

* corrected the type

* fixed response

* response type fixed example

* Changed type of networkIdentifier from ./publicIpAddress.json#/definitions/PublicIPAddress to ./network.json#/definitions/SubResource

---------

Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com>

---------

Co-authored-by: saurabh83 <splitt@gmail.com>
Co-authored-by: saurabh83 <saugu@microsoft.com>
Co-authored-by: Abhishek Shah <16267081+abhi7860@users.noreply.github.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: AFK1194 <arsheen.khatib@gmail.com>
Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com>
Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
Co-authored-by: daweiwang-microsoft <165709729+daweiwang-microsoft@users.noreply.github.com>
Co-authored-by: Bhupesh Kumar Bhatt <52891188+bhupeshbhatt1985@users.noreply.github.com>
Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com>
Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: jianzhao1992 <125631957+jianzhao1992@users.noreply.github.com>
Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
mentat9 pushed a commit that referenced this pull request Jun 21, 2024
#29473)

* Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01

* Updates readme

* Updates API version in new specs and examples

* Add examples for Subnet peering and v6 Subnet peering. (#28827)

Add examples for Subnet peering and v6 Subnet peering.
---------

Co-authored-by: saurabh83 <saugu@microsoft.com>

* Init (#29127)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048)

Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com>

* Added NoHealthyBackendsBehavior (#28868)

Added the property "NoHealthyBackendsBehavior" to the Probe properties.

* VirtualNetworkGatewayConnection using key vault for authentication. (#28760)

* Add parameters for cert based auth connection

* retrigger checks

* retrigger checks

* lintDiff

* Trigger Build

* revert PATCH changes

* fix

* change managed identity to v5

* add format and description

* added networkidentifier under vnet->subet->serviceendpoint (#29292)

* added networkidentifier under vnet->subet->serviceendpoint

* resolving conflict (#29343)

* Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357)

* Fix

* Fix2

---------

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339)

* Moving missed changes from 2023-11-01 packet capture swagger fix to latest api version

* Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251)

* Add CrossConnection name as an optional query parameter for List CrossConnection

* update example

* Addressing comments

* Change to OData filtering

* Fix the parameter reference

* Update

---------

Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com>

* initial changes (#29235)

* adding supression for the breaking change in azure-sdk-for-go

* adding correct package for this supression

---------

Co-authored-by: GuptaVertika <149072034+GuptaVertika@users.noreply.github.com>
Co-authored-by: saurabh83 <splitt@gmail.com>
Co-authored-by: saurabh83 <saugu@microsoft.com>
Co-authored-by: Abhishek Shah <16267081+abhi7860@users.noreply.github.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: AFK1194 <arsheen.khatib@gmail.com>
Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com>
Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
Co-authored-by: daweiwang-microsoft <165709729+daweiwang-microsoft@users.noreply.github.com>
Co-authored-by: Bhupesh Kumar Bhatt <52891188+bhupeshbhatt1985@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com>
Co-authored-by: jianzhao1992 <125631957+jianzhao1992@users.noreply.github.com>
Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review customer-reported Issues that are reported by GitHub users external to the Azure organization. resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants