Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GET operaton for Network Virtual Appliance Inbound Security Rule #29375

Merged
merged 1 commit into from
Jun 10, 2024

Adding GET operaton for Network Virtual Appliance Inbound Secuirty Ru…

58fb7c7
Select commit
Loading
Failed to load commit list.
Merged

Adding GET operaton for Network Virtual Appliance Inbound Security Rule #29375

Adding GET operaton for Network Virtual Appliance Inbound Secuirty Ru…
58fb7c7
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff succeeded Jun 10, 2024 in 16m 13s

Swagger LintDiff succeeded

LintDiff
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.2) new version base version
package-2024-01 package-2024-01(58fb7c7) package-2024-01(guptavertika/release-network-Microsoft.Network-official-2024-01-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ RequiredReadOnlySystemData The response of operation:'InboundSecurityRule_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L848
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'InboundSecurityRuleModel'. Consider using the plural form of 'InboundSecurityRule' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L849
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L853
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create Network Virtual Appliance Inbound Security Rules
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L894


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ ResourceNameRestriction The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L37
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L38
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L105
❌ ResourceNameRestriction The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L288
❌ ResourceNameRestriction The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L448
❌ ResourceNameRestriction The resource name parameter 'siteName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L448
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L449
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L488
❌ ResourceNameRestriction The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L641
❌ PathForTrackedResourceTypes The path must be under a subscription and resource group for tracked resource types.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L733
❌ ResourceNameRestriction The resource name parameter 'skuName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L733
❌ ResourceNameRestriction The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L776
❌ ResourceNameRestriction The resource name parameter 'ruleCollectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L776
❌ MissingTypeObject The schema 'NetworkVirtualAppliance' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L903
❌ MissingTypeObject The schema 'NetworkVirtualAppliancePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L927
❌ MissingTypeObject The schema 'VirtualApplianceSkuProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1063
❌ MissingTypeObject The schema 'VirtualApplianceNicProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1083
❌ MissingTypeObject The schema 'VirtualApplianceSite' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1221
❌ MissingTypeObject The schema 'VirtualApplianceSiteProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1250
❌ MissingTypeObject The schema 'Office365PolicyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1270
❌ MissingTypeObject The schema 'BreakOutCategoryPolicies' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1280
❌ AllTrackedResourcesMustHaveDelete The resource NetworkVirtualApplianceSku does not have a corresponding delete operation.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1300
❌ MissingTypeObject The schema 'NetworkVirtualApplianceSku' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1300
❌ TrackedResourcePatchOperation Tracked resource 'NetworkVirtualApplianceSku' must have patch operation that at least supports the update of tags.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1300
❌ TrackedResourcesMustHavePut The tracked resource NetworkVirtualApplianceSku does not have a corresponding put operation.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1300
❌ MissingTypeObject The schema 'NetworkVirtualApplianceSkuPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1321
❌ MissingTypeObject The schema 'NetworkVirtualApplianceSkuInstances' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1347
❌ MissingTypeObject The schema 'NetworkVirtualApplianceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1364
❌ MissingTypeObject The schema 'NetworkVirtualApplianceSiteListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1380
❌ MissingTypeObject The schema 'NetworkVirtualApplianceSkuListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1396
❌ MissingTypeObject The schema 'InboundSecurityRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1412
❌ NestedResourcesMustHaveListOperation The nested resource 'InboundSecurityRule' does not have list operation, please add it.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1412
❌ MissingTypeObject The schema 'InboundSecurityRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1441
❌ MissingTypeObject The schema 'InboundSecurityRules' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1471
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L46
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkVirtualAppliances_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L99
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L107
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkVirtualAppliances_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L154
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L165
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkVirtualAppliances_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L211
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L219
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L297
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L372
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L457
⚠️ RequiredReadOnlySystemData The response of operation:'VirtualApplianceSites_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L511
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L519
⚠️ RequiredReadOnlySystemData The response of operation:'VirtualApplianceSites_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L566
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L574
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L650
⚠️ RequiredReadOnlySystemData The response of operation:'VirtualApplianceSkus_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L734
View more details on openapi-pipeline-app