Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GET operaton for Network Virtual Appliance Inbound Security Rule #29375

Conversation

ashutmi
Copy link
Contributor

@ashutmi ashutmi commented Jun 10, 2024

Cherry Pick: c3086a2

@ashutmi ashutmi requested a review from GuptaVertika as a code owner June 10, 2024 17:37
Copy link

openapi-pipeline-app bot commented Jun 10, 2024

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

Copy link

openapi-pipeline-app bot commented Jun 10, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.9) new version base version
networkVirtualAppliance.json 2024-01-01(58fb7c7) 2023-11-01(main)
️⚠️LintDiff: 4 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-01 package-2024-01(58fb7c7) package-2024-01(guptavertika/release-network-Microsoft.Network-official-2024-01-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ RequiredReadOnlySystemData The response of operation:'InboundSecurityRule_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L848
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'InboundSecurityRuleModel'. Consider using the plural form of 'InboundSecurityRule' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L849
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L853
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create Network Virtual Appliance Inbound Security Rules
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L894


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L37
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L38
ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L105
ResourceNameRestriction The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L288
ResourceNameRestriction The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L448
ResourceNameRestriction The resource name parameter 'siteName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L448
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L449
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L488
ResourceNameRestriction The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L641
PathForTrackedResourceTypes The path must be under a subscription and resource group for tracked resource types.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L733
ResourceNameRestriction The resource name parameter 'skuName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L733
ResourceNameRestriction The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L776
ResourceNameRestriction The resource name parameter 'ruleCollectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L776
MissingTypeObject The schema 'NetworkVirtualAppliance' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L903
MissingTypeObject The schema 'NetworkVirtualAppliancePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L927
MissingTypeObject The schema 'VirtualApplianceSkuProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1063
MissingTypeObject The schema 'VirtualApplianceNicProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1083
MissingTypeObject The schema 'VirtualApplianceSite' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1221
MissingTypeObject The schema 'VirtualApplianceSiteProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1250
MissingTypeObject The schema 'Office365PolicyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1270
MissingTypeObject The schema 'BreakOutCategoryPolicies' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1280
AllTrackedResourcesMustHaveDelete The resource NetworkVirtualApplianceSku does not have a corresponding delete operation.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1300
MissingTypeObject The schema 'NetworkVirtualApplianceSku' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1300
TrackedResourcePatchOperation Tracked resource 'NetworkVirtualApplianceSku' must have patch operation that at least supports the update of tags.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1300
TrackedResourcesMustHavePut The tracked resource NetworkVirtualApplianceSku does not have a corresponding put operation.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1300
MissingTypeObject The schema 'NetworkVirtualApplianceSkuPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1321
MissingTypeObject The schema 'NetworkVirtualApplianceSkuInstances' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1347
MissingTypeObject The schema 'NetworkVirtualApplianceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1364
MissingTypeObject The schema 'NetworkVirtualApplianceSiteListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1380
MissingTypeObject The schema 'NetworkVirtualApplianceSkuListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/networkVirtualAppliance.json#L1396
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️⌛PR Summary pending [Detail]
️⌛Automated merging requirements met pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jun 10, 2024

Swagger Generation Artifacts

️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
Rule Message
RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=433895&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
"detail":"Run.ps1 failed with exit code 128 "
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jun 10, 2024

Generated ApiView

Language Package Name ApiView Link
Swagger Microsoft.Network https://apiview.dev/Assemblies/Review/9a91f46aa0a846acaae91aba821517fb?revisionId=86546ee2704749ca82b054ff70f88ef7

@GuptaVertika GuptaVertika merged commit 51433e1 into Azure:guptavertika/release-network-Microsoft.Network-official-2024-01-01 Jun 10, 2024
16 of 20 checks passed
rkmanda pushed a commit that referenced this pull request Jun 19, 2024
…29302)

* Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01

* Updates readme

* Updates API version in new specs and examples

* Add examples for Subnet peering and v6 Subnet peering. (#28827)

Add examples for Subnet peering and v6 Subnet peering.
---------

Co-authored-by: saurabh83 <saugu@microsoft.com>

* Init (#29127)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048)

Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com>

* Added NoHealthyBackendsBehavior (#28868)

Added the property "NoHealthyBackendsBehavior" to the Probe properties.

* VirtualNetworkGatewayConnection using key vault for authentication. (#28760)

* Add parameters for cert based auth connection

* retrigger checks

* retrigger checks

* lintDiff

* Trigger Build

* revert PATCH changes

* fix

* change managed identity to v5

* add format and description

* rresolving conflict

* resolving readme file

* Revert "VirtualNetworkGatewayConnection using key vault for authentication. (#28760)"

This reverts commit c37ec24.

* Lint diff error suppress

* Guptavertika/release network microsoft.network official 2024 01 01 (#29367)

* added networkidentifier under vnet->subet->serviceendpoint

* added format :armid and updated description

* corrected the type

* fixed response

* response type fixed example

---------

Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com>

* Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339) (#29375)

* Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357) (#29376)

* Fix

* Fix2

---------

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251)

* Add CrossConnection name as an optional query parameter for List CrossConnection

* update example

* Addressing comments

* Change to OData filtering

* Fix the parameter reference

* Update

---------

Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com>

* initial changes (#29235)

* Changed type of networkIdentifier from PublicIPAddress to SubResource (#29469)

* added networkidentifier under vnet->subet->serviceendpoint

* added format :armid and updated description

* corrected the type

* fixed response

* response type fixed example

* Changed type of networkIdentifier from ./publicIpAddress.json#/definitions/PublicIPAddress to ./network.json#/definitions/SubResource

---------

Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com>

---------

Co-authored-by: saurabh83 <splitt@gmail.com>
Co-authored-by: saurabh83 <saugu@microsoft.com>
Co-authored-by: Abhishek Shah <16267081+abhi7860@users.noreply.github.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: AFK1194 <arsheen.khatib@gmail.com>
Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com>
Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
Co-authored-by: daweiwang-microsoft <165709729+daweiwang-microsoft@users.noreply.github.com>
Co-authored-by: Bhupesh Kumar Bhatt <52891188+bhupeshbhatt1985@users.noreply.github.com>
Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com>
Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: jianzhao1992 <125631957+jianzhao1992@users.noreply.github.com>
Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants