-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose new SKUs for VMSS Virtual Network Gateway #3047
Conversation
Expose new SKUs for VMSS Virtual Network Gateway
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/network/resource-manager/readme.md
|
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/network/resource-manager/readme.md
|
Update new SKU names per COGS requirements
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/network/resource-manager/readme.md
|
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/network/resource-manager/readme.md
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ritwikbasu please make your changes in May branch (Network-2018-05-01), not directly in master.
Please make updates in 2018-05-01 folder, NOT in the April branch (2018-04-01).
Docs describing scenarios and review process by link: onenote:https://microsoft.sharepoint.com/teams/WAG/AzureNetworking/OneNotes/NRP%20migrated/Hydra%20+%20SDK.one#Swagger%20-%3e%20SDK%20-%3e%20PowerShell§ion-id={96F7B95B-A378-4CA5-903B-C88F894873EF}&page-id={71B816ED-DAE5-4907-94D8-DE7EE13278A0}&end
Will incorporate review comments and create PR against new branch, |
Expose new SKUs for VMSS Virtual Network Gateway
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger