Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose new SKUs for VMSS VPN and ER gateways #3069

Merged
merged 2 commits into from
May 15, 2018
Merged

Expose new SKUs for VMSS VPN and ER gateways #3069

merged 2 commits into from
May 15, 2018

Conversation

ritwikbasu
Copy link
Contributor

@ritwikbasu ritwikbasu commented May 14, 2018 •
edited
Loading

Expose new SKUs for VMSS VPN and ER gateways

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@ritwikbasu
Expose new SKUs for VMSS VPN and ER gateways
e838086 
Expose new SKUs for VMSS VPN and ER gateways
@ritwikbasu
Copy link
Contributor Author

Incorporated review comments from #3047

MikhailTryakhov
MikhailTryakhov approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️0 new Warnings.(95 total)
❌0 new Errors.(74 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️0 new Warnings.(110 total)
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@ravbhatnagar
Copy link
Contributor

ARM review not needed. Looks like modelAsString is set to true. Question for SDK team - can SDK handle new enum values added to same api-version? @dsgouda

@dsgouda
Copy link
Contributor

dsgouda commented May 14, 2018

@ravbhatnagar in the SDK world (at least for C#) API versions need not always match the actual sdk version. So yes, one could technically bring in changes to the same API version and regenerate code for it. However, if for the sdk itself it could mean breaking changes which means RPs need to bump their versions and re publish their packages.
Hope this clarifies.
@shahabhijeet for further context.

@ritwikbasu
Copy link
Contributor Author

@dsgouda, @shahabhijeet - Yes that is exactly what I planned to do. This is technically not a breaking change since we are not changing any API, nor removing any existing values. We are just adding new SKUs to the already existing ones that can be used by customers.

I plan to bump up the minor version of the Network SDK package to publish this change.

Please let me know if you see any issues with that.

@dsgouda
Copy link
Contributor

dsgouda commented May 15, 2018

@sergey-shandar please review and merge this PR at your convenience

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️0 new Warnings.(96 total)
❌0 new Errors.(74 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️0 new Warnings.(112 total)
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@sergey-shandar sergey-shandar merged commit c8aea94 into Azure:Network-2018-05-01 May 15, 2018
sergey-shandar
sergey-shandar reviewed May 15, 2018
View reviewed changes
Copy link
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ritwikbasu ritwikbasu mentioned this pull request May 15, 2018
Closed
9 tasks
dsgouda pushed a commit that referenced this pull request May 17, 2018
@MikhailTryakhov @dsgouda
Network-2018-05-01 to master (#3089)
b6ca4df 
* Added 2018-05-01 version. Common fixes (#3025)

* Created May folder. Updated version for exampls, commands

* Updated package to May version

* Returned NW examples

* Fixed API version; Fixed NetworkWatcher examples

* Fixed VPN Gateway/Connection examples

* Add changes from PR#2975
https://github.com/Azure/azure-rest-api-specs/pull/2975/files

* Adding optional traffic analytics config fields to network watcher config object for enhancing the Network Watcher cmdlets (#3023)

* Adding optional traffic analytics parameters with existing network watched flowlog configuration

* Updating the version

* Updating latest versoin in readme.md

* #AppGw Fundamentals Clean Up (#3046)

* Network 2018 05 01 (#3068)

* Adding optional traffic analytics parameters with existing network watched flowlog configuration

* Updating the version

* Updating latest versoin in readme.md

* Adding optional traffic analytics parameters with flowlog parameters

* Reverting old chnages

* Expose new SKUs for VMSS VPN and ER gateways (#3069)

Expose new SKUs for VMSS VPN and ER gateways

* Initial network error fixes and suppressions (#3051)

* Initial network error fixes and suppressions

* reworked exception to specified code blocks only

* Added express route fixes
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@chunyu3
Merge pull request #3069 from Azure/valakhin-dev-rpsaasmaster
dab6ae2 
Swagger Spec for Microsoft.Scom RP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-shandar sergey-shandar sergey-shandar left review comments

@MikhailTryakhov MikhailTryakhov MikhailTryakhov approved these changes

@DeepakRajendranMsft DeepakRajendranMsft Awaiting requested review from DeepakRajendranMsft

Assignees

@sergey-shandar sergey-shandar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ritwikbasu @azuresdkciprbot @ravbhatnagar @dsgouda @sergey-shandar @MikhailTryakhov