Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute GalleryRP 2024-03-03 version #31254

Merged
merged 23 commits into from
Nov 22, 2024
Merged

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Oct 28, 2024

ARM team, please review this PR. This version includes several features:
#30504 - new operations, suppression approved, ARM review/approved
#30505 - new property
#30536 - new property
#30558 - new property
#30658 - new property
#31310 - minor change to error in PR above
#30842 - new property
#30855 - new property
#30885 - new property
#31094 - new operation
#31430 - breaking change

Breaking change justification:
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2023-07-03/communityGallery.json#L298-L308
"CommunityGalleryDisclaimer" should be "type: object" instead of "string".

In SDKs, it is automatically flattened, and the payloads send out 'string' in the payload in place of "CommunityGalleryDisclaimer"
Example: https://github.com/Azure/azure-sdk-for-net/blob/f5a45365f5560f5c6b1a542f740bd2e8ccaae584/sdk/compute/Azure.ResourceManager.Compute/src/Generated/CommunityGalleryImageData.cs#L97

I've checked with feature owners and the backend also is just a string for disclaimer, instead of nested object.
This change is to reflect the backend correctly, and fix the error made in Swagger definition

The REST API payload already expects and receives "string" for disclaimer, so there is no change in any customer experien e

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Theodore Chang and others added 11 commits August 26, 2024 14:48
…0504)

* Remove async responses for HTTP 200 and 204 in delete examples

* Add spec for inVMAccessControlProfile

* Change put to get for list inVMAccess endpoints

* LintDiff - remove 202 for PUT LRO

* LintDiff - add provisioningState for GalleryInVMAccessControlProfile

* LintDiff - remove 200 for DELETE LRO

* LintDiff - add missing type:object for new definitions

* LintDiff - add regex pattern for resource names

* LintDiff - add regex pattern for resource names

* LintDiff - add regex pattern for resource names

* LintDiff - add Location and Azure-AsyncOperation headers for 202 LROs

* Add LintDiff suppressions for PATCH operations

* Add LintDiff suppressions for AvoidAdditionalProperties

* Update suppression reason for AvoidAdditionalProperties

* Add maxLength for inVMAccessControlProfile name

* Remove PATCH spec and PATCH suppressions

* Revert "Remove PATCH spec and PATCH suppressions"

This reverts commit 4b884a3.
…ture" feature (#30536)

* Update spec with startsAtVersion

* Add allowUpdateImage property
* Update spec with restore

* Add example for soft delete restore
…03 (#30855)

* adding additionalReplicaSet in swagger

* addressing lindiff errors

* addressing comments

* addressing comments

* updating enum

* running prettier

* adding separate examples

* adding file in readme.md

* adding at the end of properties

* addressing comments
* Initial commit

* Modify PUT/PATCH response

* Fixes

* Fixes
* Add List soft-deleted resources api and example

* fix bugs
Copy link

openapi-pipeline-app bot commented Oct 28, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

* Update spec with validationsProfile

* Add examples for GetGalleryImageVersion with ValidationProfile

* Run jq to format for prettier

* LintDiff - add type:object for new definitions

* Reorder validationsProfile to preserve param ordering

* Make validations profile readonly

* Update gallery.json

---------

Co-authored-by: Theodore Chang <thchan@microsoft.com>
@grizzlytheodore
Copy link
Member Author

    "resourceArmId": {

you can add the arm-id format

Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2024-03-03/gallery.json:3802 in 98b2dc9. [](commit_id = 98b2dc9, deletion_comment = False)

addressed: 7bcc1af

@grizzlytheodore
Copy link
Member Author

grizzlytheodore commented Nov 18, 2024

    "softDeletedArtifactType": {

can this have any string? or it can be used an enum here?

Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2024-03-03/gallery.json:3806 in 98b2dc9. [](commit_id = 98b2dc9, deletion_comment = False)

addressed. updated to enum : eebef06

@grizzlytheodore
Copy link
Member Author

what are the possible values for this property?

updated as enum: 1dd8817

@grizzlytheodore
Copy link
Member Author

      "description": "This property specifies the name of the platformAttributes. It could be either source_image_publisher or source_image_offer or source_image_sku or source_image_version"

from the description it can be converted to an enum

Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2024-03-03/gallery.json:4198 in 98b2dc9. [](commit_id = 98b2dc9, deletion_comment = False)

this is read-only. the description is updated: b3db98a

@grizzlytheodore
Copy link
Member Author

    "executedValidations": {

you should add a x-ms-identifiers also for arrays in this definition

Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2024-03-03/gallery.json:4114 in 5e7c233. [](commit_id = 5e7c233, deletion_comment = False)

addressed": 7bcc1af

@grizzlytheodore grizzlytheodore added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Nov 18, 2024
@ms-bogdan-rotaru
Copy link

    "resourceArmId": {

This is fixed, marking as resolved


In reply to: 2470781326


Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2024-03-03/gallery.json:3802 in 98b2dc9. [](commit_id = 98b2dc9, deletion_comment = False)

@ms-bogdan-rotaru
Copy link

    "softDeletedArtifactType": {

This still requires input


In reply to: 2470782889


Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2024-03-03/gallery.json:3806 in 98b2dc9. [](commit_id = 98b2dc9, deletion_comment = False)

@ms-bogdan-rotaru
Copy link

    "status": {

This is fixed, marking as resolved


In reply to: 2470787477


Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2024-03-03/gallery.json:4177 in 98b2dc9. [](commit_id = 98b2dc9, deletion_comment = False)

@ms-bogdan-rotaru
Copy link

@grizzlytheodore There still are some open comments, please address or close them where applicable.

@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 19, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 19, 2024
@grizzlytheodore
Copy link
Member Author

    "softDeletedArtifactType": {

This still requires input

In reply to: 2470782889

Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2024-03-03/gallery.json:3806 in 98b2dc9. [](commit_id = 98b2dc9, deletion_comment = False)

what change does this need? I updated to enum as shown here: #31254 (comment)

@grizzlytheodore grizzlytheodore added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Nov 19, 2024
@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 20, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 20, 2024
@grizzlytheodore grizzlytheodore enabled auto-merge (squash) November 21, 2024 16:02
@grizzlytheodore grizzlytheodore merged commit b09c9ec into main Nov 22, 2024
27 of 29 checks passed
@grizzlytheodore grizzlytheodore deleted the feature/cplat-2024-03-03 branch November 22, 2024 15:34
mikeharder pushed a commit to mikeharder/azure-rest-api-specs that referenced this pull request Nov 27, 2024
* copy last version folder as 2024-03-03

* change version reference in swagger json files and examples

* add new readme.md tag with new version

* [cplat-2024-03-03] Add inVMAccessControlProfile spec in GalleryRP (Azure#30504)

* Remove async responses for HTTP 200 and 204 in delete examples

* Add spec for inVMAccessControlProfile

* Change put to get for list inVMAccess endpoints

* LintDiff - remove 202 for PUT LRO

* LintDiff - add provisioningState for GalleryInVMAccessControlProfile

* LintDiff - remove 200 for DELETE LRO

* LintDiff - add missing type:object for new definitions

* LintDiff - add regex pattern for resource names

* LintDiff - add regex pattern for resource names

* LintDiff - add regex pattern for resource names

* LintDiff - add Location and Azure-AsyncOperation headers for 202 LROs

* Add LintDiff suppressions for PATCH operations

* Add LintDiff suppressions for AvoidAdditionalProperties

* Update suppression reason for AvoidAdditionalProperties

* Add maxLength for inVMAccessControlProfile name

* Remove PATCH spec and PATCH suppressions

* Revert "Remove PATCH spec and PATCH suppressions"

This reverts commit 4b884a3.

* Update spec with blockDeletionBeforeEndOfLife (Azure#30505)

* [cplat-2024-03-03] Update spec for "Update GalleryImageDefinition Feature" feature (Azure#30536)

* Update spec with startsAtVersion

* Add allowUpdateImage property

* [cplat-2024-03-03] Update spec for SoftDelete Restore feature (Azure#30558)

* Update spec with restore

* Add example for soft delete restore

* Update spec with scriptBehaviorAfterReboot (Azure#30842)

* Adding AdditionalReplicaSet parameter in swagger api version 2024-03-03 (Azure#30855)

* adding additionalReplicaSet in swagger

* addressing lindiff errors

* addressing comments

* addressing comments

* updating enum

* running prettier

* adding separate examples

* adding file in readme.md

* adding at the end of properties

* addressing comments

* Update spec with MSI support for Galleries (Azure#30885)

* Initial commit

* Modify PUT/PATCH response

* Fixes

* Fixes

* [cplat-2024-03-03] Add List soft-deleted resources api  (Azure#31094)

* Add List soft-deleted resources api and example

* fix bugs

* [cplat-2024-03-03] Update spec for ValidationProfile (Azure#30658)

* Update spec with validationsProfile

* Add examples for GetGalleryImageVersion with ValidationProfile

* Run jq to format for prettier

* LintDiff - add type:object for new definitions

* Reorder validationsProfile to preserve param ordering

* Make validations profile readonly

* Update gallery.json

---------

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* suppress lintDiff existing from last version

* Move validationsProfile to GalleryImageVersionProperties (Azure#31310)

* Move validationsProfile to GalleryImageVersionProperties

* Revert "Move validationsProfile to GalleryImageVersionProperties"

This reverts commit ae39672.

* Move validationsProfile to GalleryImageVersionProperties

* Remove validationsProfile

* Revert "Remove validationsProfile"

This reverts commit 36ca3e0.

* fix lintDiff failure

* update disclaimer (Azure#31430)

* ARM review comment addressing

* Make validation status an enum (Azure#31526)

* Make validation status an enum

* Run prettier

* Update description of platformAttributes (Azure#31525)

* Update description of platformAttributes

* Run prettier

* Add readOnly: true

* update softDeletedArtifactType to enum

* run prettier

---------

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: lkumaar <168636550+lkumaar@users.noreply.github.com>
Co-authored-by: kgulshan827 <56105750+kgulshan827@users.noreply.github.com>
Co-authored-by: mayankdaruka-msft <133302048+mayankdaruka-msft@users.noreply.github.com>
Co-authored-by: jackyChenAzure <131018173+jackyChenAzure@users.noreply.github.com>
danieljurek pushed a commit to danieljurek/azure-rest-api-specs that referenced this pull request Dec 9, 2024
* copy last version folder as 2024-03-03

* change version reference in swagger json files and examples

* add new readme.md tag with new version

* [cplat-2024-03-03] Add inVMAccessControlProfile spec in GalleryRP (Azure#30504)

* Remove async responses for HTTP 200 and 204 in delete examples

* Add spec for inVMAccessControlProfile

* Change put to get for list inVMAccess endpoints

* LintDiff - remove 202 for PUT LRO

* LintDiff - add provisioningState for GalleryInVMAccessControlProfile

* LintDiff - remove 200 for DELETE LRO

* LintDiff - add missing type:object for new definitions

* LintDiff - add regex pattern for resource names

* LintDiff - add regex pattern for resource names

* LintDiff - add regex pattern for resource names

* LintDiff - add Location and Azure-AsyncOperation headers for 202 LROs

* Add LintDiff suppressions for PATCH operations

* Add LintDiff suppressions for AvoidAdditionalProperties

* Update suppression reason for AvoidAdditionalProperties

* Add maxLength for inVMAccessControlProfile name

* Remove PATCH spec and PATCH suppressions

* Revert "Remove PATCH spec and PATCH suppressions"

This reverts commit 4b884a3.

* Update spec with blockDeletionBeforeEndOfLife (Azure#30505)

* [cplat-2024-03-03] Update spec for "Update GalleryImageDefinition Feature" feature (Azure#30536)

* Update spec with startsAtVersion

* Add allowUpdateImage property

* [cplat-2024-03-03] Update spec for SoftDelete Restore feature (Azure#30558)

* Update spec with restore

* Add example for soft delete restore

* Update spec with scriptBehaviorAfterReboot (Azure#30842)

* Adding AdditionalReplicaSet parameter in swagger api version 2024-03-03 (Azure#30855)

* adding additionalReplicaSet in swagger

* addressing lindiff errors

* addressing comments

* addressing comments

* updating enum

* running prettier

* adding separate examples

* adding file in readme.md

* adding at the end of properties

* addressing comments

* Update spec with MSI support for Galleries (Azure#30885)

* Initial commit

* Modify PUT/PATCH response

* Fixes

* Fixes

* [cplat-2024-03-03] Add List soft-deleted resources api  (Azure#31094)

* Add List soft-deleted resources api and example

* fix bugs

* [cplat-2024-03-03] Update spec for ValidationProfile (Azure#30658)

* Update spec with validationsProfile

* Add examples for GetGalleryImageVersion with ValidationProfile

* Run jq to format for prettier

* LintDiff - add type:object for new definitions

* Reorder validationsProfile to preserve param ordering

* Make validations profile readonly

* Update gallery.json

---------

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* suppress lintDiff existing from last version

* Move validationsProfile to GalleryImageVersionProperties (Azure#31310)

* Move validationsProfile to GalleryImageVersionProperties

* Revert "Move validationsProfile to GalleryImageVersionProperties"

This reverts commit ae39672.

* Move validationsProfile to GalleryImageVersionProperties

* Remove validationsProfile

* Revert "Remove validationsProfile"

This reverts commit 36ca3e0.

* fix lintDiff failure

* update disclaimer (Azure#31430)

* ARM review comment addressing

* Make validation status an enum (Azure#31526)

* Make validation status an enum

* Run prettier

* Update description of platformAttributes (Azure#31525)

* Update description of platformAttributes

* Run prettier

* Add readOnly: true

* update softDeletedArtifactType to enum

* run prettier

---------

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: lkumaar <168636550+lkumaar@users.noreply.github.com>
Co-authored-by: kgulshan827 <56105750+kgulshan827@users.noreply.github.com>
Co-authored-by: mayankdaruka-msft <133302048+mayankdaruka-msft@users.noreply.github.com>
Co-authored-by: jackyChenAzure <131018173+jackyChenAzure@users.noreply.github.com>
danieljurek pushed a commit to danieljurek/azure-rest-api-specs that referenced this pull request Dec 9, 2024
* copy last version folder as 2024-03-03

* change version reference in swagger json files and examples

* add new readme.md tag with new version

* [cplat-2024-03-03] Add inVMAccessControlProfile spec in GalleryRP (Azure#30504)

* Remove async responses for HTTP 200 and 204 in delete examples

* Add spec for inVMAccessControlProfile

* Change put to get for list inVMAccess endpoints

* LintDiff - remove 202 for PUT LRO

* LintDiff - add provisioningState for GalleryInVMAccessControlProfile

* LintDiff - remove 200 for DELETE LRO

* LintDiff - add missing type:object for new definitions

* LintDiff - add regex pattern for resource names

* LintDiff - add regex pattern for resource names

* LintDiff - add regex pattern for resource names

* LintDiff - add Location and Azure-AsyncOperation headers for 202 LROs

* Add LintDiff suppressions for PATCH operations

* Add LintDiff suppressions for AvoidAdditionalProperties

* Update suppression reason for AvoidAdditionalProperties

* Add maxLength for inVMAccessControlProfile name

* Remove PATCH spec and PATCH suppressions

* Revert "Remove PATCH spec and PATCH suppressions"

This reverts commit 4b884a3.

* Update spec with blockDeletionBeforeEndOfLife (Azure#30505)

* [cplat-2024-03-03] Update spec for "Update GalleryImageDefinition Feature" feature (Azure#30536)

* Update spec with startsAtVersion

* Add allowUpdateImage property

* [cplat-2024-03-03] Update spec for SoftDelete Restore feature (Azure#30558)

* Update spec with restore

* Add example for soft delete restore

* Update spec with scriptBehaviorAfterReboot (Azure#30842)

* Adding AdditionalReplicaSet parameter in swagger api version 2024-03-03 (Azure#30855)

* adding additionalReplicaSet in swagger

* addressing lindiff errors

* addressing comments

* addressing comments

* updating enum

* running prettier

* adding separate examples

* adding file in readme.md

* adding at the end of properties

* addressing comments

* Update spec with MSI support for Galleries (Azure#30885)

* Initial commit

* Modify PUT/PATCH response

* Fixes

* Fixes

* [cplat-2024-03-03] Add List soft-deleted resources api  (Azure#31094)

* Add List soft-deleted resources api and example

* fix bugs

* [cplat-2024-03-03] Update spec for ValidationProfile (Azure#30658)

* Update spec with validationsProfile

* Add examples for GetGalleryImageVersion with ValidationProfile

* Run jq to format for prettier

* LintDiff - add type:object for new definitions

* Reorder validationsProfile to preserve param ordering

* Make validations profile readonly

* Update gallery.json

---------

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* suppress lintDiff existing from last version

* Move validationsProfile to GalleryImageVersionProperties (Azure#31310)

* Move validationsProfile to GalleryImageVersionProperties

* Revert "Move validationsProfile to GalleryImageVersionProperties"

This reverts commit ae39672.

* Move validationsProfile to GalleryImageVersionProperties

* Remove validationsProfile

* Revert "Remove validationsProfile"

This reverts commit 36ca3e0.

* fix lintDiff failure

* update disclaimer (Azure#31430)

* ARM review comment addressing

* Make validation status an enum (Azure#31526)

* Make validation status an enum

* Run prettier

* Update description of platformAttributes (Azure#31525)

* Update description of platformAttributes

* Run prettier

* Add readOnly: true

* update softDeletedArtifactType to enum

* run prettier

---------

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: lkumaar <168636550+lkumaar@users.noreply.github.com>
Co-authored-by: kgulshan827 <56105750+kgulshan827@users.noreply.github.com>
Co-authored-by: mayankdaruka-msft <133302048+mayankdaruka-msft@users.noreply.github.com>
Co-authored-by: jackyChenAzure <131018173+jackyChenAzure@users.noreply.github.com>
digvijaymali94 pushed a commit to digvijaymali94/azure-rest-api-specs that referenced this pull request Dec 17, 2024
* copy last version folder as 2024-03-03

* change version reference in swagger json files and examples

* add new readme.md tag with new version

* [cplat-2024-03-03] Add inVMAccessControlProfile spec in GalleryRP (Azure#30504)

* Remove async responses for HTTP 200 and 204 in delete examples

* Add spec for inVMAccessControlProfile

* Change put to get for list inVMAccess endpoints

* LintDiff - remove 202 for PUT LRO

* LintDiff - add provisioningState for GalleryInVMAccessControlProfile

* LintDiff - remove 200 for DELETE LRO

* LintDiff - add missing type:object for new definitions

* LintDiff - add regex pattern for resource names

* LintDiff - add regex pattern for resource names

* LintDiff - add regex pattern for resource names

* LintDiff - add Location and Azure-AsyncOperation headers for 202 LROs

* Add LintDiff suppressions for PATCH operations

* Add LintDiff suppressions for AvoidAdditionalProperties

* Update suppression reason for AvoidAdditionalProperties

* Add maxLength for inVMAccessControlProfile name

* Remove PATCH spec and PATCH suppressions

* Revert "Remove PATCH spec and PATCH suppressions"

This reverts commit 4b884a3.

* Update spec with blockDeletionBeforeEndOfLife (Azure#30505)

* [cplat-2024-03-03] Update spec for "Update GalleryImageDefinition Feature" feature (Azure#30536)

* Update spec with startsAtVersion

* Add allowUpdateImage property

* [cplat-2024-03-03] Update spec for SoftDelete Restore feature (Azure#30558)

* Update spec with restore

* Add example for soft delete restore

* Update spec with scriptBehaviorAfterReboot (Azure#30842)

* Adding AdditionalReplicaSet parameter in swagger api version 2024-03-03 (Azure#30855)

* adding additionalReplicaSet in swagger

* addressing lindiff errors

* addressing comments

* addressing comments

* updating enum

* running prettier

* adding separate examples

* adding file in readme.md

* adding at the end of properties

* addressing comments

* Update spec with MSI support for Galleries (Azure#30885)

* Initial commit

* Modify PUT/PATCH response

* Fixes

* Fixes

* [cplat-2024-03-03] Add List soft-deleted resources api  (Azure#31094)

* Add List soft-deleted resources api and example

* fix bugs

* [cplat-2024-03-03] Update spec for ValidationProfile (Azure#30658)

* Update spec with validationsProfile

* Add examples for GetGalleryImageVersion with ValidationProfile

* Run jq to format for prettier

* LintDiff - add type:object for new definitions

* Reorder validationsProfile to preserve param ordering

* Make validations profile readonly

* Update gallery.json

---------

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* suppress lintDiff existing from last version

* Move validationsProfile to GalleryImageVersionProperties (Azure#31310)

* Move validationsProfile to GalleryImageVersionProperties

* Revert "Move validationsProfile to GalleryImageVersionProperties"

This reverts commit ae39672.

* Move validationsProfile to GalleryImageVersionProperties

* Remove validationsProfile

* Revert "Remove validationsProfile"

This reverts commit 36ca3e0.

* fix lintDiff failure

* update disclaimer (Azure#31430)

* ARM review comment addressing

* Make validation status an enum (Azure#31526)

* Make validation status an enum

* Run prettier

* Update description of platformAttributes (Azure#31525)

* Update description of platformAttributes

* Run prettier

* Add readOnly: true

* update softDeletedArtifactType to enum

* run prettier

---------

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: lkumaar <168636550+lkumaar@users.noreply.github.com>
Co-authored-by: kgulshan827 <56105750+kgulshan827@users.noreply.github.com>
Co-authored-by: mayankdaruka-msft <133302048+mayankdaruka-msft@users.noreply.github.com>
Co-authored-by: jackyChenAzure <131018173+jackyChenAzure@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Compute new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager SuppressionReviewRequired
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants