-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move validationsProfile to GalleryImageVersionProperties #31310
Merged
grizzlytheodore
merged 5 commits into
Azure:feature/cplat-2024-03-03
from
lkumaar:validationsprofile-model
Oct 29, 2024
Merged
Move validationsProfile to GalleryImageVersionProperties #31310
grizzlytheodore
merged 5 commits into
Azure:feature/cplat-2024-03-03
from
lkumaar:validationsprofile-model
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkumaar
requested review from
Sandido,
dkulkarni-ms,
haagha,
MS-syh2qs and
grizzlytheodore
as code owners
October 29, 2024 13:11
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
This reverts commit ae39672.
microsoft-github-policy-service
bot
added
API Management
Network
SQL
Storage
Storage Service (Queues, Blobs, Files)
Synapses
Cognitive Services
Analysis Services
Alerts Management
Insights
Monitor - Exporter
Monitor OpenTelemetry Exporter
Authorization
Automation
Batch
BatchAI
Billing
Network - CDN
Cognitive - Language
Container Instances
labels
Oct 29, 2024
microsoft-github-policy-service
bot
added
Search
Service Map
Service Bus
Service Fabric
Import Export
StorageSync
Storsimple
Stream Analytics
Subscription
Load Test Service
Azure Load Test Service
Maps
Purview
TimeseriesInsights
Network - Traffic Manager
Web Apps
Profile
Azure API profile issues.
ArcReview
labels
Oct 29, 2024
This reverts commit 36ca3e0.
grizzlytheodore
merged commit Oct 29, 2024
dc839a7
into
Azure:feature/cplat-2024-03-03
17 of 26 checks passed
8 tasks
grizzlytheodore
added a commit
that referenced
this pull request
Nov 22, 2024
* copy last version folder as 2024-03-03 * change version reference in swagger json files and examples * add new readme.md tag with new version * [cplat-2024-03-03] Add inVMAccessControlProfile spec in GalleryRP (#30504) * Remove async responses for HTTP 200 and 204 in delete examples * Add spec for inVMAccessControlProfile * Change put to get for list inVMAccess endpoints * LintDiff - remove 202 for PUT LRO * LintDiff - add provisioningState for GalleryInVMAccessControlProfile * LintDiff - remove 200 for DELETE LRO * LintDiff - add missing type:object for new definitions * LintDiff - add regex pattern for resource names * LintDiff - add regex pattern for resource names * LintDiff - add regex pattern for resource names * LintDiff - add Location and Azure-AsyncOperation headers for 202 LROs * Add LintDiff suppressions for PATCH operations * Add LintDiff suppressions for AvoidAdditionalProperties * Update suppression reason for AvoidAdditionalProperties * Add maxLength for inVMAccessControlProfile name * Remove PATCH spec and PATCH suppressions * Revert "Remove PATCH spec and PATCH suppressions" This reverts commit 4b884a3. * Update spec with blockDeletionBeforeEndOfLife (#30505) * [cplat-2024-03-03] Update spec for "Update GalleryImageDefinition Feature" feature (#30536) * Update spec with startsAtVersion * Add allowUpdateImage property * [cplat-2024-03-03] Update spec for SoftDelete Restore feature (#30558) * Update spec with restore * Add example for soft delete restore * Update spec with scriptBehaviorAfterReboot (#30842) * Adding AdditionalReplicaSet parameter in swagger api version 2024-03-03 (#30855) * adding additionalReplicaSet in swagger * addressing lindiff errors * addressing comments * addressing comments * updating enum * running prettier * adding separate examples * adding file in readme.md * adding at the end of properties * addressing comments * Update spec with MSI support for Galleries (#30885) * Initial commit * Modify PUT/PATCH response * Fixes * Fixes * [cplat-2024-03-03] Add List soft-deleted resources api (#31094) * Add List soft-deleted resources api and example * fix bugs * [cplat-2024-03-03] Update spec for ValidationProfile (#30658) * Update spec with validationsProfile * Add examples for GetGalleryImageVersion with ValidationProfile * Run jq to format for prettier * LintDiff - add type:object for new definitions * Reorder validationsProfile to preserve param ordering * Make validations profile readonly * Update gallery.json --------- Co-authored-by: Theodore Chang <thchan@microsoft.com> * suppress lintDiff existing from last version * Move validationsProfile to GalleryImageVersionProperties (#31310) * Move validationsProfile to GalleryImageVersionProperties * Revert "Move validationsProfile to GalleryImageVersionProperties" This reverts commit ae39672. * Move validationsProfile to GalleryImageVersionProperties * Remove validationsProfile * Revert "Remove validationsProfile" This reverts commit 36ca3e0. * fix lintDiff failure * update disclaimer (#31430) * ARM review comment addressing * Make validation status an enum (#31526) * Make validation status an enum * Run prettier * Update description of platformAttributes (#31525) * Update description of platformAttributes * Run prettier * Add readOnly: true * update softDeletedArtifactType to enum * run prettier --------- Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: lkumaar <168636550+lkumaar@users.noreply.github.com> Co-authored-by: kgulshan827 <56105750+kgulshan827@users.noreply.github.com> Co-authored-by: mayankdaruka-msft <133302048+mayankdaruka-msft@users.noreply.github.com> Co-authored-by: jackyChenAzure <131018173+jackyChenAzure@users.noreply.github.com>
mikeharder
pushed a commit
to mikeharder/azure-rest-api-specs
that referenced
this pull request
Nov 27, 2024
* copy last version folder as 2024-03-03 * change version reference in swagger json files and examples * add new readme.md tag with new version * [cplat-2024-03-03] Add inVMAccessControlProfile spec in GalleryRP (Azure#30504) * Remove async responses for HTTP 200 and 204 in delete examples * Add spec for inVMAccessControlProfile * Change put to get for list inVMAccess endpoints * LintDiff - remove 202 for PUT LRO * LintDiff - add provisioningState for GalleryInVMAccessControlProfile * LintDiff - remove 200 for DELETE LRO * LintDiff - add missing type:object for new definitions * LintDiff - add regex pattern for resource names * LintDiff - add regex pattern for resource names * LintDiff - add regex pattern for resource names * LintDiff - add Location and Azure-AsyncOperation headers for 202 LROs * Add LintDiff suppressions for PATCH operations * Add LintDiff suppressions for AvoidAdditionalProperties * Update suppression reason for AvoidAdditionalProperties * Add maxLength for inVMAccessControlProfile name * Remove PATCH spec and PATCH suppressions * Revert "Remove PATCH spec and PATCH suppressions" This reverts commit 4b884a3. * Update spec with blockDeletionBeforeEndOfLife (Azure#30505) * [cplat-2024-03-03] Update spec for "Update GalleryImageDefinition Feature" feature (Azure#30536) * Update spec with startsAtVersion * Add allowUpdateImage property * [cplat-2024-03-03] Update spec for SoftDelete Restore feature (Azure#30558) * Update spec with restore * Add example for soft delete restore * Update spec with scriptBehaviorAfterReboot (Azure#30842) * Adding AdditionalReplicaSet parameter in swagger api version 2024-03-03 (Azure#30855) * adding additionalReplicaSet in swagger * addressing lindiff errors * addressing comments * addressing comments * updating enum * running prettier * adding separate examples * adding file in readme.md * adding at the end of properties * addressing comments * Update spec with MSI support for Galleries (Azure#30885) * Initial commit * Modify PUT/PATCH response * Fixes * Fixes * [cplat-2024-03-03] Add List soft-deleted resources api (Azure#31094) * Add List soft-deleted resources api and example * fix bugs * [cplat-2024-03-03] Update spec for ValidationProfile (Azure#30658) * Update spec with validationsProfile * Add examples for GetGalleryImageVersion with ValidationProfile * Run jq to format for prettier * LintDiff - add type:object for new definitions * Reorder validationsProfile to preserve param ordering * Make validations profile readonly * Update gallery.json --------- Co-authored-by: Theodore Chang <thchan@microsoft.com> * suppress lintDiff existing from last version * Move validationsProfile to GalleryImageVersionProperties (Azure#31310) * Move validationsProfile to GalleryImageVersionProperties * Revert "Move validationsProfile to GalleryImageVersionProperties" This reverts commit ae39672. * Move validationsProfile to GalleryImageVersionProperties * Remove validationsProfile * Revert "Remove validationsProfile" This reverts commit 36ca3e0. * fix lintDiff failure * update disclaimer (Azure#31430) * ARM review comment addressing * Make validation status an enum (Azure#31526) * Make validation status an enum * Run prettier * Update description of platformAttributes (Azure#31525) * Update description of platformAttributes * Run prettier * Add readOnly: true * update softDeletedArtifactType to enum * run prettier --------- Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: lkumaar <168636550+lkumaar@users.noreply.github.com> Co-authored-by: kgulshan827 <56105750+kgulshan827@users.noreply.github.com> Co-authored-by: mayankdaruka-msft <133302048+mayankdaruka-msft@users.noreply.github.com> Co-authored-by: jackyChenAzure <131018173+jackyChenAzure@users.noreply.github.com>
danieljurek
pushed a commit
to danieljurek/azure-rest-api-specs
that referenced
this pull request
Dec 9, 2024
* copy last version folder as 2024-03-03 * change version reference in swagger json files and examples * add new readme.md tag with new version * [cplat-2024-03-03] Add inVMAccessControlProfile spec in GalleryRP (Azure#30504) * Remove async responses for HTTP 200 and 204 in delete examples * Add spec for inVMAccessControlProfile * Change put to get for list inVMAccess endpoints * LintDiff - remove 202 for PUT LRO * LintDiff - add provisioningState for GalleryInVMAccessControlProfile * LintDiff - remove 200 for DELETE LRO * LintDiff - add missing type:object for new definitions * LintDiff - add regex pattern for resource names * LintDiff - add regex pattern for resource names * LintDiff - add regex pattern for resource names * LintDiff - add Location and Azure-AsyncOperation headers for 202 LROs * Add LintDiff suppressions for PATCH operations * Add LintDiff suppressions for AvoidAdditionalProperties * Update suppression reason for AvoidAdditionalProperties * Add maxLength for inVMAccessControlProfile name * Remove PATCH spec and PATCH suppressions * Revert "Remove PATCH spec and PATCH suppressions" This reverts commit 4b884a3. * Update spec with blockDeletionBeforeEndOfLife (Azure#30505) * [cplat-2024-03-03] Update spec for "Update GalleryImageDefinition Feature" feature (Azure#30536) * Update spec with startsAtVersion * Add allowUpdateImage property * [cplat-2024-03-03] Update spec for SoftDelete Restore feature (Azure#30558) * Update spec with restore * Add example for soft delete restore * Update spec with scriptBehaviorAfterReboot (Azure#30842) * Adding AdditionalReplicaSet parameter in swagger api version 2024-03-03 (Azure#30855) * adding additionalReplicaSet in swagger * addressing lindiff errors * addressing comments * addressing comments * updating enum * running prettier * adding separate examples * adding file in readme.md * adding at the end of properties * addressing comments * Update spec with MSI support for Galleries (Azure#30885) * Initial commit * Modify PUT/PATCH response * Fixes * Fixes * [cplat-2024-03-03] Add List soft-deleted resources api (Azure#31094) * Add List soft-deleted resources api and example * fix bugs * [cplat-2024-03-03] Update spec for ValidationProfile (Azure#30658) * Update spec with validationsProfile * Add examples for GetGalleryImageVersion with ValidationProfile * Run jq to format for prettier * LintDiff - add type:object for new definitions * Reorder validationsProfile to preserve param ordering * Make validations profile readonly * Update gallery.json --------- Co-authored-by: Theodore Chang <thchan@microsoft.com> * suppress lintDiff existing from last version * Move validationsProfile to GalleryImageVersionProperties (Azure#31310) * Move validationsProfile to GalleryImageVersionProperties * Revert "Move validationsProfile to GalleryImageVersionProperties" This reverts commit ae39672. * Move validationsProfile to GalleryImageVersionProperties * Remove validationsProfile * Revert "Remove validationsProfile" This reverts commit 36ca3e0. * fix lintDiff failure * update disclaimer (Azure#31430) * ARM review comment addressing * Make validation status an enum (Azure#31526) * Make validation status an enum * Run prettier * Update description of platformAttributes (Azure#31525) * Update description of platformAttributes * Run prettier * Add readOnly: true * update softDeletedArtifactType to enum * run prettier --------- Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: lkumaar <168636550+lkumaar@users.noreply.github.com> Co-authored-by: kgulshan827 <56105750+kgulshan827@users.noreply.github.com> Co-authored-by: mayankdaruka-msft <133302048+mayankdaruka-msft@users.noreply.github.com> Co-authored-by: jackyChenAzure <131018173+jackyChenAzure@users.noreply.github.com>
danieljurek
pushed a commit
to danieljurek/azure-rest-api-specs
that referenced
this pull request
Dec 9, 2024
* copy last version folder as 2024-03-03 * change version reference in swagger json files and examples * add new readme.md tag with new version * [cplat-2024-03-03] Add inVMAccessControlProfile spec in GalleryRP (Azure#30504) * Remove async responses for HTTP 200 and 204 in delete examples * Add spec for inVMAccessControlProfile * Change put to get for list inVMAccess endpoints * LintDiff - remove 202 for PUT LRO * LintDiff - add provisioningState for GalleryInVMAccessControlProfile * LintDiff - remove 200 for DELETE LRO * LintDiff - add missing type:object for new definitions * LintDiff - add regex pattern for resource names * LintDiff - add regex pattern for resource names * LintDiff - add regex pattern for resource names * LintDiff - add Location and Azure-AsyncOperation headers for 202 LROs * Add LintDiff suppressions for PATCH operations * Add LintDiff suppressions for AvoidAdditionalProperties * Update suppression reason for AvoidAdditionalProperties * Add maxLength for inVMAccessControlProfile name * Remove PATCH spec and PATCH suppressions * Revert "Remove PATCH spec and PATCH suppressions" This reverts commit 4b884a3. * Update spec with blockDeletionBeforeEndOfLife (Azure#30505) * [cplat-2024-03-03] Update spec for "Update GalleryImageDefinition Feature" feature (Azure#30536) * Update spec with startsAtVersion * Add allowUpdateImage property * [cplat-2024-03-03] Update spec for SoftDelete Restore feature (Azure#30558) * Update spec with restore * Add example for soft delete restore * Update spec with scriptBehaviorAfterReboot (Azure#30842) * Adding AdditionalReplicaSet parameter in swagger api version 2024-03-03 (Azure#30855) * adding additionalReplicaSet in swagger * addressing lindiff errors * addressing comments * addressing comments * updating enum * running prettier * adding separate examples * adding file in readme.md * adding at the end of properties * addressing comments * Update spec with MSI support for Galleries (Azure#30885) * Initial commit * Modify PUT/PATCH response * Fixes * Fixes * [cplat-2024-03-03] Add List soft-deleted resources api (Azure#31094) * Add List soft-deleted resources api and example * fix bugs * [cplat-2024-03-03] Update spec for ValidationProfile (Azure#30658) * Update spec with validationsProfile * Add examples for GetGalleryImageVersion with ValidationProfile * Run jq to format for prettier * LintDiff - add type:object for new definitions * Reorder validationsProfile to preserve param ordering * Make validations profile readonly * Update gallery.json --------- Co-authored-by: Theodore Chang <thchan@microsoft.com> * suppress lintDiff existing from last version * Move validationsProfile to GalleryImageVersionProperties (Azure#31310) * Move validationsProfile to GalleryImageVersionProperties * Revert "Move validationsProfile to GalleryImageVersionProperties" This reverts commit ae39672. * Move validationsProfile to GalleryImageVersionProperties * Remove validationsProfile * Revert "Remove validationsProfile" This reverts commit 36ca3e0. * fix lintDiff failure * update disclaimer (Azure#31430) * ARM review comment addressing * Make validation status an enum (Azure#31526) * Make validation status an enum * Run prettier * Update description of platformAttributes (Azure#31525) * Update description of platformAttributes * Run prettier * Add readOnly: true * update softDeletedArtifactType to enum * run prettier --------- Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: lkumaar <168636550+lkumaar@users.noreply.github.com> Co-authored-by: kgulshan827 <56105750+kgulshan827@users.noreply.github.com> Co-authored-by: mayankdaruka-msft <133302048+mayankdaruka-msft@users.noreply.github.com> Co-authored-by: jackyChenAzure <131018173+jackyChenAzure@users.noreply.github.com>
digvijaymali94
pushed a commit
to digvijaymali94/azure-rest-api-specs
that referenced
this pull request
Dec 17, 2024
* copy last version folder as 2024-03-03 * change version reference in swagger json files and examples * add new readme.md tag with new version * [cplat-2024-03-03] Add inVMAccessControlProfile spec in GalleryRP (Azure#30504) * Remove async responses for HTTP 200 and 204 in delete examples * Add spec for inVMAccessControlProfile * Change put to get for list inVMAccess endpoints * LintDiff - remove 202 for PUT LRO * LintDiff - add provisioningState for GalleryInVMAccessControlProfile * LintDiff - remove 200 for DELETE LRO * LintDiff - add missing type:object for new definitions * LintDiff - add regex pattern for resource names * LintDiff - add regex pattern for resource names * LintDiff - add regex pattern for resource names * LintDiff - add Location and Azure-AsyncOperation headers for 202 LROs * Add LintDiff suppressions for PATCH operations * Add LintDiff suppressions for AvoidAdditionalProperties * Update suppression reason for AvoidAdditionalProperties * Add maxLength for inVMAccessControlProfile name * Remove PATCH spec and PATCH suppressions * Revert "Remove PATCH spec and PATCH suppressions" This reverts commit 4b884a3. * Update spec with blockDeletionBeforeEndOfLife (Azure#30505) * [cplat-2024-03-03] Update spec for "Update GalleryImageDefinition Feature" feature (Azure#30536) * Update spec with startsAtVersion * Add allowUpdateImage property * [cplat-2024-03-03] Update spec for SoftDelete Restore feature (Azure#30558) * Update spec with restore * Add example for soft delete restore * Update spec with scriptBehaviorAfterReboot (Azure#30842) * Adding AdditionalReplicaSet parameter in swagger api version 2024-03-03 (Azure#30855) * adding additionalReplicaSet in swagger * addressing lindiff errors * addressing comments * addressing comments * updating enum * running prettier * adding separate examples * adding file in readme.md * adding at the end of properties * addressing comments * Update spec with MSI support for Galleries (Azure#30885) * Initial commit * Modify PUT/PATCH response * Fixes * Fixes * [cplat-2024-03-03] Add List soft-deleted resources api (Azure#31094) * Add List soft-deleted resources api and example * fix bugs * [cplat-2024-03-03] Update spec for ValidationProfile (Azure#30658) * Update spec with validationsProfile * Add examples for GetGalleryImageVersion with ValidationProfile * Run jq to format for prettier * LintDiff - add type:object for new definitions * Reorder validationsProfile to preserve param ordering * Make validations profile readonly * Update gallery.json --------- Co-authored-by: Theodore Chang <thchan@microsoft.com> * suppress lintDiff existing from last version * Move validationsProfile to GalleryImageVersionProperties (Azure#31310) * Move validationsProfile to GalleryImageVersionProperties * Revert "Move validationsProfile to GalleryImageVersionProperties" This reverts commit ae39672. * Move validationsProfile to GalleryImageVersionProperties * Remove validationsProfile * Revert "Remove validationsProfile" This reverts commit 36ca3e0. * fix lintDiff failure * update disclaimer (Azure#31430) * ARM review comment addressing * Make validation status an enum (Azure#31526) * Make validation status an enum * Run prettier * Update description of platformAttributes (Azure#31525) * Update description of platformAttributes * Run prettier * Add readOnly: true * update softDeletedArtifactType to enum * run prettier --------- Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: lkumaar <168636550+lkumaar@users.noreply.github.com> Co-authored-by: kgulshan827 <56105750+kgulshan827@users.noreply.github.com> Co-authored-by: mayankdaruka-msft <133302048+mayankdaruka-msft@users.noreply.github.com> Co-authored-by: jackyChenAzure <131018173+jackyChenAzure@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Alerts Management
Analysis Services
API Management
ArcReview
Authorization
Automation
Batch
BatchAI
Billing
Cognitive - Language
Cognitive Services
Compute
Container Instances
Container Registry
Container Service
Cosmos
Customer Insights
Data Factory
Data Lake Analytics
Data Lake Store
Data Migration
Device Update
Device Update Service
Devtestlab
Event Grid
Event Hubs
HDInsight
Import Export
Insights
Intune
IoTHub
KeyVault
Load Test Service
Azure Load Test Service
Logic App
Machine Learning Compute
Machine Learning
Maps
Media Services
Mobile Engagement
Monitor - Exporter
Monitor OpenTelemetry Exporter
Monitor - Operational Insights
Monitor
Monitor, Monitor Ingestion, Monitor Query
MySQL
Network - CDN
Network - DNS
Network - Traffic Manager
Network
Notification Hub
Operations Management
Peering
Policy Insights
PostgreSQL
Profile
Azure API profile issues.
Purview
Recovery Services Backup
Recovery Services Site-Recovery
RecoveryServices
Redis Cache
Relay
resource-manager
Scheduler
Search
Service Bus
Service Fabric
Service Map
SQL
Storage
Storage Service (Queues, Blobs, Files)
StorageSync
Storsimple
Stream Analytics
Subscription
Synapses
TimeseriesInsights
Web Apps
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.