Add AzureFirewall swagger and examples #3276

joannakleong · 2018-06-20T16:27:17Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-06-20T16:42:58Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2610

AutorestCI · 2018-06-20T16:47:13Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2135

AutorestCI · 2018-06-20T16:52:23Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2944

AutorestCI · 2018-06-20T16:57:11Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1409

AutorestCI · 2018-06-20T17:22:43Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2117

sergey-shandar · 2018-06-20T17:27:49Z

@ravbhatnagar new spec AzureFirewall.

joannakleong · 2018-06-21T15:28:41Z

Hi @ravbhatnagar , @sergey-shandar , FYI we had gotten ARM approval when we prepared for private preview (https://github.com/Azure/azure-rest-api-specs-pr/pull/246)

MadhusudhanRavi · 2018-06-21T20:42:39Z

specification/network/resource-manager/Microsoft.Network/stable/2018-04-01/azureFirewall.json

+         "properties":{  
+			"privateIPAddress": {
+			  "type": "string",
+			  "description": "PrivateIPAddress of the network interface IP Configuration. This field is populated in the output."


This is actually the front end IP address of the Internal Loadbalancer. we can check with Yair on how to expose this and if we should say this is the IPAddress they need to set as nexthop in UDR.

Spoke with Yair, we will use the following description: The Firewall Internal Load Balancer IP to be used as the next hop in User Defined Routes

MadhusudhanRavi · 2018-06-21T21:26:24Z

specification/network/resource-manager/Microsoft.Network/stable/2018-04-01/azureFirewall.json

+               "format":"int32",
+               "maximum":65000,
+               "exclusiveMaximum":false,
+               "minimum":0,


We start priority from 101. 0 - 100 and > 6500 is reserved

In NRP looks like user can start from 100. Will update the minimum to reflect that. Thanks for catching

dsgouda · 2018-06-21T21:28:43Z

@MikhailTryakhov
Can you take a look at this PR. Is this orthogonal to the changes here
Will trust @sergey-shandar 's review if Mikhail is okay with this change

MikhailTryakhov

LGTM. It's a new feature, Samer approved to push it to master directly.
Please merge Network-2018-06-01 first and this one after

MadhusudhanRavi · 2018-06-21T21:41:05Z

specification/network/resource-manager/Microsoft.Network/stable/2018-04-01/azureFirewall.json

+               },
+               "description":"Collection of rules used by a network rule collection."
+            },
+            "provisioningState":{  


We only care about provisioning state on AzureFirewallProperties why do we have to mentioned provisioning state on these child resources? we don't have operations on them. Also the same is for Ipconfig as well.

I see that other resources have it and NRP returns this value. So you can ignore this comment.

sergey-shandar · 2018-06-21T22:22:12Z

@joannakleong follow @MikhailTryakhov advise and then let me know when it can be merged.

dsgouda · 2018-06-21T22:45:30Z

@sergey-shandar This is good to merge

joannakleong · 2018-06-21T23:02:21Z

Thanks everyone for the prompt review! @sergey-shandar Before merging, I'd like to resolve @MadhusudhanRavi comments on the description fields for a couple properties

joannakleong · 2018-06-22T20:42:34Z

@sergey-shandar Pushed a final commit. Can this swagger be merged next Tuesday?

dsgouda · 2018-06-25T17:15:52Z

@sergey-shandar This good to merge. The dependent PR here has been merged
Please consult with @lmazuel regarding the CI failures.

sergey-shandar · 2018-06-25T17:53:06Z

I spoke with @lmazuel, it's a timeout issue.

sergey-shandar · 2018-06-29T12:26:51Z

@joannakleong Could you send me a link to ARM approval? This link https://github.com/Azure/azure-rest-api-specs-pr/pull/246 has no AzureFirewall.

joannakleong · 2018-06-29T14:37:48Z

@sergey-shandar yes, this is because for private preview we named ourselves "Secure Gateway" and now we've finalized the name "Azure Firewall"

lmazuel · 2018-07-17T22:27:23Z

@AutorestCI rebuild azure-sdk-for-python

Add AzureFirewall swagger and examples

aa69440

joannakleong requested review from DeepakRajendranMsft and MikhailTryakhov as code owners June 20, 2018 16:27

joannakleong changed the title ~~Add AzureFirewall swagger and examples~~ [do not merge]Add AzureFirewall swagger and examples Jun 20, 2018

azuresdkci assigned sergey-shandar Jun 20, 2018

azuresdkci requested a review from sergey-shandar June 20, 2018 16:28

AutorestCI mentioned this pull request Jun 20, 2018

[AutoPR network/resource-manager] Add AzureFirewall swagger and examples Azure/azure-sdk-for-node#3035

Closed

AutorestCI mentioned this pull request Jun 20, 2018

[AutoPR network/resource-manager] Add AzureFirewall swagger and examples Azure/azure-sdk-for-java#2118

Closed

AutorestCI mentioned this pull request Jun 20, 2018

[AutoPR network/resource-manager] Add AzureFirewall swagger and examples Azure/azure-sdk-for-python#2788

Closed

AutorestCI mentioned this pull request Jun 20, 2018

[AutoPR network/resource-manager] Add AzureFirewall swagger and examples Azure/azure-sdk-for-ruby#1402

Merged

sergey-shandar added DoNotMerge <valid label in PR review process> use to hold merge after approval WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 20, 2018

AutorestCI mentioned this pull request Jun 20, 2018

[AutoPR network/resource-manager] Add AzureFirewall swagger and examples Azure/azure-sdk-for-go#2086

Merged

sergey-shandar requested a review from dsgouda June 20, 2018 18:41

MadhusudhanRavi reviewed Jun 21, 2018

View reviewed changes

sergey-shandar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2018

MikhailTryakhov approved these changes Jun 21, 2018

View reviewed changes

MadhusudhanRavi reviewed Jun 21, 2018

View reviewed changes

sergey-shandar approved these changes Jun 21, 2018

View reviewed changes

Fixing privateipaddress description and minimum value for Priority

1619916

sergey-shandar removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 25, 2018

lmazuel merged commit 32b0d87 into Azure:master Jun 25, 2018

MikhailTryakhov changed the title ~~[do not merge]Add AzureFirewall swagger and examples~~ Add AzureFirewall swagger and examples Jun 28, 2018

AutorestCI mentioned this pull request Jul 17, 2018

[AutoPR network/resource-manager] Add AzureFirewall swagger and examples Azure/azure-sdk-for-python#2943

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AzureFirewall swagger and examples #3276

Add AzureFirewall swagger and examples #3276

joannakleong commented Jun 20, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

sergey-shandar commented Jun 20, 2018

joannakleong commented Jun 21, 2018

MadhusudhanRavi Jun 21, 2018

joannakleong Jun 22, 2018

MadhusudhanRavi Jun 21, 2018

joannakleong Jun 22, 2018

dsgouda commented Jun 21, 2018 •

edited

Loading

MikhailTryakhov left a comment

MadhusudhanRavi Jun 21, 2018

MadhusudhanRavi Jun 21, 2018

sergey-shandar commented Jun 21, 2018

dsgouda commented Jun 21, 2018

joannakleong commented Jun 21, 2018

joannakleong commented Jun 22, 2018

dsgouda commented Jun 25, 2018

sergey-shandar commented Jun 25, 2018

sergey-shandar commented Jun 29, 2018

joannakleong commented Jun 29, 2018

lmazuel commented Jul 17, 2018

Add AzureFirewall swagger and examples #3276

Add AzureFirewall swagger and examples #3276

Conversation

joannakleong commented Jun 20, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Jun 20, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jun 20, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 20, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 20, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 20, 2018 • edited Loading

Automation for azure-sdk-for-go

sergey-shandar commented Jun 20, 2018

joannakleong commented Jun 21, 2018

MadhusudhanRavi Jun 21, 2018

Choose a reason for hiding this comment

joannakleong Jun 22, 2018

Choose a reason for hiding this comment

MadhusudhanRavi Jun 21, 2018

Choose a reason for hiding this comment

joannakleong Jun 22, 2018

Choose a reason for hiding this comment

dsgouda commented Jun 21, 2018 • edited Loading

MikhailTryakhov left a comment

Choose a reason for hiding this comment

MadhusudhanRavi Jun 21, 2018

Choose a reason for hiding this comment

MadhusudhanRavi Jun 21, 2018

Choose a reason for hiding this comment

sergey-shandar commented Jun 21, 2018

dsgouda commented Jun 21, 2018

joannakleong commented Jun 21, 2018

joannakleong commented Jun 22, 2018

dsgouda commented Jun 25, 2018

sergey-shandar commented Jun 25, 2018

sergey-shandar commented Jun 29, 2018

joannakleong commented Jun 29, 2018

lmazuel commented Jul 17, 2018

joannakleong commented Jun 20, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

dsgouda commented Jun 21, 2018 •

edited

Loading