Release of Azure Networking Network-2018-06-01 (api-version 2018-04-01) #3261

MikhailTryakhov · 2018-06-18T22:13:05Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

MikhailTryakhov · 2018-06-18T22:14:14Z

specification/network/resource-manager/Microsoft.Network/stable/2018-04-01/loadBalancer.json

          "enum": [
            "Http",
-            "Tcp",
-            "Https"


AutorestCI · 2018-06-18T22:37:49Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2376

AutorestCI · 2018-06-18T22:47:08Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2132

AutorestCI · 2018-06-18T23:55:48Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2610

AutorestCI · 2018-06-19T00:25:11Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 167, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 300, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --set-upstream origin restapi_auto_network/resource-manager
  stderr: 'To https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-go.git
 ! [rejected]        restapi_auto_network/resource-manager -> restapi_auto_network/resource-manager (fetch first)
error: failed to push some refs to 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-go.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.'

AutorestCI · 2018-06-19T00:33:08Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1409

* Init 2018-06-01 (copy from 2018-05-01) * Make VM reference in NIC readonly * Updated version in readme

* Added new VPN protocol * indents

* Add examples for Express Route Circuit APIs * Fix errors in expressRouteCircuit.json validations * Fix errors in validate examples for ExR Circuit

MikhailTryakhov · 2018-06-19T22:31:24Z

...ification/network/resource-manager/Microsoft.Network/stable/2018-04-01/networkInterface.json

@@ -669,6 +669,7 @@
    "NetworkInterfacePropertiesFormat": {
      "properties": {
        "virtualMachine": {
+          "readOnly": true,


What is this from?

dsgouda

Left a couple of comments.
@MikhailTryakhov why is there a 2018-06-01 directory in this PR?

dsgouda · 2018-06-20T19:48:45Z

...esource-manager/Microsoft.Network/stable/2018-04-01/examples/VmssVmNetworkInterfaceList.json

@@ -1,6 +1,6 @@
 {
  "parameters" : {
-    "api-version" : "2017-03-30",
+    "api-version": "2017-03-30",


Shouldn't all versions be 2018-04-01 now? Please update all the examples here accordingly

@dsgouda as I know we shouldn't update VMSS

Why is that? In that case, the examples shouldn't be a part of 2018-04-01 here

@dsgouda but they are the part already from previous months... The only change we made is identity change...
+@lmazuel could you please review what's the expected VMSS examples behavior here? As I remember you told me don't touch VMSS :)

@MikhailTryakhov @dsgouda The way VMSS in Network is designed, they have to copy the file as-is from one month to another. This implies copy the examples with it.
If we want to avoid that copy eventually, it requires a more deeper discussion on how we structure the Swagger for Network and the peculiar VMSS. I don't think that's the point of this PR, and shouldn't be addressed here.

@lmazuel so we should leave api version as is without api-version update? Agree ;)

@lmazuel agree but examples that do not match to the current version is a bit moot when being tested. Definitely needs a rethink.
@MikhailTryakhov please mark this as something we need to discuss in upcoming meetings.
Won't block on this

@dsgouda done. please approve/merge this PR?

dsgouda · 2018-06-20T19:50:03Z

...ication/network/resource-manager/Microsoft.Network/stable/2018-06-01/applicationGateway.json

+  "info": {
+    "title": "NetworkManagementClient",
+    "description": "The Microsoft Azure Network management API provides a RESTful set of web services that interact with Microsoft Azure Networks service to manage your network resources. The API has entities that capture the relationship between an end user and the Microsoft Azure Networks service.",
+    "version": "2018-06-01"


If changes are being ported from 06 to 04, there shouldn't be a 2018-06-01 directory in this PR

…18-04-01)

* Adding VirtualWan Swagger * Adding the CRUD Apis for VpnConnections * Updating VpnGateway examples * Fixing build errors * Addressing comments * Addressing comments and editing VpnConnection definition and corresponding examples * Addressing comments * Removing enableRateLimiting property * Addressing comments * Changing the version to 2018-04-01 version

dsgouda

Looks good other than a couple of comments.

dsgouda · 2018-06-20T23:43:00Z

specification/network/resource-manager/readme.md

@@ -731,6 +730,9 @@ output-folder: $(go-sdk-folder)/services/network/mgmt/2018-02-01/network
 ## Suppression
 ``` yaml
 directive:
+  - suppress: RequiredPropertiesMissingInResourceModel


Was this approved?

yes, that is the same exception for ID readonly we had 1-2 months ago

dsgouda · 2018-06-20T23:48:30Z

specification/network/resource-manager/Microsoft.Network/stable/2018-04-01/virtualWan.json

@@ -0,0 +1,2125 @@
+{


@MikhailTryakhov Was this spec reviewed?

@dsgouda #3204

dsgouda · 2018-06-21T00:04:00Z

@MikhailTryakhov Looks good, there is a model validation error here that needs a fix too
Apologize for the turnaround.

MikhailTryakhov · 2018-06-21T04:07:41Z

@dsgouda I'm working with @yushwang for a 2nd month to make it fixed, now have 1 error instead of 3 in VnetGW and all of them fixed in express routes.
I'm afraid we can't wait for this error fix and have to publish with it. Fix would be merged to master when we'll have it ready

dsgouda · 2018-06-21T16:29:36Z

@MikhailTryakhov normally this would be a blocker but given the time crunch I will let this pass. Please make a note at your end to fix this ASAP

dsgouda · 2018-06-21T18:22:12Z

@lmazuel would it be okay to merge this, looks like travis is failing on timeouts while generating the sdks

MikhailTryakhov · 2018-06-21T19:19:13Z

@dsgouda added exception for this error approved by Gaurav (please see thread "VirtualNetworkGateway spec CR. Fixed 2 of 3 ARM errors")
So we've finally resolved it!

@lmazuel could you please help with merge?

dsgouda · 2018-06-21T20:32:39Z

specification/network/resource-manager/readme.md

@@ -31,8 +31,6 @@ openapi-type: arm
 tag: package-2018-04
 ```

-### Tag: package-2018-05


@MikhailTryakhov Please undo this change

dsgouda · 2018-06-21T22:05:59Z

@lmazuel Please merge since I do not have the permissions.

dsgouda · 2018-06-21T22:43:17Z

@marstr ping

MikhailTryakhov added the Network label Jun 18, 2018

MikhailTryakhov requested a review from dsgouda June 18, 2018 22:13

MikhailTryakhov requested a review from DeepakRajendranMsft as a code owner June 18, 2018 22:13

azuresdkci assigned dsgouda Jun 18, 2018

MikhailTryakhov commented Jun 18, 2018

View reviewed changes

AutorestCI mentioned this pull request Jun 18, 2018

[AutoPR network/resource-manager] Release of Azure Networking Network-2018-06-01 (api-version 2018-04-01) Azure/azure-sdk-for-python#2776

Merged

AutorestCI mentioned this pull request Jun 18, 2018

[AutoPR network/resource-manager] Release of Azure Networking Network-2018-06-01 (api-version 2018-04-01) Azure/azure-sdk-for-node#3028

Merged

AutorestCI mentioned this pull request Jun 19, 2018

[AutoPR network/resource-manager] Release of Azure Networking Network-2018-06-01 (api-version 2018-04-01) Azure/azure-sdk-for-ruby#1393

Merged

EvgenyAgafonchikov and others added 5 commits June 19, 2018 10:36

Added Network 2018-06-01; VM ref fix (Azure#3118)

8fa3d9a

* Init 2018-06-01 (copy from 2018-05-01) * Make VM reference in NIC readonly * Updated version in readme

New VPN Client Protocol (Azure#3133)

d5508a8

* Added new VPN protocol * indents

Add examples for Express Route Circuit APIs (Azure#3182)

9cb0ed8

* Add examples for Express Route Circuit APIs * Fix errors in expressRouteCircuit.json validations * Fix errors in validate examples for ExR Circuit

appgwv2 changes (Azure#3192)

2dda3f2

AppGW FIPS mode (Azure#3202)

76f85ae

EvgenyAgafonchikov force-pushed the Port06To04 branch from e0576f6 to 6247d52 Compare June 19, 2018 07:36

MikhailTryakhov commented Jun 19, 2018

View reviewed changes

dsgouda suggested changes Jun 20, 2018

View reviewed changes

Release of Azure Networking Network-2018-06-01 branch (api-version 20…

0f31156

…18-04-01)

MikhailTryakhov force-pushed the Port06To04 branch 3 times, most recently from b2e6f23 to 0f31156 Compare June 20, 2018 22:46

dsgouda suggested changes Jun 20, 2018

View reviewed changes

Suppress ConnectionSharedKey model issue

442b4ab

dsgouda approved these changes Jun 21, 2018

View reviewed changes

dsgouda reviewed Jun 21, 2018

View reviewed changes

Reverted extra-changes in readme

d7cf330

dsgouda mentioned this pull request Jun 21, 2018

Add AzureFirewall swagger and examples #3276

Merged

10 tasks

lmazuel merged commit 64909dc into Azure:master Jun 21, 2018

EvgenyAgafonchikov deleted the Port06To04 branch May 15, 2019 07:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release of Azure Networking Network-2018-06-01 (api-version 2018-04-01) #3261

Release of Azure Networking Network-2018-06-01 (api-version 2018-04-01) #3261

MikhailTryakhov commented Jun 18, 2018 •

edited by azuresdkci

Loading

MikhailTryakhov Jun 18, 2018

AutorestCI commented Jun 18, 2018 •

edited

Loading

AutorestCI commented Jun 18, 2018 •

edited

Loading

AutorestCI commented Jun 18, 2018 •

edited

Loading

AutorestCI commented Jun 19, 2018 •

edited

Loading

AutorestCI commented Jun 19, 2018 •

edited

Loading

MikhailTryakhov Jun 19, 2018

dsgouda left a comment

dsgouda Jun 20, 2018

MikhailTryakhov Jun 20, 2018

dsgouda Jun 20, 2018

MikhailTryakhov Jun 20, 2018 •

edited

Loading

lmazuel Jun 20, 2018 •

edited

Loading

MikhailTryakhov Jun 20, 2018

dsgouda Jun 20, 2018

MikhailTryakhov Jun 20, 2018

dsgouda Jun 20, 2018

dsgouda left a comment

dsgouda Jun 20, 2018

MikhailTryakhov Jun 21, 2018

dsgouda Jun 20, 2018

MikhailTryakhov Jun 20, 2018

dsgouda commented Jun 21, 2018

MikhailTryakhov commented Jun 21, 2018

dsgouda commented Jun 21, 2018

dsgouda commented Jun 21, 2018

MikhailTryakhov commented Jun 21, 2018

dsgouda Jun 21, 2018

dsgouda commented Jun 21, 2018

dsgouda commented Jun 21, 2018

Release of Azure Networking Network-2018-06-01 (api-version 2018-04-01) #3261

Release of Azure Networking Network-2018-06-01 (api-version 2018-04-01) #3261

Conversation

MikhailTryakhov commented Jun 18, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

Choose a reason for hiding this comment

AutorestCI commented Jun 18, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 18, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 18, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jun 19, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jun 19, 2018 • edited Loading

Automation for azure-sdk-for-ruby

Choose a reason for hiding this comment

dsgouda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikhailTryakhov Jun 20, 2018 • edited Loading

Choose a reason for hiding this comment

lmazuel Jun 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsgouda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsgouda commented Jun 21, 2018

MikhailTryakhov commented Jun 21, 2018

dsgouda commented Jun 21, 2018

dsgouda commented Jun 21, 2018

MikhailTryakhov commented Jun 21, 2018

Choose a reason for hiding this comment

dsgouda commented Jun 21, 2018

dsgouda commented Jun 21, 2018

MikhailTryakhov commented Jun 18, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jun 18, 2018 •

edited

Loading

AutorestCI commented Jun 18, 2018 •

edited

Loading

AutorestCI commented Jun 18, 2018 •

edited

Loading

AutorestCI commented Jun 19, 2018 •

edited

Loading

AutorestCI commented Jun 19, 2018 •

edited

Loading

MikhailTryakhov Jun 20, 2018 •

edited

Loading

lmazuel Jun 20, 2018 •

edited

Loading