[Monitor] Add two missing "by subscription" operations for completeness and compliance #3285

gucalder · 2018-06-21T06:28:15Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…evel argument Azure#2565

… API (Azure#2655)

AutorestCI · 2018-06-21T06:29:43Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2761

AutorestCI · 2018-06-21T07:54:33Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2602

AutorestCI · 2018-06-21T08:31:28Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2139

AutorestCI · 2018-06-21T10:22:10Z

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmp3n67uird/rest/specification/monitor/resource-manager/readme.md', '--multiapi', '--ruby', '--ruby-sdks-folder=/tmp/tmp3n67uird/sdk', '--use=@microsoft.azure/autorest.ruby@3.0.20', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4280; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.ruby' (3.0.20->3.0.20)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.1.22->2.1.22)
Processing batch task - {"tag":"package-2015-04-01-only"} .
Processing batch task - {"tag":"package-2016-03-01-only"} .
Processing batch task - {"tag":"package-2016-09-01-only"} .

ERROR (Fatal/DuplicateParameterCollision): Duplicated global non-identical parameter definitions
    - file:///tmp/tmp3n67uird/rest/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/serviceDiagnosticsSettings_API.json:395:4 ($.parameters.ResourceUriParameter)
    - file:///tmp/tmp3n67uird/rest/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/metrics_API.json:269:4 ($.parameters.ResourceUriParameter)
Process() cancelled due to exception : Cancellation requested.
Failure during batch task - {"tag":"package-2016-09-01-only"} -- Cancellation requested..
  Cancellation requested.

AutorestCI · 2018-06-21T10:43:01Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2120

dsgouda · 2018-06-21T17:09:22Z

specification/monitor/resource-manager/microsoft.insights/stable/2015-04-01/autoscale_API.json

+            "schema": {
+              "$ref": "#/definitions/AutoscaleSettingResourceCollection"
+            },
+            "examples": {


How is this different than x-ms-examples I don't think this is a valid spec

Talked to @fearthecowboy
Though we technically allow the examples node in responses our validation tools don't pick it.
Please move these examples as references to the x-ms-examples section and move the examples themselves to json files in the examples directory

"Examples" nodes removed. The actual examples are already in the x-ms-examples referenced files.

… Adding documentation to reduce number of warnings in validation.

gucalder · 2018-06-22T17:03:48Z

Last commit addresses issue #3293

dsgouda · 2018-06-22T17:17:46Z

@gucalder Some of the added examples seem to fail validation. Please take look at the logs here and fix the issues

gucalder · 2018-06-22T23:50:18Z

@dsgouda To be honest, I do not understand the errors in metricAlert (I do not own this one)
The only thing that comes to my mind is:
Should I remove the second member of the odatatype enumeration for MetricAlertCriteria?
,
"Microsoft.Azure.Monitor.DefaultCriteria"

Because it is not defined and/or used anywhere else.

dsgouda · 2018-06-25T16:54:19Z

@gucalder I think the API owners should be fixing it. Will open an issue regarding this.

dsgouda

LGTM

dsgouda · 2018-06-25T16:57:58Z

@gucalder as a best practice please make changes in a branch other than master for opening the PRs. Keeps the commit history clean and would be easier for you too

gucalder added 13 commits February 7, 2018 10:35

[Monitor] Make all attributes of EventData class readonly (Azure#2254)

00a5689

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

b0ca590

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

8c3746f

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

799c13f

[Monitor] Fixing issue with metricnamespace specification as client l…

067e5a9

…evel argument Azure#2565

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

5c64ca3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

a227d3f

[Monitor] Fixing incorrect specification of top parameter for Metrics…

189d112

… API (Azure#2655)

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

e0ff7d6

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

5adef1e

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

4c653be

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

3b52ba4

Add two missing "by subscription" operations.

4afd2b6

azuresdkci assigned dsgouda Jun 21, 2018

azuresdkci requested a review from dsgouda June 21, 2018 06:29

AutorestCI mentioned this pull request Jun 21, 2018

[AutoPR monitor/resource-manager] Add two missing "by subscription" operations for completeness and compliance Azure/azure-sdk-for-python#2795

Merged

AutorestCI mentioned this pull request Jun 21, 2018

[AutoPR monitor/resource-manager] Add two missing "by subscription" operations for completeness and compliance Azure/azure-sdk-for-node#3043

Merged

AutorestCI mentioned this pull request Jun 21, 2018

[AutoPR monitor/resource-manager] Add two missing "by subscription" operations for completeness and compliance Azure/azure-sdk-for-java#2127

Merged

AutorestCI mentioned this pull request Jun 21, 2018

[AutoPR monitor/resource-manager] Add two missing "by subscription" operations for completeness and compliance Azure/azure-sdk-for-go#2097

Merged

dsgouda suggested changes Jun 21, 2018

View reviewed changes

gucalder added 2 commits June 21, 2018 16:11

Remove "examples" nodes as requested since they are not used anymore.…

840fcf1

… Adding documentation to reduce number of warnings in validation.

Add the serviceBusRuleId back into the DiagnosticSetting resource spec.

8e22a06

gucalder changed the title ~~Add two missing "by subscription" operations for completeness and compliance~~ [Monitor] Add two missing "by subscription" operations for completeness and compliance Jun 22, 2018

gucalder added 2 commits June 22, 2018 17:00

Fix some issues with the examples

cc4855d

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

3c3f34d

dsgouda approved these changes Jun 25, 2018

View reviewed changes

dsgouda mentioned this pull request Jun 25, 2018

Model validation errors for metricAlerts.json examples #3297

Open

dsgouda merged commit d077470 into Azure:master Jun 25, 2018

annatisch mentioned this pull request Jul 30, 2018

[Monitor] Add serviceBusRuleId to the DiagnosticSettings resource #3293

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Monitor] Add two missing "by subscription" operations for completeness and compliance #3285

[Monitor] Add two missing "by subscription" operations for completeness and compliance #3285

gucalder commented Jun 21, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jun 21, 2018 •

edited

Loading

AutorestCI commented Jun 21, 2018 •

edited

Loading

AutorestCI commented Jun 21, 2018 •

edited

Loading

AutorestCI commented Jun 21, 2018 •

edited

Loading

AutorestCI commented Jun 21, 2018 •

edited

Loading

dsgouda Jun 21, 2018

dsgouda Jun 21, 2018

gucalder Jun 21, 2018

gucalder commented Jun 22, 2018

dsgouda commented Jun 22, 2018

gucalder commented Jun 22, 2018

dsgouda commented Jun 25, 2018

dsgouda left a comment

dsgouda commented Jun 25, 2018

[Monitor] Add two missing "by subscription" operations for completeness and compliance #3285

[Monitor] Add two missing "by subscription" operations for completeness and compliance #3285

Conversation

gucalder commented Jun 21, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Jun 21, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 21, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jun 21, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 21, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 21, 2018 • edited Loading

Automation for azure-sdk-for-go

dsgouda Jun 21, 2018

Choose a reason for hiding this comment

dsgouda Jun 21, 2018

Choose a reason for hiding this comment

gucalder Jun 21, 2018

Choose a reason for hiding this comment

gucalder commented Jun 22, 2018

dsgouda commented Jun 22, 2018

gucalder commented Jun 22, 2018

dsgouda commented Jun 25, 2018

dsgouda left a comment

Choose a reason for hiding this comment

dsgouda commented Jun 25, 2018

gucalder commented Jun 21, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jun 21, 2018 •

edited

Loading

AutorestCI commented Jun 21, 2018 •

edited

Loading

AutorestCI commented Jun 21, 2018 •

edited

Loading

AutorestCI commented Jun 21, 2018 •

edited

Loading

AutorestCI commented Jun 21, 2018 •

edited

Loading