Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor] Add two missing "by subscription" operations for completeness and compliance #3285

Merged
merged 17 commits into from
Jun 25, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
00a5689
[Monitor] Make all attributes of EventData class readonly (#2254)
gucalder Feb 7, 2018
b0ca590
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Feb 9, 2018
8c3746f
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Feb 17, 2018
799c13f
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Feb 28, 2018
067e5a9
[Monitor] Fixing issue with metricnamespace specification as client l…
gucalder Mar 1, 2018
5c64ca3
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Mar 10, 2018
a227d3f
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Mar 14, 2018
189d112
[Monitor] Fixing incorrect specification of top parameter for Metrics…
gucalder Mar 14, 2018
e0ff7d6
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Mar 15, 2018
5adef1e
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jun 1, 2018
4c653be
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jun 7, 2018
3b52ba4
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jun 12, 2018
4afd2b6
Add two missing "by subscription" operations.
gucalder Jun 21, 2018
840fcf1
Remove "examples" nodes as requested since they are not used anymore.…
gucalder Jun 21, 2018
8e22a06
Add the serviceBusRuleId back into the DiagnosticSetting resource spec.
gucalder Jun 22, 2018
cc4855d
Fix some issues with the examples
gucalder Jun 23, 2018
3c3f34d
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
gucalder Jun 23, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -65,19 +65,6 @@
"description": "Successful request to get more information about diagnostic setting category",
"schema": {
"$ref": "#/definitions/DiagnosticSettingsCategoryResource"
},
"examples": {
"application/json":
{
"id":"/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6/providers/microsoft.insights/diagnosticSettingsCategories/WorkflowRuntime",
"type":"microsoft.insights/diagnosticSettingsCategories",
"name":"WorkflowRuntime",
"location":"eastus",
"tags":null,
"properties": {
"categoryType":"Logs"
}
}
}
}
},
Expand Down Expand Up @@ -114,32 +101,6 @@
"description": "Successful request to get more information about diagnostic setting category",
"schema": {
"$ref": "#/definitions/DiagnosticSettingsCategoryResourceCollection"
},
"examples": {
"application/json": {
"value": [
{
"id":"/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6/providers/microsoft.insights/diagnosticSettingsCategories/WorkflowRuntime",
"type":"microsoft.insights/diagnosticSettingsCategories",
"name":"WorkflowRuntime",
"location":"eastus",
"tags":null,
"properties": {
"categoryType":"Logs"
}
},
{
"id":"/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6/providers/microsoft.insights/diagnosticSettingsCategories/WorkflowMetric",
"type":"microsoft.insights/diagnosticSettingsCategories",
"name":"WorkflowMetric",
"location":"eastus",
"tags":null,
"properties": {
"categoryType":"Metrics"
}
}
]
}
}
}
},
Expand Down Expand Up @@ -197,7 +158,8 @@
"properties": {
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/DiagnosticSettingsCategory"
"$ref": "#/definitions/DiagnosticSettingsCategory",
"description": "The properties of a Diagnostic Settings Category."
}
},
"description": "The diagnostic settings category resource."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,40 +65,6 @@
"description": "Successful request to get more information about diagnostic setting",
"schema": {
"$ref": "#/definitions/DiagnosticSettingsResource"
},
"examples": {
"application/json": {
"id":"/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6/diagnosticSettings/mysetting",
"type":"microsoft.logic/workflows",
"name":"mysetting",
"location":"eastus",
"tags":null,
"properties": {
"storageAccountId":"/subscriptions/df602c9c-7aa0-407d-a6fb-eb20c8bd1192/resourceGroups/apptest/providers/Microsoft.Storage/storageAccounts/appteststorage1",
"eventHubAuthorizationRuleId":"/subscriptions/b67f7fec-69fc-4974-9099-a26bd6ffeda3/resourceGroups/andy1101/providers/Microsoft.EventHub/namespaces/andy1101/authorizationrules/RootManageSharedAccessKey",
"workspaceId":"",
"metrics": [
{
"category":"WorkflowMetrics",
"enabled":true,
"retentionPolicy": {
"enabled":false,
"days":0
}
}
],
"logs": [
{
"category":"WorkflowRuntime",
"enabled":true,
"retentionPolicy": {
"enabled":false,
"days":0
}
}
]
}
}
}
}
},
Expand Down Expand Up @@ -145,40 +111,6 @@
"description": "Successful request to create a diagnostic setting",
"schema": {
"$ref": "#/definitions/DiagnosticSettingsResource"
},
"examples": {
"application/json": {
"id":"/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6/diagnosticSettings/mysetting",
"type":"microsoft.logic/workflows",
"name":"mysetting",
"location":"eastus",
"tags":null,
"properties": {
"storageAccountId":"/subscriptions/df602c9c-7aa0-407d-a6fb-eb20c8bd1192/resourceGroups/apptest/providers/Microsoft.Storage/storageAccounts/appteststorage1",
"eventHubAuthorizationRuleId":"/subscriptions/b67f7fec-69fc-4974-9099-a26bd6ffeda3/resourceGroups/andy1101/providers/Microsoft.EventHub/namespaces/andy1101/authorizationrules/RootManageSharedAccessKey",
"workspaceId":"",
"metrics": [
{
"category":"WorkflowMetrics",
"enabled":true,
"retentionPolicy": {
"enabled":false,
"days":0
}
}
],
"logs": [
{
"category":"WorkflowRuntime",
"enabled":true,
"retentionPolicy": {
"enabled":false,
"days":0
}
}
]
}
}
}
}
},
Expand Down Expand Up @@ -252,44 +184,6 @@
"description": "Successful request to get more information about diagnostic setting",
"schema": {
"$ref": "#/definitions/DiagnosticSettingsResourceCollection"
},
"examples": {
"application/json": {
"value": [
{
"id":"/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6/diagnosticSettings/mysetting",
"type":"microsoft.logic/workflows",
"name":"mysetting",
"location":"eastus",
"tags":null,
"properties": {
"storageAccountId":"/subscriptions/df602c9c-7aa0-407d-a6fb-eb20c8bd1192/resourceGroups/apptest/providers/Microsoft.Storage/storageAccounts/appteststorage1",
"eventHubAuthorizationRuleId":"/subscriptions/b67f7fec-69fc-4974-9099-a26bd6ffeda3/resourceGroups/andy1101/providers/Microsoft.EventHub/namespaces/andy1101/authorizationrules/RootManageSharedAccessKey",
"workspaceId":"",
"metrics": [
{
"category":"WorkflowMetrics",
"enabled":true,
"retentionPolicy": {
"enabled":false,
"days":0
}
}
],
"logs": [
{
"category":"WorkflowRuntime",
"enabled":true,
"retentionPolicy": {
"enabled":false,
"days":0
}
}
]
}
}
]
}
}
}
},
Expand Down Expand Up @@ -386,6 +280,10 @@
"type": "string",
"description": "The resource ID of the storage account to which you would like to send Diagnostic Logs."
},
"serviceBusRuleId": {
"type": "string",
"description": "The service bus rule Id of the diagnostic setting. This is here to maintain backwards compatibility."
},
"eventHubAuthorizationRuleId": {
"type": "string",
"description": "The resource Id for the event hub authorization rule."
Expand Down Expand Up @@ -425,7 +323,8 @@
"properties": {
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/DiagnosticSettings"
"$ref": "#/definitions/DiagnosticSettings",
"description": "Properties of a Diagnostic Settings Resource."
}
},
"description": "The diagnostic setting resource."
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"parameters": {
"resourceUri": "/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"resourceUri": "subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"name": "mysetting",
"api-version": "2017-05-01-preview",
"parameters": {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"parameters" : {
"resourceUri" : "/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"resourceUri" : "subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"name": "mysetting",
"api-version" : "2017-05-01-preview"
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"parameters" : {
"resourceUri" : "/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"resourceUri" : "subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"name": "mysetting",
"api-version" : "2017-05-01-preview"
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"parameters" : {
"resourceUri" : "/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"resourceUri" : "subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"name": "WorkflowRuntime",
"api-version" : "2017-05-01-preview"
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"parameters" : {
"resourceUri" : "/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"resourceUri" : "subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"api-version" : "2017-05-01-preview"
},
"responses" : {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"parameters" : {
"resourceUri" : "/subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"resourceUri" : "subscriptions/1a66ce04-b633-4a0b-b2bc-a912ec8986a6/resourcegroups/viruela1/providers/microsoft.logic/workflows/viruela6",
"api-version" : "2017-05-01-preview"
},
"responses" : {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,48 +80,6 @@
"description": "Successful request to get the list of metric values.",
"schema": {
"$ref": "#/definitions/BaselineResponse"
},
"examples": {
"application/json": {
"id": "/subscriptions/b368ca2f-e298-46b7-b0ab-012281956afa/resourceGroups/vms/providers/Microsoft.Compute/virtualMachines/vm1/providers/Microsoft.Insights/baseline/PercentageCpu",
"type": "Microsoft.Insights/baseline",
"name": {
"value": "PercentageCpu"
},
"properties": {
"timespan": "2017-04-14T02:20:00Z/2017-04-14T04:20:00Z",
"aggregation": "Average",
"interval": "PT1H",
"timestamps": [
"2017-04-14T02:20:00Z",
"2017-04-14T03:20:00Z"
],
"baseline": [
{
"sensitivity": "Low",
"lowThresholds": [
30.0,
31.1
],
"highThresholds": [
90.3453,
91.3453
]
},
{
"sensitivity": "Medium",
"lowThresholds": [
50.0,
51.1
],
"highThresholds": [
70.3453,
71.3453
]
}
]
}
}
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,39 +71,6 @@
"description": "Successful request to get the list of metric values.",
"schema": {
"$ref": "#/definitions/CalculateBaselineResponse"
},
"examples": {
"application/json": {
"type": "Microsoft.Insights/calculatebaseline",
"timestamps": [
"2017-04-14T02:20:00Z",
"2017-04-14T03:20:00Z"
],
"baseline": [
{
"sensitivity": "Low",
"lowThresholds": [
30.0,
31.1
],
"highThresholds": [
90.3453,
91.3453
]
},
{
"sensitivity": "Medium",
"lowThresholds": [
50.0,
51.1
],
"highThresholds": [
70.3453,
71.3453
]
}
]
}
}
}
},
Expand Down
Loading