Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VA support for manged instance #3353

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Adding VA support for manged instance #3353

merged 1 commit into from
Aug 9, 2018

Conversation

yaakoviyun
Copy link
Member

@yaakoviyun yaakoviyun commented Jul 5, 2018

Adding Vulnerability Assessment APIs on managed instance

Those APIs are the same as the Vulnerability Assessment APIs on regular Azure db with the difference of using "/managedInstances/{managed instance name}/" instead of "/servers/{server name}/"

The Vulnerability Assessment APIs on regular Azure db are approved and can be found at:

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessmentBaselines.json

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessments.json

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/databaseVulnerabilityAssessmentScans.json

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 5, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2671

@AutorestCI
Copy link

AutorestCI commented Jul 5, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 5, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@yaakoviyun
Copy link
Member Author

@jaredmoo for reference

@AutorestCI
Copy link

AutorestCI commented Jul 5, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2435

@AutorestCI
Copy link

AutorestCI commented Jul 5, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3293

@yaakoviyun
Copy link
Member Author

@sarangan12 - can we get someone from ARM to review the API?

@sarangan12
Copy link
Member

@ravbhatnagar Can you please review this from ARM side and provide your signoff?

@sarangan12
Copy link
Member

@ravbhatnagar Did you get a chance to review this?

@yaakoviyun
Copy link
Member Author

@sarangan12 - can you help.
This PR is waiting for a long time...

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yaakoviyun
Copy link
Member Author

@sarangan12 - can you help?

@yaakoviyun
Copy link
Member Author

Ping...

@yaakoviyun yaakoviyun changed the title [DO NOT MERGE] Adding VA support for manged instance Adding VA support for manged instance Aug 7, 2018
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@yaakoviyun
Copy link
Member Author

@sarangan12 - can you merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants