Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK for Vulnerability Assessment on Managed Instance #4821

Merged
merged 6 commits into from
Oct 11, 2018
Merged

Add SDK for Vulnerability Assessment on Managed Instance #4821

merged 6 commits into from
Oct 11, 2018

Conversation

talhers
Copy link
Member

@talhers talhers commented Oct 2, 2018

Description

Adding Vulnerability Assessment SDK on managed instance
PR for swagger - Azure/azure-rest-api-specs#3353

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@talhers
Copy link
Member Author

talhers commented Oct 2, 2018

@yaakoviyun @yoavfr @jaredmoo for reference

@dsgouda
Copy link
Contributor

dsgouda commented Oct 2, 2018

@talhers Please link the related REST spec pr and resolve the conflicts

Rename ManagedDatabaseVulnerabilityAssessmentTestFixture to ManagedInstanceTestFixture
@talhers
Copy link
Member Author

talhers commented Oct 3, 2018

@talhers Please link the related REST spec pr and resolve the conflicts

REST spec pr - Azure/azure-rest-api-specs#3353

@dsgouda
Copy link
Contributor

dsgouda commented Oct 4, 2018

@azuresdkci Retest this please

@dsgouda
Copy link
Contributor

dsgouda commented Oct 4, 2018

@azuresdkci Test this please

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to CI builds

Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dsgouda
Copy link
Contributor

dsgouda commented Oct 10, 2018

@azuresdkci Retest this please

@dsgouda
Copy link
Contributor

dsgouda commented Oct 10, 2018

@talhers Please join the Azure org here in order to enable CI runs on this PR

@talhers
Copy link
Member Author

talhers commented Oct 11, 2018

@talhers Please join the Azure org here in order to enable CI runs on this PR

done

@dsgouda dsgouda merged commit 8c1ae26 into Azure:psSdkJson6 Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants