-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDK for Vulnerability Assessment on Managed Instance #4821
Conversation
Can one of the admins verify this patch? |
@yaakoviyun @yoavfr @jaredmoo for reference |
@talhers Please link the related REST spec pr and resolve the conflicts |
src/SDKs/SqlManagement/Sql.Tests/ManagedDatabaseVulnerabilityAssessmentTestFixture.cs
Outdated
Show resolved
Hide resolved
src/SDKs/SqlManagement/Sql.Tests/ManagedDatabaseVulnerabilityAssessmentTestFixture.cs
Outdated
Show resolved
Hide resolved
Rename ManagedDatabaseVulnerabilityAssessmentTestFixture to ManagedInstanceTestFixture
REST spec pr - Azure/azure-rest-api-specs#3353 |
src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj
Outdated
Show resolved
Hide resolved
@azuresdkci Retest this please |
@azuresdkci Test this please |
src/SDKs/SqlManagement/Management.Sql/Generated/SdkInfo_SqlManagementClient.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM subject to CI builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@azuresdkci Retest this please |
Description
Adding Vulnerability Assessment SDK on managed instance
PR for swagger - Azure/azure-rest-api-specs#3353
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.