Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SourceControlSyncJobs and SourceControlSyncJobStreams properties and examples. #3624

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Updating SourceControlSyncJobs and SourceControlSyncJobStreams properties and examples. #3624

merged 1 commit into from
Aug 10, 2018

Conversation

Francisco-Gamino
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino commented Aug 10, 2018

  • Adding property syncType, and removing property startType from SourceControlSyncJobs.
  • Renaming property syncJobStreamId to sourceControlSyncJobStreamId in SourceControlSyncJobStreams.
  • Updating example to reflect these changes.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

…ControlSyncJobs. Renaming property syncJobStreamId to sourceControlSyncJobStreamId and updating example to reflect the changes.
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 10, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Aug 10, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3125

@AutorestCI
Copy link

AutorestCI commented Aug 10, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@Francisco-Gamino
Copy link
Contributor Author

@vrdmr @charub for FYI.

@AutorestCI
Copy link

AutorestCI commented Aug 10, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2443

@AutorestCI
Copy link

AutorestCI commented Aug 10, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3290

@Francisco-Gamino
Copy link
Contributor Author

Francisco-Gamino commented Aug 10, 2018

@vrdmr : As per @azuresdkci request, could you please verify/approve this change?

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, but you are in -preview, so it LGTM.

@Francisco-Gamino
Copy link
Contributor Author

Thank you @vrdmr!

@Francisco-Gamino
Copy link
Contributor Author

@azuresdkci : could you please take another look? Thanks!

@anuchandy
Copy link
Member

Merging this, api-version is in preview hence fine to make breaking changes.

@anuchandy anuchandy merged commit 6c9a078 into Azure:master Aug 10, 2018
@Francisco-Gamino
Copy link
Contributor Author

Thank you @azuresdkci for your quick review and followup! Have a great weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants