-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating SourceControlSyncJobs and SourceControlSyncJobStreams properties and examples. #3624
Conversation
…ControlSyncJobs. Renaming property syncJobStreamId to sourceControlSyncJobStreamId and updating example to reflect the changes.
Can one of the admins verify this patch? |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
@vrdmr : As per @azuresdkci request, could you please verify/approve this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, but you are in -preview
, so it LGTM.
Thank you @vrdmr! |
@azuresdkci : could you please take another look? Thanks! |
Merging this, api-version is in preview hence fine to make breaking changes. |
Thank you @azuresdkci for your quick review and followup! Have a great weekend! |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger