New SDK update for Automation. #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @vrdmr for FYI. |
|
Hi @dsgouda : Could you please take a look when you have a moment? Thanks! |
dsgouda
suggested changes
Aug 15, 2018
| /// </summary> | ||
| public static class StartType |
There was a problem hiding this comment.
This is a breaking change for SDK users, please update the version number to 3.4.0-preview
There was a problem hiding this comment.
Please update the aseembly file version here
| @@ -467,7 +467,7 @@ public void CanCreateSourceControlSyncJob() | |||
| Assert.Equal(retrievedSyncJob.ProvisioningState, syncJob.ProvisioningState); | |||
| Assert.Equal(retrievedSyncJob.StartTime, syncJob.StartTime); | |||
| Assert.Equal(retrievedSyncJob.EndTime, syncJob.EndTime); | |||
| Assert.Equal(retrievedSyncJob.StartType, syncJob.StartType); | |||
| //Assert.Equal(retrievedSyncJob.SyncType, syncJob.SyncType); | |||
|
|
|||
There was a problem hiding this comment.
The web service changes have not reached the region that is used to record the tests. If you prefer, I can skip the test and rerecord it for the next SDK update. Let me know. Thanks.
There was a problem hiding this comment.
We certainly recommend that over commented code 😄
|
@dsgouda : Could you please take another look? Thanks! |
|
Awesome, thanks @dsgouda ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contains changes introduced in the following spec:
Azure/azure-rest-api-specs#3624
Other changes:
Increased the version of the SDK - 3.4.0-preview.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.