Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some string Microsoft.Logic modeled enums back into enums #3775

Merged
merged 2 commits into from
Sep 10, 2018
Merged

Change some string Microsoft.Logic modeled enums back into enums #3775

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b946c4
Change some string modelled enums back into enums
refortie Aug 30, 2018
c016726
Change EDIFACT back to be an enum, not a string
refortie Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 6 additions & 37 deletions specification/logic/resource-manager/Microsoft.Logic/preview/2018-07-01-preview/logic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4803,12 +4803,6 @@
},
"204": {
"description": "No Content"
},
"default": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the default error response removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only integration account artifact that has the default response. This appears to make the SDK return a 404 response instead of a CloudException, which is what all the other artifacts return.

"description": "Logic error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
}
}
Expand Down Expand Up @@ -5911,7 +5905,7 @@
],
"x-ms-enum": {
"name": "DaysOfWeek",
"modelAsString": true
"modelAsString": false
}
},
"description": "The days of the week."
Expand Down Expand Up @@ -6125,7 +6119,7 @@
],
"x-ms-enum": {
"name": "DayOfWeek",
"modelAsString": true
"modelAsString": false
}
},
"GenerateUpgradedDefinitionParameters": {
Expand Down Expand Up @@ -6709,7 +6703,7 @@
"NotSpecified",
"AS2",
"X12",
"Edifact"
"EDIFACT"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont this be a breaking change? If so, it will impact the SDK users. Are you really ok with this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still in the process of getting a new (major breaking) version of the SDK out. This was caused by the deserialization of a response from our API in the SDK coming back as all caps. I'll just put this back to being not modeled as a string. This enum is unlikely to be added to

],
"x-ms-enum": {
"name": "AgreementType",
Expand Down Expand Up @@ -7822,7 +7816,7 @@
],
"x-ms-enum": {
"name": "SegmentTerminatorSuffix",
"modelAsString": true
"modelAsString": false
}
},
"X12DateFormat": {
Expand Down Expand Up @@ -8741,7 +8735,7 @@
],
"x-ms-enum": {
"name": "EdifactDecimalIndicator",
"modelAsString": true
"modelAsString": false
}
},
"IntegrationAccountCertificateListResult": {
Expand Down Expand Up @@ -9139,7 +9133,7 @@
],
"x-ms-enum": {
"name": "EventLevel",
"modelAsString": true
"modelAsString": false
},
"description": "The event level."
},
Expand Down Expand Up @@ -9181,31 +9175,6 @@
}
}
},
"AccessKeyRegenerateActionDefinition": {
"type": "object",
"additionalProperties": false,
"required": [
"keyType"
],
"properties": {
"keyType": {
"$ref": "#/definitions/AccessKeyType"
}
}
},
"AccessKeyType": {
"type": "string",
"enum": [
"NotSpecified",
"Primary",
"Secondary"
],
"x-ms-enum": {
"name": "AccessKeyType",
"modelAsString": true
},
"description": "The access key type."
},
"SetTriggerStateActionDefinition": {
"type": "object",
"additionalProperties": false,
Expand Down