Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some string Microsoft.Logic modeled enums back into enums #3775

Merged
merged 2 commits into from
Sep 10, 2018
Merged

Change some string Microsoft.Logic modeled enums back into enums #3775

merged 2 commits into from
Sep 10, 2018

Conversation

refortie
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Aug 30, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2782

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1596

@AutorestCI AutorestCI mentioned this pull request Aug 30, 2018
Merged
@refortie refortie changed the title Change some string modelled enums back into enums Change some string Microsoft.Logic modeled enums back into enums Aug 30, 2018
@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2650

This was referenced Aug 30, 2018
Merged
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 31, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3556

@AutorestCI AutorestCI mentioned this pull request Aug 31, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 31, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2311

sarangan12
sarangan12 reviewed Sep 6, 2018
View reviewed changes
specification/logic/resource-manager/Microsoft.Logic/preview/2018-07-01-preview/logic.json
@@ -4803,12 +4803,6 @@
},
"204": {
"description": "No Content"
},
"default": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the default error response removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only integration account artifact that has the default response. This appears to make the SDK return a 404 response instead of a CloudException, which is what all the other artifacts return.

sarangan12
sarangan12 reviewed Sep 6, 2018
View reviewed changes
specification/logic/resource-manager/Microsoft.Logic/preview/2018-07-01-preview/logic.json Outdated
@@ -6709,7 +6703,7 @@
"NotSpecified",
"AS2",
"X12",
"Edifact"
"EDIFACT"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont this be a breaking change? If so, it will impact the SDK users. Are you really ok with this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still in the process of getting a new (major breaking) version of the SDK out. This was caused by the deserialization of a response from our API in the SDK coming back as all caps. I'll just put this back to being not modeled as a string. This enum is unlikely to be added to

sarangan12
sarangan12 requested changes Sep 6, 2018
View reviewed changes
Copy link
Member

@sarangan12 sarangan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comments

@sarangan12 sarangan12 merged commit d65e891 into Azure:master Sep 10, 2018
@refortie refortie mentioned this pull request Sep 17, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarangan12 sarangan12 sarangan12 approved these changes

Assignees

@sarangan12 sarangan12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@refortie @azuresdkci @AutorestCI @sarangan12