-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventGrid: Update README files to include the current new preview api… #4235
Conversation
… version 2018-09-preview
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
- tag: package-2018-05-preview | ||
- tag: package-2018-01 | ||
- tag: package-2017-09-preview | ||
- tag: package-2017-06-preview | ||
``` | ||
|
||
### Tag: package-2018-09-preview and go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the latest readme.me in the master, it looks like the Go configuration has been branched out to a separate file. It looks like you need to sync those changes in your branch and this change needs to happen in the GO specific readme file.
The linter error is a known issue in the ARM validation: Azure/azure-openapi-arm-validator#10. |
@azuresdkci add to whitelist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@praries880, the "Automation for azure-sdk-for-go" CI step seems to be failing, however reviewing the readme.go.md file, the keys seem to be unique and we can't find what the issue is. Can you please help us with this issue? |
@ahamad-MS you need to fix the ARM validation error : https://github.com/Azure/azure-rest-api-specs/pull/4235/checks?check_run_id=23938472 to get green on the CI Heres the error :
@veronicagg Do you know why was the linter error in the json not caught earlier? |
@praries880, please see my earlier comment above: the linter error is a known issue in the ARM validation: Azure/azure-openapi-arm-validator#10 and is being tracked by the ARM team. |
@jhendrixMSFT Can you help merge the PR in? I seem to lack the required permissions. |
… version 2018-09-preview
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger