Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventGrid: Update README files to include the current new preview api… #4235

Merged
merged 6 commits into from
Oct 18, 2018
Merged

EventGrid: Update README files to include the current new preview api… #4235

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ce84692
EventGrid: Update README files to include the current new preview api…
Oct 15, 2018
90112b5
Fix merge conflict after merging upstream/master
Oct 16, 2018
af89fc5
Update readme.go.md with related api version info
Oct 16, 2018
4b319da
fix parsing failure due to missing closing ``` in readme.go.md
Oct 16, 2018
bd09c5c
suppress failure due to known tool bug per approval from adxsr
Oct 17, 2018
0e6edb6
Fix suppression message
Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion specification/eventgrid/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ These are the global settings for the Azure EventGrid API.

``` yaml
openapi-type: arm
tag: package-2018-05-preview
tag: package-2018-09-preview
```


Expand Down Expand Up @@ -159,12 +159,22 @@ go:

``` yaml $(go) && $(multiapi)
batch:
- tag: package-2018-09-preview
- tag: package-2018-05-preview
- tag: package-2018-01
- tag: package-2017-09-preview
- tag: package-2017-06-preview
```

### Tag: package-2018-09-preview and go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the latest readme.me in the master, it looks like the Go configuration has been branched out to a separate file. It looks like you need to sync those changes in your branch and this change needs to happen in the GO specific readme file.


These settings apply only when `--tag=package-2018-09-preview --go` is specified on the command line.
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag) == 'package-2018-09-preview' && $(go)
output-folder: $(go-sdk-folder)/services/preview/eventgrid/mgmt/2018-09-15-preview/eventgrid
```

### Tag: package-2018-05-preview and go

These settings apply only when `--tag=package-2018-05-preview --go` is specified on the command line.
Expand Down Expand Up @@ -220,10 +230,25 @@ output-folder: $(azure-libraries-for-java-folder)/azure-mgmt-eventgrid

``` yaml $(java) && $(multiapi)
batch:
- tag: package-2018-09-preview
- tag: package-2018-05-preview
- tag: package-2018-01
```

### Tag: package-2018-09-preview and java

These settings apply only when `--tag=package-2018-09-preview --java` is specified on the command line.

Please also specify `--azure-libraries-for-java=<path to the root directory of your azure-sdk-for-java clone>`.

``` yaml $(tag) == 'package-2018-09-preview' && $(java) && $(multiapi)
java:
namespace: com.microsoft.azure.management.eventgrid.v2018_09_15_preview
output-folder: $(azure-libraries-for-java-folder)/eventgrid/resource-manager/v2018_09_15_preview
regenerate-manager: true
generate-interface: true
```

### Tag: package-2018-05-preview and java

These settings apply only when `--tag=package-2018-05-preview --java` is specified on the command line.
Expand Down
11 changes: 11 additions & 0 deletions specification/eventgrid/resource-manager/readme.ruby.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,23 @@ azure-arm: true

``` yaml $(ruby) && $(multiapi)
batch:
- tag: package-2018-09-preview
- tag: package-2018-05-preview
- tag: package-2018-01
- tag: package-2017-09-preview
- tag: package-2017-06-preview
```

### Tag: package-2018-09-preview and ruby
These settings apply only when `--tag=package-2018-09-preview --ruby` is specified on the command line.
Please also specify `--ruby-sdks-folder=<path to the root directory of your azure-sdk-for-ruby clone>`.

``` yaml $(tag) == 'package-2018-09-preview' && $(ruby)

namespace: "Azure::EventGrid::Mgmt::V2018_09_15_preview"
output-folder: $(ruby-sdks-folder)/management/azure_mgmt_event_grid/lib
```

### Tag: package-2018-05-preview and ruby

These settings apply only when `--tag=package-2018-05-preview --ruby` is specified on the command line.
Expand Down