Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger changes for connectors: Google AdWords, Oracle Service Cloud, OData, Rest Service, Dynamics AX and support for wildcardPath. #4258

Merged
merged 7 commits into from
Oct 18, 2018

Conversation

msxzq
Copy link
Contributor

@msxzq msxzq commented Oct 18, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link

msftclas commented Oct 18, 2018

CLA assistant check
All CLA requirements met.

@AutorestCI
Copy link

AutorestCI commented Oct 18, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 18, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3063

@AutorestCI
Copy link

AutorestCI commented Oct 18, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3892

@AutorestCI
Copy link

AutorestCI commented Oct 18, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#222

@hovsepm
Copy link
Contributor

hovsepm commented Oct 18, 2018

@haoyingli and @hvermis please review and sign off on these changes.

@hovsepm hovsepm requested review from hvermis and haoyingli October 18, 2018 18:12
@hovsepm hovsepm merged commit c7b8602 into Azure:master Oct 18, 2018
msxzq added a commit to msxzq/azure-rest-api-specs that referenced this pull request Oct 23, 2018
…e Cloud, OData, Rest Service, Dynamics AX and support for wildcardPath. (Azure#4258)"

This reverts commit c7b8602.
hovsepm pushed a commit that referenced this pull request Oct 24, 2018
…e Cloud, OData, Rest Service, Dynamics AX and support for wildcardPath. (#4258)" (#4309)

This reverts commit c7b8602.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants