Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #4258: "Swagger changes for connectors: Google AdWords, Oracle Service Cloud, OData, Rest Service, Dynamics AX and support for wildcardPath." #4309

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

msxzq
Copy link
Contributor

@msxzq msxzq commented Oct 23, 2018

Revert PR (#4258): "Swagger changes for connectors: Google AdWords, Oracle Service Cloud, OData, Rest Service, Dynamics AX and support for wildcardPath."

UX is not ready and swagger changes should come after UX. So revert swagger changes.

This reverts commit c7b8602.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

…e Cloud, OData, Rest Service, Dynamics AX and support for wildcardPath. (Azure#4258)"

This reverts commit c7b8602.
@AutorestCI
Copy link

AutorestCI commented Oct 23, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3943

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3124

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#301

@hovsepm
Copy link
Contributor

hovsepm commented Oct 23, 2018

@msxzq I'm not clear what is the relation between your UX and swagger? Are you talking about Azure Portal? We in general do not let this kind of reverts unless there is some critical issue with it.

@msxzq
Copy link
Contributor Author

msxzq commented Oct 24, 2018

@msxzq I'm not clear what is the relation between your UX and swagger? Are you talking about Azure Portal? We in general do not let this kind of reverts unless there is some critical issue with it.

Hi @hovsepm , first of all, sorry for the inconvenience.

UX is the app model of connectors in ADF.
On the one hand, according to the internal developing process, we should first release UX and then swagger. There may be breaking changes if swagger is released before UX is ready and UX changes afterwards. In my previous PR, I violated the order so I want to revert the commit to avoid potential risks.
On the other hand, I haven't generated the sdk for the swagger changes in the previous PR so the rollback won't bring customer impacts.

Could you please help me rollback the commit ? Thanks!

@hovsepm hovsepm merged commit 70a6f20 into Azure:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants