Reverting change: Replacing PartialSync for IncrementalSync for sync type and updating examples. #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type and updating examples.
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
sergey-shandar
approved these changes
Oct 23, 2018
|
@vrdmr please, review. |
sergey-shandar
approved these changes
Oct 23, 2018
Automation for azure-sdk-for-rubyA PR has been created for you: |
mccleanp
pushed a commit
that referenced
this pull request
Mar 23, 2022
…sion preview/2021-04-01-preview (#4369) * [Hub Generated] Review request for Microsoft.MobileNetwork to add version preview/2021-04-01-preview (#4303) * msazuredev/12524 merge sim and simProfile * fix duplicated example warning * Remove spurious mobile network Sims_ListByMobileNetwork operation (#4317) * Dev mobilenetwork microsoft.mobile network 2021 04 01 preview 6452 (#4329) * mobile network name pattern after confirmed with Fiona * iccid, imsi, ki and opc code pattern * make sim examples comply with patterns * Update mobileNetwork.json (#4319) * Update mobileNetwork.json * Create SimIdListByNetwork.json * Rename SimIdListByNetwork.json to SimIdListByMobileNetwork.json Co-authored-by: jiandongcui <85569904+jiandongcui@users.noreply.github.com> * fix examples for deleted sims field in mobile network * resolve r2063 * resolve lint error * resolve more lint error * prettier fix format * examples in 2021-04-01 should use api-version 2021-04-01-preview * Add Go multi-api section Co-authored-by: nickweeds2 <80526218+nickweeds2@users.noreply.github.com> Co-authored-by: samaddip <66083466+samaddip@users.noreply.github.com> Co-authored-by: Sathiyan Sivathas <sathiyan.sivathas@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: After a discussion with the feature team, we decided syncType using PartialSync and FullSync is descriptive enough and our clients (cmdlets and Portal) already relied on this property, so we are going to leave it as is.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger