Change to add Operation IDs for outbound rules in load balancer #4319

khannarhea · 2018-10-24T20:00:29Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

* Swagger Coverage/Completeness- for operation CheckNameAvailability (Azure#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Update dns management Node.js version number to 3.0.0 (Azure#3675) * Update batchai Node.js package version to 2.0.2 (Azure#3664) * Update nofiticationhubs management Node.js package version to 2.0.0 (Azure#3665) * WebApps - Add BackupName to backup API models (Azure#3560) * WebApps - Add BackupName to replace non-ARM-compliant Name property on Backup API models * Revert breaking change to BackupItem. BackupItemName property will be fine in place of BackupName for now. * Update authorization management Node.js package version to 5.0.1 (Azure#3676) * Update storagesync management Node.js package version to 1.0.0 (Azure#3677) * add checknameavailability (Azure#3608) * add checknameavailability * move checkname parameter to definition section * fix brackets * fix parameter name in checknameavailability exanple * update code owners for PowerBIDedicated * New Batch data plane API version 2018-08-01.7.0 (Azure#3657) * Add new batch version 2018-08-01.7.0 * Update the new API * Fix up output from OAD, it does not output valid JSON * update OAV (Azure#3678) * Update storage management Node.js package version to 5.2.0 (Azure#3679) * Update compute.json and disk.json for some issues and add zone and rolling upgrade. (Azure#3642) * Breaking change tool correctly handles multiple files with same name * Fix to breaking changes table generation * Trusted Root certificate (Azure#3668)

…ure-rest-api-specs

AutorestCI · 2018-10-24T20:00:36Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 7a4040bb9ad7280dfa5c077f62d1c6abb1d69925
  stderr: 'fatal: reference is not a tree: 7a4040bb9ad7280dfa5c077f62d1c6abb1d69925'

AutorestCI · 2018-10-24T20:00:36Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 7a4040bb9ad7280dfa5c077f62d1c6abb1d69925
  stderr: 'fatal: reference is not a tree: 7a4040bb9ad7280dfa5c077f62d1c6abb1d69925'

AutorestCI · 2018-10-24T20:04:24Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 7a4040bb9ad7280dfa5c077f62d1c6abb1d69925
  stderr: 'fatal: reference is not a tree: 7a4040bb9ad7280dfa5c077f62d1c6abb1d69925'

azuresdkci · 2018-10-24T20:05:22Z

Can one of the admins verify this patch?

AutorestCI · 2018-10-24T20:23:13Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 7a4040bb9ad7280dfa5c077f62d1c6abb1d69925
  stderr: 'fatal: reference is not a tree: 7a4040bb9ad7280dfa5c077f62d1c6abb1d69925'

AutorestCI · 2018-10-24T20:28:21Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 7a4040bb9ad7280dfa5c077f62d1c6abb1d69925
  stderr: 'fatal: reference is not a tree: 7a4040bb9ad7280dfa5c077f62d1c6abb1d69925'

…sion preview/2021-04-01-preview (#4369) * [Hub Generated] Review request for Microsoft.MobileNetwork to add version preview/2021-04-01-preview (#4303) * msazuredev/12524 merge sim and simProfile * fix duplicated example warning * Remove spurious mobile network Sims_ListByMobileNetwork operation (#4317) * Dev mobilenetwork microsoft.mobile network 2021 04 01 preview 6452 (#4329) * mobile network name pattern after confirmed with Fiona * iccid, imsi, ki and opc code pattern * make sim examples comply with patterns * Update mobileNetwork.json (#4319) * Update mobileNetwork.json * Create SimIdListByNetwork.json * Rename SimIdListByNetwork.json to SimIdListByMobileNetwork.json Co-authored-by: jiandongcui <85569904+jiandongcui@users.noreply.github.com> * fix examples for deleted sims field in mobile network * resolve r2063 * resolve lint error * resolve more lint error * prettier fix format * examples in 2021-04-01 should use api-version 2021-04-01-preview * Add Go multi-api section Co-authored-by: nickweeds2 <80526218+nickweeds2@users.noreply.github.com> Co-authored-by: samaddip <66083466+samaddip@users.noreply.github.com> Co-authored-by: Sathiyan Sivathas <sathiyan.sivathas@microsoft.com>

khannarheams and others added 11 commits August 6, 2018 13:48

Test first commit

601b3bd

Trusted Root certificate (Azure#3668)

3ff4b52

Merge branch 'master' of git://github.com/Azure/azure-rest-api-specs

f867a7a

Merge branch 'Network-September-Release' of git://github.com/Azure/az…

b8e0913

…ure-rest-api-specs

Merge branch 'master' of git://github.com/Azure/azure-rest-api-specs

495bcb9

Changes to add required properties to outbound rule

6070409

Merge branch 'master' of git://github.com/Azure/azure-rest-api-specs

d8da99c

Fetch upstream master

c588675

Merge remote-tracking branch 'upstream/master'

4faf9a6

Add Operation IDs for outbound rule

6fb77ec

khannarhea requested review from hitenjava, MikhailTryakhov, schaabs and yangyuan as code owners October 24, 2018 20:00

khannarhea changed the base branch from network-october-release to master October 24, 2018 20:02

azuresdkci assigned jianghaolu Oct 24, 2018

azuresdkci requested a review from jianghaolu October 24, 2018 20:02

Merge remote-tracking branch 'upstream/master'

6216597

AutorestCI mentioned this pull request Oct 24, 2018

[AutoPR network/resource-manager] Change to add Operation IDs for outbound rules in load balancer Azure/azure-sdk-for-ruby#1799

Closed

khannarhea closed this Oct 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change to add Operation IDs for outbound rules in load balancer #4319

Change to add Operation IDs for outbound rules in load balancer #4319

khannarhea commented Oct 24, 2018

AutorestCI commented Oct 24, 2018 •

edited

Loading

AutorestCI commented Oct 24, 2018 •

edited

Loading

AutorestCI commented Oct 24, 2018 •

edited

Loading

azuresdkci commented Oct 24, 2018

AutorestCI commented Oct 24, 2018 •

edited

Loading

AutorestCI commented Oct 24, 2018 •

edited

Loading

Change to add Operation IDs for outbound rules in load balancer #4319

Change to add Operation IDs for outbound rules in load balancer #4319

Conversation

khannarhea commented Oct 24, 2018

PR information

Quality of Swagger

AutorestCI commented Oct 24, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Oct 24, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Oct 24, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Oct 24, 2018

AutorestCI commented Oct 24, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Oct 24, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Oct 24, 2018 •

edited

Loading

AutorestCI commented Oct 24, 2018 •

edited

Loading

AutorestCI commented Oct 24, 2018 •

edited

Loading

AutorestCI commented Oct 24, 2018 •

edited

Loading

AutorestCI commented Oct 24, 2018 •

edited

Loading