Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MediaJobOutputProgressEventData in Media Services EventGrid swagger #5027

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Add MediaJobOutputProgressEventData in Media Services EventGrid swagger #5027

merged 1 commit into from
Jan 16, 2019

Conversation

jinshang-msft
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@msftclas
Copy link

msftclas commented Jan 11, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@AutorestCI AutorestCI mentioned this pull request Jan 11, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#707

@azuresdkci azuresdkci requested a review from anuchandy January 11, 2019 22:01
@AutorestCI AutorestCI mentioned this pull request Jan 11, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3629

@AutorestCI AutorestCI mentioned this pull request Jan 11, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2152

@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jan 11, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4322

@AutorestCI AutorestCI mentioned this pull request Jan 11, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 11, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3887

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anuchandy anuchandy requested a review from kalyanaj January 14, 2019 14:56
@anuchandy
Copy link
Member

@kalyanaj could you take a look given this is an integration between event grid and media?

kalyanaj
kalyanaj approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@kalyanaj kalyanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once this get merged, will you also be able to help update event types list/event mapping/tests for Media services event types in the C# SDK to include this new event type? The relevant links are:

https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/EventGrid/DataPlane/Microsoft.Azure.EventGrid/Customization/EventTypes.cs,
https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/EventGrid/DataPlane/Microsoft.Azure.EventGrid/Customization/SystemEventTypeMappings.cs,
https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/EventGrid/DataPlane/Microsoft.Azure.EventGrid.Tests/Tests/ConsumeEventTests.cs

@jinshang-msft
Copy link
Contributor Author

Updated event types in azure-sdk-for-net in this commit

@anuchandy
Copy link
Member

thanks @kalyanaj, @Chuansssss.

@anuchandy anuchandy merged commit 56c4282 into Azure:master Jan 16, 2019
@jinshang-msft jinshang-msft deleted the ams-eventgrid-update branch January 16, 2019 17:49
@jinshang-msft jinshang-msft mentioned this pull request Jan 16, 2019
Merged
9 tasks
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@jinshang-msft @AnuTalluri
Add MediaJobOutputProgressEventData in Azure Media Services EventGrid…
b1c242d 
… swagger file (Azure#5027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalyanaj kalyanaj kalyanaj approved these changes

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jinshang-msft @msftclas @AutorestCI @azuresdkci @anuchandy @kalyanaj