-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MediaJobOutputProgressEventData and corresponding test #5145
Adding MediaJobOutputProgressEventData and corresponding test #5145
Conversation
Can one of the admins verify this patch? |
@Chuansssss please join the azure org here |
@dsgouda Just linked Github account to my Microsoft email account. Is there any further steps I have to take? |
Please navigate to the link posted and join the |
@dsgouda Be added in Azure org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was this code generated? Please generate the code using the generate.ps1 script here and update the PR
Please update the Nuget version number to 3.1.0
in the csproj and the PackageReleaseNotes
too
@dsgouda The code I submitted was originally generated by the .ps1 script you provided. |
WHen the code is generated using generate.ps1 script it should also update a .txt file, please commit the .txt file too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dsgouda Thanks :) |
Description
Added MediaJobOutputProgressEventData type and corresponding test based on the change in azure-rest-api-specs repository committed here and also the link to the PR in REST specs.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.