Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MediaJobOutputProgressEventData and corresponding test #5145

Merged

Conversation

jinshang-msft
Copy link
Contributor

@jinshang-msft jinshang-msft commented Jan 16, 2019

Description

Added MediaJobOutputProgressEventData type and corresponding test based on the change in azure-rest-api-specs repository committed here and also the link to the PR in REST specs.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@dsgouda
Copy link
Contributor

dsgouda commented Jan 16, 2019

@Chuansssss please join the azure org here

@jinshang-msft
Copy link
Contributor Author

@dsgouda Just linked Github account to my Microsoft email account. Is there any further steps I have to take?

@dsgouda
Copy link
Contributor

dsgouda commented Jan 16, 2019

Please navigate to the link posted and join the Azure org on the portal

@jinshang-msft
Copy link
Contributor Author

@dsgouda Be added in Azure org

@dsgouda dsgouda closed this Jan 17, 2019
@dsgouda dsgouda reopened this Jan 17, 2019
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this code generated? Please generate the code using the generate.ps1 script here and update the PR
Please update the Nuget version number to 3.1.0 in the csproj and the PackageReleaseNotes too

@jinshang-msft
Copy link
Contributor Author

@dsgouda The code I submitted was originally generated by the .ps1 script you provided.

@dsgouda
Copy link
Contributor

dsgouda commented Jan 18, 2019

WHen the code is generated using generate.ps1 script it should also update a .txt file, please commit the .txt file too

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 2ad17e4 into Azure:psSdkJson6 Jan 18, 2019
@jinshang-msft
Copy link
Contributor Author

@dsgouda Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants