Creates the "real" API for Scheduled Alert Rules #5084

nirgfani · 2019-01-24T14:45:11Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…sight). This RP is an extension RP of "Microsoft.operationalinsights", and it is coupled to a Log analytics workspace. This is a first iteration in order to create a simple RP with single endpoint, after it wil work the API will be changed with the actual and full endpoints based on the learnings from this POC.

…eter and reuse it in the PUT same as in the GET

…sights

Merging from Azure Repo

…pecs

openapi-portal-comment · 2019-01-24T14:45:12Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2019-01-24T14:45:57Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#1035

AutorestCI · 2019-01-24T14:45:58Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-01-24T14:46:04Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4268

AutorestCI · 2019-01-24T14:46:12Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2019-01-24T14:46:53Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4609

AutorestCI · 2019-01-24T14:47:39Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3971

azuresdkci · 2019-01-24T15:04:36Z

Can one of the admins verify this patch?

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json

...Microsoft.SecurityInsights/preview/2019-01-01-preview/examples/DeleteScheduledAlertRule.json

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json

* Changing durations to fit standards * Changing operators to fit other RPs * Align naming to scheduledAlertRules * Adding 200 response to DeleteScheduledAlertRule

alertTriggerOperator => triggerOperator alertTriggerThreshold => triggerThreshold

ryansbenson

Approved from ARM

sergey-shandar

LGTM

This reverts commit d847550.

* Revert "typo: azure-mgmt-containerservices -> azure-mgmt-containerservice (#5103)" This reverts commit c8be36b. * Revert "Add missing Java code gen info to Kusto (#5142)" This reverts commit 8c304e7. * Revert "Update compute.json (#4866)" This reverts commit 72afb64. * Revert "Add SkillsetOperations to C# code generation settings (#5132)" This reverts commit b2ed47f. * Revert "[GuestConfiguration]Update ConfigurationInfo class to include version field (#5131)" This reverts commit 930987c. * Revert "Adding new api-version to Microsoft.Security Alerts resource (#4902)" This reverts commit 93f46f5. * Revert "Add a spec for policyStates API version 2018-07-01-preview (#5134)" This reverts commit 84d025e. * Revert "added link to disk properties for UltraSSD values (#5135)" This reverts commit e713e24. * Revert "Undoing unintended removal of a field (#5133)" This reverts commit e0f2f8c. * Revert "Run separate instance of OAV (#5026)" This reverts commit e44239a. * Revert "Eventhub: Added skipEmptyArchives to Eventhub CaptureDescription (#5105)" This reverts commit eaf5e5c. * Revert "Resourcehealth events response (#5116)" This reverts commit 935baac. * Revert "Add Helm Events to ACR Schema for Event Grid (#5109)" This reverts commit 6f4cee5. * Revert " Creates the "real" API for Scheduled Alert Rules (#5084)" This reverts commit d847550. * Revert "Update managedInstances.json (#5114)" This reverts commit 2072ba5. * Revert "HDFS FE: Update 2018-11-09 DataLakeStorage Swagger. (#5108)" This reverts commit 60a8c18. * Revert "Add dispatch child to LUIS Runtime response (#5100)" This reverts commit 03581da. * Revert "Add new field 'proximityPlacementGroup' to properties of HanaInstance (#5107)" This reverts commit 31fa6a1. * Revert "fix Go SDK codegen for Microsoft.Insights (#5106)" This reverts commit b5ac8e3. * Revert "[AKS] add apiServerAuthorizedIPRanges property (#5101)" This reverts commit 8d178c3.

* Creating first and basic swagger for new RP of ASI (Azure Security Insight). This RP is an extension RP of "Microsoft.operationalinsights", and it is coupled to a Log analytics workspace. This is a first iteration in order to create a simple RP with single endpoint, after it wil work the API will be changed with the actual and full endpoints based on the learnings from this POC. * updating the operationalInsightsResourceProvider to be a global parameter and reuse it in the PUT same as in the GET * Fixing comments from PR * Fixing the Microsoft.OperationalInsight to the right form * Updating the location to be under- "resource-manager" * adding readme files for the swagger * Changing the path of the files to the correct path * Change the location of the readme files * Fixing inconsistency in the naming- changing everything to SecurityInsights * Missed the file when aligned the name to SecurityInsights * Fixing a redundant space in the examples * add alertRule to the CreateAlertRule.json and do some indentation fixes * Creates the "real" API for Scheduled Alert Rules * Update the name alertRule to alertScheduledtRule in the creation example * Fixing comments from PR- * Changing durations to fit standards * Changing operators to fit other RPs * Align naming to scheduledAlertRules * Adding 200 response to DeleteScheduledAlertRule * Changing naming- alertTriggerOperator => triggerOperator alertTriggerThreshold => triggerThreshold * Adding kind to AlertRule and making Scheduled as a specific kind * Fix some errors * Trying to solve the model validator issues * Fixing indentation

nirgfani and others added 15 commits December 31, 2018 15:00

updating the operationalInsightsResourceProvider to be a global param…

de2a4c9

…eter and reuse it in the PUT same as in the GET

Fixing comments from PR

8e0cd13

Fixing the Microsoft.OperationalInsight to the right form

7d0a4c7

Updating the location to be under- "resource-manager"

fd243ea

adding readme files for the swagger

f16db7f

Changing the path of the files to the correct path

1703e6f

Change the location of the readme files

36aca1e

Fixing inconsistency in the naming- changing everything to SecurityIn…

5326e67

…sights

Missed the file when aligned the name to SecurityInsights

a9475d1

Fixing a redundant space in the examples

93b148d

add alertRule to the CreateAlertRule.json and do some indentation fixes

73565ce

Merge pull request #1 from Azure/master

5ed047d

Merging from Azure Repo

Creates the "real" API for Scheduled Alert Rules

8808c18

Merge branch 'master' of https://github.com/nirgfani/azure-rest-api-s…

b63cbf7

…pecs

AutorestCI mentioned this pull request Jan 24, 2019

[AutoPR securityinsights/resource-manager] Creates the "real" API for Scheduled Alert Rules Azure/azure-sdk-for-js#981

Merged

AutorestCI mentioned this pull request Jan 24, 2019

[AutoPR securityinsights/resource-manager] Creates the "real" API for Scheduled Alert Rules Azure/azure-sdk-for-python#4229

Merged

azuresdkci assigned sergey-shandar Jan 24, 2019

azuresdkci requested a review from sergey-shandar January 24, 2019 14:46

AutorestCI mentioned this pull request Jan 24, 2019

[AutoPR securityinsights/resource-manager] Creates the "real" API for Scheduled Alert Rules Azure/azure-sdk-for-node#4587

Merged

AutorestCI mentioned this pull request Jan 24, 2019

[AutoPR securityinsights/resource-manager] Creates the "real" API for Scheduled Alert Rules Azure/azure-sdk-for-go#3936

Merged

Update the name alertRule to alertScheduledtRule in the creation example

12beca7

ryansbenson added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 24, 2019

nschonni reviewed Jan 25, 2019

View reviewed changes

ryansbenson reviewed Jan 25, 2019

View reviewed changes

ryansbenson added ARMReviewInProgress ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 25, 2019

nirgfani and others added 6 commits January 25, 2019 18:31

Fixing comments from PR-

1d1029b

* Changing durations to fit standards * Changing operators to fit other RPs * Align naming to scheduledAlertRules * Adding 200 response to DeleteScheduledAlertRule

Changing naming-

863597a

alertTriggerOperator => triggerOperator alertTriggerThreshold => triggerThreshold

Adding kind to AlertRule and making Scheduled as a specific kind

573869d

Fix some errors

27d8376

Trying to solve the model validator issues

0f74576

Fixing indentation

831ec10

ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReviewInProgress labels Jan 30, 2019

ryansbenson approved these changes Jan 30, 2019

View reviewed changes

sergey-shandar approved these changes Jan 30, 2019

View reviewed changes

sergey-shandar merged commit d847550 into Azure:master Jan 30, 2019

anuchandy added a commit that referenced this pull request Jan 30, 2019

Revert " Creates the "real" API for Scheduled Alert Rules (#5084)"

d83dc50

This reverts commit d847550.

yangl900 added a commit to yangl900/azure-rest-api-specs that referenced this pull request Feb 4, 2019

Revert " Creates the "real" API for Scheduled Alert Rules (Azure#5084)"

84c70ed

This reverts commit d847550.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Creates the "real" API for Scheduled Alert Rules #5084

Creates the "real" API for Scheduled Alert Rules #5084

nirgfani commented Jan 24, 2019 •

edited

Loading

openapi-portal-comment bot commented Jan 24, 2019

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

azuresdkci commented Jan 24, 2019

ryansbenson left a comment

sergey-shandar left a comment

Creates the "real" API for Scheduled Alert Rules #5084

Creates the "real" API for Scheduled Alert Rules #5084

Conversation

nirgfani commented Jan 24, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-portal-comment bot commented Jan 24, 2019

AutorestCI commented Jan 24, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jan 24, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jan 24, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jan 24, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jan 24, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jan 24, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Jan 24, 2019

ryansbenson left a comment

Choose a reason for hiding this comment

sergey-shandar left a comment

Choose a reason for hiding this comment

nirgfani commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading