Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR securityinsights/resource-manager] Creates the "real" API for Scheduled Alert Rules #4229

Merged

Conversation

AutorestCI
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #4229 into restapi_auto_securityinsights/resource-manager will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                                Coverage Diff                                 @@
##           restapi_auto_securityinsights/resource-manager    #4229      +/-   ##
==================================================================================
- Coverage                                           53.76%   53.76%   -0.01%     
==================================================================================
  Files                                                9800     9796       -4     
  Lines                                              209939   209935       -4     
==================================================================================
- Hits                                               112870   112866       -4     
  Misses                                              97069    97069
Impacted Files Coverage Δ
...-luis/azure/cognitiveservices/language/__init__.py
...suggest/azure/cognitiveservices/search/__init__.py
...ledge-qnamaker/azure/cognitiveservices/__init__.py
azure-mgmt-advisor/azure/mgmt/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b930d6...d8ce7ad. Read the comment docs.

@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jan 24, 2019

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-securityinsight

You can install the package azure-mgmt-securityinsight of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5084#egg=azure-mgmt-securityinsight&subdirectory=azure-mgmt-securityinsight"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5084#egg=azure-mgmt-securityinsight&subdirectory=azure-mgmt-securityinsight"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_5084
  • pip install -e ./azure-mgmt-securityinsight

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_5084
  • pip wheel --no-deps ./azure-mgmt-securityinsight

Direct download

Your files can be directly downloaded here:

Fixing comments from PR-

* Changing durations to fit standards
* Changing operators to fit other RPs
* Align naming to scheduledAlertRules
* Adding 200 response to DeleteScheduledAlertRule
Adding kind to AlertRule and making Scheduled as a specific kind
Trying to solve the model validator issues
@AutorestCI AutorestCI merged commit 6c10925 into restapi_auto_securityinsights/resource-manager Jan 30, 2019
@AutorestCI AutorestCI deleted the restapi_auto_5084 branch January 30, 2019 18:41
@AutorestCI
Copy link
Contributor Author

This PR has been merged into #4268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants