Add WAF as a top level resource #5341

azhao155 · 2019-03-07T23:11:22Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azuresdkci · 2019-03-07T23:11:27Z

Can one of the admins verify this patch?

AutorestCI · 2019-03-07T23:13:12Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp_n8qgru4/rest/specification/network/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp_n8qgru4/sdk', '--use=@microsoft.azure/autorest.python@~3.0.56', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0.56->3.0.58)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2018-12"} .

<--- Last few GCs --->

[4819:0x3c0ce60]    86486 ms: Mark-sweep 1376.8 (1460.4) -> 1376.6 (1464.9) MB, 2047.3 / 0.0 ms  allocation failure GC in old space requested
[4819:0x3c0ce60]    88209 ms: Mark-sweep 1376.6 (1464.9) -> 1376.6 (1426.4) MB, 1722.3 / 0.0 ms  last resort GC in old space requested
[4819:0x3c0ce60]    89861 ms: Mark-sweep 1376.6 (1426.4) -> 1376.6 (1424.9) MB, 1651.6 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x275658da5879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0x9716ae898a9](this=0x31cec6c07041 <JSWeakMap>,key=0x12b076a4eb29 <Object map = 0x331e86f223e9>,value=0x6514a4023e1 <false>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~101] [pc=0x9716acf13f9](this=0x6514a4022d1 <undefined>,cach...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8c21ec [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x9716ab842fd

AutorestCI · 2019-03-07T23:13:24Z

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmpk2th6dy7/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmpk2th6dy7/azure-sdk-for-js', '--use=@microsoft.azure/autorest.typescript@2.1.1']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4299/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4299)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (2.1.1->2.1.1)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)

<--- Last few GCs --->

[9023:0x257c860]   113667 ms: Mark-sweep 1399.5 (1478.9) -> 1399.5 (1478.9) MB, 1388.1 / 0.0 ms  allocation failure GC in old space requested
[9023:0x257c860]   115627 ms: Mark-sweep 1399.5 (1478.9) -> 1399.5 (1443.9) MB, 1958.9 / 0.0 ms  last resort GC in old space requested
[9023:0x257c860]   117279 ms: Mark-sweep 1399.5 (1443.9) -> 1399.5 (1443.4) MB, 1652.6 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x2ff3431a5879 <JSObject>
    1: add [native weak-collection.js:~64] [pc=0x118aeb3e4aa9](this=0x173ebabf9261 <JSWeakSet>,j=0x15bafabce189 <JSProxy>)
    2: losslessJsonSerializable(aka losslessJsonSerializable) [/root/.autorest/@microsoft.azure_autorest-core@2.0.4299/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~232] [pc=0x118aeb5465bb](this=0x328acf6022d1 <undefined>,o=0x15bafabce189 <JSProxy>)
    3...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x118aeb2042fd

azhao155 · 2019-03-07T23:13:51Z

This pr is the duplicate of the following one:
#5185

the resource api version is 12/01/2018, so it should be fine to merge into February branch.

@number213 , please comment, since you are the reviewer for the above pr

AutorestCI · 2019-03-07T23:15:01Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpnr_fke6p/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpnr_fke6p/azure-sdk-for-node', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.2.131']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.2.131->2.2.131)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

<--- Last few GCs --->

[12714:0x2e4b860]   324603 ms: Mark-sweep 1374.0 (1461.9) -> 1373.9 (1463.4) MB, 4270.1 / 0.0 ms  allocation failure GC in old space requested
[12714:0x2e4b860]   328481 ms: Mark-sweep 1373.9 (1463.4) -> 1373.9 (1426.9) MB, 3877.7 / 0.0 ms  last resort GC in old space requested
[12714:0x2e4b860]   331212 ms: Mark-sweep 1373.9 (1426.9) -> 1373.9 (1422.4) MB, 2730.7 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x3fe325125879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0x2343a24fca69](this=0x19b2976a0e91 <JSWeakMap>,key=0x2077f491f8a9 <Object map = 0x332b8dd4531>,value=0xe6dfb2023e1 <false>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~101] [pc=0x2343a2473ff9](this=0xe6dfb2022d1 <undefined>,cac...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x2343a23042fd

AutorestCI · 2019-03-07T23:19:22Z

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2306

AutorestCI · 2019-03-07T23:37:34Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpnahcxvrt/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpnahcxvrt/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.127', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Including configuration file 'file:///tmp/tmpnahcxvrt/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.127->2.1.127)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-12"} .
   Including configuration file 'file:///tmp/tmpnahcxvrt/rest/specification/network/resource-manager/readme.go.md'
Shutting Down
Shutting Down
FATAL: go/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Failure during batch task - {"tag":"package-2018-12"} -- false.

AutorestCI · 2019-03-08T00:30:57Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

anton-evseev

LGTM except a few nitpicks.
Also, regarding definitions PolicySettings, CustomRule, Transform, MatchVariable and MatchCondition. All Network models in SDK exist in one namespace, so having a model like CustomRule without context may be confusing. I would prefix all of them with WebApplicationFirewall (e.g. WebApplicationFirewallCustomRule)
@akshaysngupta @dsgouda what do you think?

anton-evseev · 2019-03-08T06:46:42Z

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json

+      "description": "Defines contents of a web application firewall global configuration",
+      "properties": {
+        "enabledState": {
+          "description": "describes if the policy is in enabled state or disabled state",


Please start description with uppercase letter for consistency

I will change definition of custom rule into WebApplicationFirewallCustomRule

we can't make the change now, since NRP already has the propety named custom rule, and property name in the swagger and nrp should match

anton-evseev · 2019-03-08T07:21:57Z

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json

+            "modelAsString": true
+          }
+        },
+        "negationConditon": {


Conditon
Typo? Examples don't contain this property, could you please verify how it's spelled on backend?

Yes, that's what we specify in the backend, so it has to be match

anton-evseev · 2019-03-08T07:22:39Z

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json

+          ],
+          "type": "string",
+          "x-ms-enum": {
+            "name": "WebApplicationFirewallPolicyPropertiesFormat",


This enum has the same name it's parent definition has, this could cause collisions in generated SDK. Plus as the name of enum it's not really clear. Please rename it to something like WebApplicationFirewallPolicyResourceState

made the change

anton-evseev · 2019-03-08T07:33:16Z

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json

+  ],
+  "produces": [
+    "application/json"
+  ],


Please add security property to fix CI errors
See https://github.com/Azure/azure-rest-api-specs/blob/master/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/endpointService.json#L18 for reference

dsgouda · 2019-03-08T17:17:08Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/WafPolicyGet.json

+                        ]
+                    }
+                }
+            }


nit: Please use 2 spaces instead of 4 for formatting

dsgouda · 2019-03-08T17:18:11Z

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json

+            "$ref": "#/parameters/ApiVersionParameter"
+          }
+        ],
+        "responses": {


Please add a default error response

I did the powershell testing, if add default error response, it will generate different exception which won't be caught. Please reference the applicationGateway.json delete operation in the network.

dsgouda · 2019-03-08T17:19:17Z

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json

+        },
+        "nextLink": {
+          "type": "string",
+          "description": "URL to get the next set of WebApplicationFirewallPolicy objects if there are any."


Please mark this as readonly

MikhailTryakhov · 2019-03-08T20:38:31Z

@azhao155 please escalate fixes here, release is on Monday and you're close to miss it

azhao155 · 2019-03-08T23:29:50Z

@MikhailTryakhov @dsgouda @number213 I have addressed comments, please check, it's critical for us and we need to catch the February release.

dsgouda

LGTM will wait for @number213 's approval

azhao155 · 2019-03-08T23:30:49Z

@asridharan this is needed to be into febuary release

azhao155 · 2019-03-08T23:32:22Z

@MikhailTryakhov @dsgouda @number213 i saw it has out of memory issue, could you help us to address it? it's urgent for us.

dsgouda · 2019-03-08T23:36:02Z

@jhendrixMSFT @sergey-shandar could you take a look

azhao155 · 2019-03-11T19:53:48Z

@jhendrixMSFT @sergey-shandar Thanks for the fix, but it's still failing, we need to merge this pr by EOD, please help.

dsgouda · 2019-03-11T19:55:11Z

@azhao155 Some of these are acceptable failures, will merge the PR once all the builds are done.

azhao155 · 2019-03-11T19:59:55Z

Thanks for @dsgouda explanation. Thanks for the help again!

* Adds base for updating Microsoft.Network from version stable/2018-12-01 to version 2018-12-01 * Updates readme * Updates API version in new specs and examples * Network: Duplicate tags in readme file. (#5227) * FI from `master` branch to `network-february-release`. (#5262) * DataFactory Swagger Change for SapOpenHub and Rest (#5195) * DataFactory Swagger Change for SapOpenHub and Rest * correct indentation * address comment of REST * fix syntax issue * Fix issue with AutoRest * Add cognitive service AnomalyFinder (#5126) * add AnomalyFinder swagger json * AnomalyFinder update swagger json * add AnomalyFinder readme * fix file path; change class name; * make camelCase style * fix typo; change operationId; remove hard code arg limitation; * fix type of "sensitivity"; change description of "timestamp"; * Improving secretVersion description (#5220) * [Cogsvcs] LUIS - add text to simple entity description (#5216) * Add hwRevision field to HanaInstance definition (#5196) * [DataFactory] Swagger changes for ADF newly released features: (#5218) * Swagger changes for ADF newly released features: 1. I can load data from o365 by leveraging the REST endpoint of o365 2. Support copying incremental files based on lastModifiedTime for S3/File/Blob 3. Enable ADLS Gen2 connector as both source & sink 4. Support data migration from MongoDB to CosmosDB (MongoDB API) 5. Make Kusto source/sink better and support Azure Data exploer source/sink 6. Support copy from ADLS Gen1 to ADLS Gen2 with ACL 7. serviceUrl @ S3 linked service 8. I can copy from Dynamics AX 9. AAD OAuth for OData Linked Service 10. I can copy from Oracle Service Cloud and Google Adwords * fix swagger definetion for MongoDB Srouce cursor method. * fix Amazon S3 servie url definition * fix CosmosDbMongoDbApiSink * Fix several typos * Add maxConcurrentConnections in CopySource and CopySink * Node v 10. (#5236) * Remove API reference of Gender::genderless. (#5188) * Add an Operations API for Commitment Plan RP (#5222) * Add an Operations API for Commitment Plan RP * Add OperationEntityListResult related definitions * Fix case typo * Fix tab to spaces * Fix NewtonSoftJson Issue (#5240) * Support create pipeline run with recovery mode * Update description of isLatest * Update descriptions * update autorest version to fix CI * Add suppresses for Machine Learning Commitment Plan RP (#5221) * typo: datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/ (#5238) - Adwords -> AdWords - connectioned to -> for the * scripts (#5213) * scripts * TRAVIS_PULL_REQUEST * another try * TRAVIS_PULL_REQUEST_SLUG * TRAVIS_REPO_SLUG * Swagger to SDK * linter and ruby * not really a slug * pool * indent * strange * URI * env vars * uri * env var * TRAVIS_PULL_REQUEST_SLUG * matrix * Azure OpenAPI name * linter: autorest fix * error handling and PR_ONLY = true * syntax * pipelines. * job name * job name * Names * params, no getStatus.js * No CI, only PR validations. * displayName * revert back * no need to show vars * Fix for lintdiff tool memory issue. (#5246) * node options * correct NODE_OPTIONS * lintdiff travis-ci * 2019 Azure Stack hybrid Profile. (#5212) * 2019 Azure Stack hybrid Profile. * fixing changes for profile * remove space * formatted profile * [Azure Search] Add Suggest and Index APIs to data plane Swagger spec (#5219) * Renaming Search|SuggestParametersPayload to *Request and making them internal Made AutocompleteRequest internal too, and fixed some incorrect comments. * Adding Suggest API to the Azure Search data plane spec * Fixing validation error in Suggest example * Adding Index API to the Azure Search data plane spec * Make example names consistent * Adding new properties to Databricks LS and custom activity (#5214) * typo: instantitate -> instantiate (#5251) * Users/laramume/addv2.1 swagger (#5187) * updated model names in preview version to be consistent with stable version to avoid breaking changes in client side code * changed swagger files * added v2.1 swagger * added v2.1 swagger * added v2.1 swagger * added v2.1 swagger * added v2.1 swagger * resolved PR comments * Update swagger file and examples with time zone parameter (#5224) * Update swagger documetation to mark Collation property as writable. Change Managed Instance collation property from read only to read and create. Add collation to properties section in ManagedInstanceCreateMax example. VSTS task: 12336257 * Remove 'cosmetics' from swagger. * Remove comma as redundant * Return to the initial, generated state. * Update swagger file and examples with time zone parameter * Minor (but improtant) changes in Azure DevOps pipeline. (#5253) * empty parameters * TRAVIS_BRANCH * target branch * trying to set env var * use shell * info * more info * Pull Request Number * [Ready to MERGE] Swagger for Tenant Properties API (#5038) * added swagger for Tenant Properties added swagger for Tenant Properties * Fixed camel casing in billing.json file Fixed camel casing in billing.json file * Update billing.json * changes in DiscoverTenants contracts changes in DiscoverTenants contracts * billing.Json trim blank space billing.Json trim blank space * Update billing.json * removal of plural name removal of plural name * Updating the route Updating the route as per suggestion * Moved Swagger for Discover Tenants from billing to consumption Moved Swagger for Discover Tenants from billing to consumption * Change in Namespace followed by one additional parameter "billingAccountId" Change in Namespace followed by one additional parameter "billingAccountId" * Change of method name from discoverTenants to tanants. Change of method name from discoverTenants to tanants. * changes ion response type changes ion response type * added name after Id. Code review implementation added name after Id. Code review implementation * Add JavaScript/TypeScript generation details to resource-manager/netapp (#5261) * Azure Security Center - break-to-composite v1 (#5197) * Azure Security Center - break-to-composite v1 * Azure Security Center - composite api v1 - suppress email format * Add globalReachEnabled, Add Get and list for peer express route circuit connections. Remove allowGlobalReach (#5266) * Added GlobalReachEnabled field. Added GET and List apis for peer express route circuit connections. Removed AllowGlobalReach as it was a dead field and abandoned in favor for GlobalReachEnabled * adding allow gloabl reach back * fixed typo * Fix descriptions & remove unused/duplicate definitions (#5243) * Add support for Local Sku (#5317) * Add WAF as a top level resource (#5341) * Add WAF as a top level resource * Fix merge * Addressed comments * Addressed comments * Code review comments * fix issue for powershell * add health probe log * address the comments * increase Node.js memory * double the memory * print node_options * mistake * pass to docker * FI from master to network-february-release (#5391) * Add mixedreality 2019-02-28 API version to Go SDK (#5271) * Remove ARM gateway Node.js configuration (#5283) * Updates to Scheduled Query Rule swagger (#5175) - making aznsaction paramter optional - removing hidden-link value from tags pu * Fix JavaScript configuration for ARM Private DNS SDK (#5284) * Fix JavaScript configuration for ARM Private DNS SDK * Add quotes * Add private preview API for Azure Image Builder (#5055) * Add private preview API for Azure Image Builder * Review comments - Added list-by-resource-group and list-by-subscription - Added default error response - Removed explicit operation url (implied by async contract) - Adjusted 'delete' response codes to match expectations - Allow patch for tags - Added provider operations API * Review comment: use "nextLink" for paging * Adding readme files for SDK generation * PR: rename 'tags' -> 'artifactTags' for distributor * Add examples, fix minor issues in swagger * Updating Blueprint spec to include resource group tags (#5263) * Add Showback model (#5217) * Add Showback model * fix ShowbackRule.json example * remove "," from line 1709 * Add Put Rule * Fix Scope * Update json with pull request changes * change recurring to enum * chore: Graphservice -> GraphService (#5098) * Enable SSL on custom domains using users certificate or CDN managed certificate (#5276) * Translator Text API V3 (#5230) * Translator Text API V3 * Fix path and override * Fix a typo and few other improvements in descriptions. * Remove after_scripts * Update readme.md * Update readme.md * Update MariaDB api version (#5280) * Adding Swagger and examples for VirtualClusters operation group (#5248) * Adding Swagger file for VirtualClusters operation group, together with examples. * Fixing api version, typos and location in examples. * Adding virtualclusters.json to readme.md * Security - Updating API versions of alerts and pricing types (#5269) * Security - Updating api versions of alerts and pricing types * fix codegen paths for Go SDK * typo: asscociation -> association (#5252) * Fix lintdiff issue (#5299) * fix Go SDK package path for mariadb stable release (#5298) * changes to improve documentation of endpoint health statuses for routing (#5290) * add netapp to Go SDK (#5308) * Update MariaDB default API version to 2018-06-01 (#5302) * new application insignts api version for unified schema in action (#5292) * Added Azure App Configuration event data schema. (#5309) * Added Azure App Configuration event data schema. * Added a few missing pieces. * Prefixed event names with our service prefix 'AppConfiguration'. * Added Microsoft.AppConfiguration to the event grid data-plane readme. * Updated api-version path to '2018-01-01' from '2018-02-01'. * Apim Cache resource + DELETE long running + refactor to align with tooling. (#5260) * api import and service delete long running operation * Bring your own Cache align with spec generated from tooling user and notification align Refactor products and apis * align with spec generated from tooling user and notification align Refactor products and apis validating examples validating examples move all parameters to apimanagement.json Fix reference issue with tagcontract and example DeleteCache. * switch to plural example file names for LIST * bring back updatehostname and updatecertificate * Dev adhybridhealthservice microsoft.ad hybrid health service 2014 01 01 binilkk (#5042) * Fixes for: Issue #1 : #4576 (comment) Typo in the DeltaOperationType Enum. Issue #2 : #4844 (comment) GlobalAdmins list is marked as an object, while it's an array. * Updated the Specification as example for Risky IP Download report. * Added the Result details * Fixed review comments, changed the URI scheme as well as changed get/post methods * Addressing Review Feedback, changing POST call of blobUri -> generateBlobUri * Update UserAssignedIdentities spec in Web (#5288) * Update UserAssignedIdentities spec in Web Microsoft.Web recently added support for UserAssigned managed service identities (in preview), but the swagger spec is incorrect for the identity payload as it follows the old construct of sending an array of identityIds as opposed to the updated spec which instead sends a dictionary object called userAssignedIdentities. Spec + history outlined here: http://sharepoint/sites/AzureUX/Sparta/_layouts/15/WopiFrame2.aspx?sourcedoc=%7b633632B4-02E4-4DE2-92A9-EDCAF9BE73D4%7d&file=ARM%2BMSI.docx&action=default Our swagger contains identityids[] because of previous work to future support UserAssigned identities, but never released the feature in that state, rather we opted to wait for the new spec to be supported and then integrated with that on our end. Our MSI implementation reflects Microsoft.Compute's spec for user assigned. https://github.com/Azure/azure-rest-api-specs/blob/78e1feab142c605839aa3cec23442ca26b8ef04d/specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json * fix linterdiff tool * Add private dns module name for java codegen (#5312) * Update Swagger Files For ManagedInstanceAdministrator (#5095) * Update Swagger Files For ManagedInstanceAdministrator * Fix for double wording * Comments resolved * Bringing consistency between to "ResourceGroup" definition (#5256) * Bringing consistency between this "ResourceGroup" definition and the one in Common. * Fixing broken references * reverted security python readme to pre multi api (#5301) * [Azure Search] Add Search API to data plane Swagger spec (#5315) * [Azure Search] Updating some Swagger descriptions to be more doc-friendly Sometimes we over-describe things, especially "comma-separated lists" in query string parameters. These are modeled as arrays in Swagger, which are already understood to be comma-separated lists. They are modeled as collections in generated code, so they are decidedly not comma-separated lists in that context. So removing this phrase is a win-win. * [Azure Search] Adding some missing readOnly attributes * Adding Search API to the Azure Search data plane spec * [Azure Search] Use regexes to generate code for server-side paging This change introduces some very hacky regexes to customize the generated code for server-side paging of the GET and POST Search APIs. They work by splitting the generated SearchGet and SearchPost operations in two, so that the portion that operates on a URL and request body can be reused. This workaround is necessary because AutoRest lacks flexibility around paging. The current x-ms-pageable implementation doesn't work for us because it doesn't model additional top-level response properties or continuation POST requests (only nextLink/GET). The only other alternative to this approach besides custom code would have been to try to parse the nextLink URL query string to reconstitute parameters to pass to the generated SearchGet and SearchPost operations. This is unacceptable for Azure Search, since it would exclude custom parameters that can't be modeled in Swagger, like personalization IDs for custom ranking. Neither AutoRest nor apparently Open API support modeling arbitrary query string parameters. Ideally we'll find a pattern common to other data plane APIs so we don't have to hack this with regexes for every target language, but it's good enough for now. * [Azure Search] Rename some client properties for consistency * [Azure Search] Make AutocompleteMode non-nullable * [Hub Generated] Review request for Microsoft.Web to add version 2018-02-01 (#5137) * Add Hosting Environment network dependencies * Address PR description feedback * Add Network Dependencies examples * Fix casing * Remove incorrect pagination from examples. * Add missing MarketplaceOrdering operations to swagger (#5279) * Add missing MarketplaceOrdering operations to swagger * Add examples * Add example files * Apply suggestions from code review Clarify operation descriptions Co-Authored-By: zachraMSFT <zachra@microsoft.com> * Fix Hosting Environment Network Dependencies pagination (#5320) * Add regex validation for ManagedClusterAgentPoolProfile.name (#5324) * Adding instance pools swagger (#5225) * Initializing instance pools swagger and examples - no usages / managed instances get by instance pool * updates to use common resource and sku definitions * Update instance pool swagger with typo fixes * Updates to instance pool swagger and reverting readme.md to exclude instance pools reference * Fix whitespace diff * Making a whitespace change to re-try linter validation * Updates to add list instances pools by subscription and update license type param to use enum which is limited to LicenseIncluded and BasePrice * Enhanced A2ARecoveryPointDetails with "disks" (#5307) * [DiskRP] Adding swagger spec for 09-30-2018 (#5232) * commit for the older swagger version to make the PR easier to look at * Adding the DiskRP 09-30-2018 swagger spec. This includes support for hyperVGeneration, encryptionSettingCollections, diskState, Upload Disks, and Write access * adding the updated readme * updating the examples to use 09-30-2018 * removing extraneous examples * adding a description for the EncryptionSettingsElementand fixing linter issues * [Computer Vision] Add read to CV OCR API. (#5314) * Add read to OCR API. * Add description to OCR related JSON properties. * Mark asyncBatchAnalyze as long running operation. * Update page property. * Revert "Mark asyncBatchAnalyze as long running operation." This reverts commit 51742b3. * added links to limits for application gateway (#5265) * typo: Winodws -> Windows (#5321) * MultiApi EventHub (#5331) * try 2 bootstrapping swagger to .net sdk tools (#5334) * bootstrapping swagger to .net sdk tools * deleting nuget.exe binary. Updating configs to locally restore pacakges. Adding the directory that will be used in restoring packages locally to .gitignore * changing directory * updating feed location to a readonly directory * Azure Search: Resource Manager: Support 'None' Identity type (#5319) * Azure Search: Resource Manager: Support 'None' Identity type * Azure Search: Resource Manager: Adding serice identity creation\removal examples * [ADLA] - Catalog - Add stream path to USqlTableFragment (#5329) * [Hub Generated] Review request for Microsoft.Consumption to add version 2019-01-01 (#5311) * Add GTM scopes for budgets API * Removed the extra period at the end of the statement * fixing stos.proj parameter (#5338) * change flag name from useUnifiedSchema into useCommonAlertSchema per UX requirement (#5323) * Enhanced A2A protection input and response details (#5330) Enhanced A2AEnableProtectionInput & A2AReplicationDetails objects with recoveryAvailabilityZone, recoveryAzureNetworkId, and recoverySubnetName. * [Hub Generated] Review request for Microsoft.ContainerService to add version 2019-02-01 (#5350) * Adds base for updating Microsoft.ContainerService from version preview/2018-08-01-preview to version 2019-02-01 * Updates readme * Updates API version in new specs and examples * [AKS] add availabilityZones to agent pool profile (#5120) * including orchestratorVersion and provisioning state for agent pool (#5156) * including orchestratorVersion and provisioning state for agent pool * fixing the readme.go.md * including enablePodSecurityPoliy properties for managedcluster and updating examples * fixing the example for enablePodSecurityPolicy * including apiServerAuthorizedIPRanges (#5286) * including apiServerAuthorizedIPRanges * support azure network policy * mark the new features as PREVIEW in description (#5310) * mark the new features as PREVIEW * mark vmss as required for az * Azure Event Grid: Add 2019-02-01-preview tags for Ruby and Go readme files (#5349) * Add 2019-02-01-preview tags for Ruby and Go readme files * fix wrong preview subdirectory * Update some descriptions. (#5305) * update description. (#5335) * Added VNet API (#5351) * EventHub : corrected typo (#5360) * corrected typo in uri * removed unused parameters * Add annotations property to trigger (#5332) * EventHub: Revert the NetworkRuleSet (#5363) * Revert "EventHub : corrected typo (#5360)" This reverts commit 1495122. * Revert "Added VNet API (#5351)" This reverts commit f2ab4a8. * Remove the AzureDataLakeStoreCosmosStructuredStreamDataset since it's internal only (#5277) * Removing SDK generation from Travis-CI (#5367) * Microsoft.DataBoxEdge RP: Corrected comments of trigger and extendedinfo APIs, corrected examples (#5322) * Corrected comments of trigger and extendedinfo APIs, corrected examples * Microsoft.DataBoxEdge RP: Have better examples * Corrected parameter description in order API * oad => @azure/oad (#5362) * oad => @azure/oad * oad => @azure/oad * SRP Swagger changes for 2018-11-01 (#5300) * SRP Swagger changes for 2018-11-01 * Address CR comments * Restrict ManagementPolicyRule -> type property to have only values from defined enum * Make ManagementPolicySchema/version an enum string * Remove 'version' property from ManagementPolicy schema * Added List Policies API to SecurityAlerts (#5070) * Added SecurityAlert List API Added List api to: Manged Server + Managed Database Logical Server + Logical Database * FIxed a description this property is for databases+servers * Added missing Database exmaples Added missing examples for database security alert * Added missing description change For Server Security Alerts * Revert "FIxed a description" This reverts commit e01a332. * Revert "Added missing description change" This reverts commit 17aeab7. * Update DatabaseSecurityAlertListByDatabase.json * fixed examples * Update DatabaseSecurityAlertCreateMin.json Deleted wild comma * Update readme.md * Minor fixes Changed tabs to spaces. Added location for servers exmaples. * Removed location removed the location property from examples * graph: improve API coverage on application & service principal (#5181) * [graphrbac]: fix bugs in permission grant apis * fix paging * add missing property * remove pageable * author pagable in the right way * breaking changes over a wrong spec * remove additionalProperties which causes wrong code-gen * add suppressions * use code to surpress * address review feedabck * moev ahead with the established pattern anyway * address review feedbacks * clean up all * update operation id * add one more property per CLI user's ask * Add insights 2019-03-01 package to Go SDK (#5373) * Add insights 2019-03-01 package to Go SDK * move global settings before packages * fix package tag for new API version (#5378) * Remove GZRS and RAGZRS sku from SRP 2018-11-01 because feature slipped. (#5377) * typo: upto -> up to (#5376) * typo: graphrbac/data-plane/Microsoft.GraphRbac/stable/1.6 (#5375) - requied -> required - authorizaed -> authorized - Organizatio -> Organization - Allorganizations -> AllOrganizations - Microsof -> Microsoft - perperties -> prorperties - servie -> service - altenative -> alternative - thubmbprint -> thumbprint * Azure DevOps Pipeline workaround for private repository (#5374) * Fix PolicyInsights code generation issue (#5389) * Add replica creation parameters to Postgres ResourceProvider for SDK (#5379) * Add replica creation parameters to Postgres ResourceProvider for SDK * Add replica creation parameters to Postgres ResourceProvider for SDK * Add replica creation parameters to Postgres ResourceProvider for SDK * Add replica creation parameters to Postgres ResourceProvider for SDK * Add replica creation parameters to Postgres ResourceProvider for SDK * Revert "FI from master to network-february-release (#5391)" (#5393) This reverts commit 8f28f7f.

meetug and others added 6 commits March 7, 2019 15:07

Add WAF as a top level resource

d43197a

Fix merge

39c5589

Addressed comments

536c136

Addressed comments

32d0ec1

Code review comments

da1b42c

fix issue for powershell

81d9866

azhao155 requested a review from MikhailTryakhov as a code owner March 7, 2019 23:11

azhao155 changed the title ~~Yzhao/feature/waf custom rule resource~~ Add WAF as a top level resource Mar 7, 2019

azuresdkci assigned dsgouda Mar 7, 2019

azuresdkci requested a review from dsgouda March 7, 2019 23:12

add health probe log

580eb50

AutorestCI mentioned this pull request Mar 7, 2019

[AutoPR network/resource-manager] Yzhao/feature/waf custom rule resource Azure/azure-sdk-for-ruby#2295

Closed

AutorestCI mentioned this pull request Mar 7, 2019

[AutoPR network/resource-manager] Yzhao/feature/waf custom rule resource Azure/azure-sdk-for-go#4235

Closed

akshaysngupta approved these changes Mar 8, 2019

View reviewed changes

AutorestCI mentioned this pull request Mar 8, 2019

[AutoPR network/resource-manager] Yzhao/feature/waf custom rule resource Azure/azure-sdk-for-java#3068

Merged

anton-evseev suggested changes Mar 8, 2019

View reviewed changes

dsgouda suggested changes Mar 8, 2019

View reviewed changes

address the comments

63d40d9

dsgouda approved these changes Mar 8, 2019

View reviewed changes

sergey-shandar added 5 commits March 11, 2019 10:58

increase Node.js memory

e4fa3c1

double the memory

57f3015

print node_options

e047738

mistake

16501df

pass to docker

496735c

dsgouda closed this Mar 11, 2019

dsgouda reopened this Mar 11, 2019

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR network/resource-manager] Add WAF as a top level resource Azure/azure-sdk-for-ruby#2306

Merged

ravbhatnagar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 11, 2019

dsgouda merged commit 9619481 into Azure:network-february-release Mar 11, 2019

azhao155 mentioned this pull request Mar 11, 2019

Application Gateway WAF top level resource and Custom Rules Azure/azure-powershell#8713

Closed

8 tasks

anton-evseev mentioned this pull request Mar 13, 2019

Network February release #5365

Merged

5 tasks

azhao155 mentioned this pull request Mar 13, 2019

Application Gateway WAF top level resource and Custom Rules (based on February branch) Azure/azure-powershell#8776

Merged

8 tasks

EvgenyAgafonchikov mentioned this pull request Apr 22, 2019

Build release #5717

Merged

5 tasks

nschonni mentioned this pull request May 24, 2019

typo negationConditon in webapplicationfirewall #6104

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add WAF as a top level resource #5341

Add WAF as a top level resource #5341

azhao155 commented Mar 7, 2019 •

edited

Loading

azuresdkci commented Mar 7, 2019

AutorestCI commented Mar 7, 2019 •

edited

Loading

AutorestCI commented Mar 7, 2019 •

edited

Loading

azhao155 commented Mar 7, 2019

AutorestCI commented Mar 7, 2019 •

edited

Loading

AutorestCI commented Mar 7, 2019 •

edited

Loading

AutorestCI commented Mar 7, 2019 •

edited

Loading

AutorestCI commented Mar 8, 2019 •

edited

Loading

anton-evseev left a comment

anton-evseev Mar 8, 2019

azhao155 Mar 8, 2019

azhao155 Mar 8, 2019

anton-evseev Mar 8, 2019

azhao155 Mar 8, 2019

anton-evseev Mar 8, 2019

azhao155 Mar 8, 2019

anton-evseev Mar 8, 2019

azhao155 Mar 8, 2019

dsgouda Mar 8, 2019

dsgouda Mar 8, 2019

azhao155 Mar 8, 2019

dsgouda Mar 8, 2019

azhao155 Mar 8, 2019

MikhailTryakhov commented Mar 8, 2019

azhao155 commented Mar 8, 2019

dsgouda left a comment

azhao155 commented Mar 8, 2019

azhao155 commented Mar 8, 2019

dsgouda commented Mar 8, 2019

azhao155 commented Mar 11, 2019

dsgouda commented Mar 11, 2019

azhao155 commented Mar 11, 2019

Add WAF as a top level resource #5341

Add WAF as a top level resource #5341

Conversation

azhao155 commented Mar 7, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azuresdkci commented Mar 7, 2019

AutorestCI commented Mar 7, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 7, 2019 • edited Loading

Automation for azure-sdk-for-js

azhao155 commented Mar 7, 2019

AutorestCI commented Mar 7, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Mar 7, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Mar 7, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Mar 8, 2019 • edited Loading

Automation for azure-sdk-for-java

anton-evseev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikhailTryakhov commented Mar 8, 2019

azhao155 commented Mar 8, 2019

dsgouda left a comment

Choose a reason for hiding this comment

azhao155 commented Mar 8, 2019

azhao155 commented Mar 8, 2019

dsgouda commented Mar 8, 2019

azhao155 commented Mar 11, 2019

dsgouda commented Mar 11, 2019

azhao155 commented Mar 11, 2019

azhao155 commented Mar 7, 2019 •

edited

Loading

AutorestCI commented Mar 7, 2019 •

edited

Loading

AutorestCI commented Mar 7, 2019 •

edited

Loading

AutorestCI commented Mar 7, 2019 •

edited

Loading

AutorestCI commented Mar 7, 2019 •

edited

Loading

AutorestCI commented Mar 7, 2019 •

edited

Loading

AutorestCI commented Mar 8, 2019 •

edited

Loading