Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Create HanaInstance API #5945

Merged
merged 6 commits into from
May 23, 2019

Conversation

lagalbra
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

lagalbra added 3 commits May 14, 2019 08:58
Amend HanaInstanceProperties to include fields required for new API behavior
Add example file for HanaInstances_Set
Update example files with amended HanaInstanceProperties
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lagalbra lagalbra changed the title Lagalbra/add hanainstance set api Add Create HanaInstance API May 14, 2019
@AutorestCI
Copy link

AutorestCI commented May 14, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented May 14, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5459

@AutorestCI
Copy link

AutorestCI commented May 14, 2019

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3167

@AutorestCI
Copy link

AutorestCI commented May 14, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4834

@kpajdzik kpajdzik added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 14, 2019
@AutorestCI
Copy link

AutorestCI commented May 14, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpxnjgt8t3/rest/specification/hanaonazure/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpyijdostc']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI added a commit to Azure/azure-sdk-for-js that referenced this pull request May 15, 2019
Microsoft.HanaOnAzure: Add Delete HanaInstance API

Add example file for the new API
Note: if this PR is merged after Azure/azure-rest-api-specs#5945 a provisioning state of 'deleting' should be displayed in the example
AutorestCI added a commit to Azure/azure-sdk-for-go that referenced this pull request May 15, 2019
Microsoft.HanaOnAzure: Add Delete HanaInstance API

Add example file for the new API
Note: if this PR is merged after Azure/azure-rest-api-specs#5945 a provisioning state of 'deleting' should be displayed in the example
AutorestCI added a commit to Azure/azure-sdk-for-python that referenced this pull request May 15, 2019
Microsoft.HanaOnAzure: Add Delete HanaInstance API

Add example file for the new API
Note: if this PR is merged after Azure/azure-rest-api-specs#5945 a provisioning state of 'deleting' should be displayed in the example
AutorestCI added a commit to Azure/azure-sdk-for-java that referenced this pull request May 16, 2019
Microsoft.HanaOnAzure: Add Delete HanaInstance API

Add example file for the new API
Note: if this PR is merged after Azure/azure-rest-api-specs#5945 a provisioning state of 'deleting' should be displayed in the example
@lagalbra
Copy link
Contributor Author

As noted in #5976, I have marked this API as asynchronous.

@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 19, 2019
@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 23, 2019
@ravbhatnagar
Copy link
Contributor

Signing off frm ARM side.

@kpajdzik kpajdzik merged commit ca3a2ed into Azure:master May 23, 2019
@lagalbra lagalbra deleted the lagalbra/add-hanainstance-set-api branch May 23, 2019 21:56
lagalbra added a commit to lagalbra/azure-rest-api-specs that referenced this pull request May 23, 2019
Add example file for the new API
Note: if this PR is merged after Azure#5945 a provisioning state of 'deleting' should be displayed in the example
jhendrixMSFT pushed a commit that referenced this pull request May 29, 2019
* Microsoft.HanaOnAzure: Add Delete HanaInstance API

Add example file for the new API
Note: if this PR is merged after #5945 a provisioning state of 'deleting' should be displayed in the example

* Mark as async; correct status code to Accepted; update and validate examples

* Support 204 when there is no HanaInstance to delete

* Remove response body from DeleteHanaInstance

* Fix issues with rebasing conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants