Microsoft.HanaOnAzure: Remove readOnly attribute from customer-provided properties in CreateHanaInstance #6256

lagalbra · 2019-06-06T23:56:11Z

After completing #5945, I discovered I could not update our CLI extension to call the Create HanaInstance API as expected as some properties were marked as read-only in the Swagger. This PR resolves this.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…ed properties in CreateHanaInstance

openapi-sdkautomation · 2019-06-06T23:56:13Z

SDK Automation [Logs] (Generated from e3d3034)

Python: Azure/azure-sdk-for-python [Logs] [Diff]

sdk/hanaonazure/azure-mgmt-hanaonazure [Logs] [Instructions]
- azure-mgmt-hanaonazure-0.6.0.zip
- azure_mgmt_hanaonazure-0.6.0-py2.py3-none-any.whl

Java: Azure/azure-sdk-for-java [Logs] [Diff]

hanaonazure/resource-manager/v2017_11_03_preview [Logs] [Instructions]

Go: Azure/azure-sdk-for-go [Logs] [Diff]

preview/hanaonazure/mgmt/2017-11-03-preview [Logs] [Instructions]
- preview.hanaonazure.mgmt.2017-11-03-preview.zip

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@azure/arm-hanaonazure [Logs] [Instructions]
- azure-arm-hanaonazure-2.0.0.tgz

AutorestCI · 2019-06-06T23:57:03Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 7666da58047728a2b1872ae8f6b74bdabc2a0f4d
  stderr: 'fatal: reference is not a tree: 7666da58047728a2b1872ae8f6b74bdabc2a0f4d'

AutorestCI · 2019-06-06T23:57:07Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 7666da58047728a2b1872ae8f6b74bdabc2a0f4d
  stderr: 'fatal: reference is not a tree: 7666da58047728a2b1872ae8f6b74bdabc2a0f4d'

AutorestCI · 2019-06-06T23:57:09Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 7666da58047728a2b1872ae8f6b74bdabc2a0f4d
  stderr: 'fatal: reference is not a tree: 7666da58047728a2b1872ae8f6b74bdabc2a0f4d'

AutorestCI · 2019-06-06T23:57:37Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 7666da58047728a2b1872ae8f6b74bdabc2a0f4d
  stderr: 'fatal: reference is not a tree: 7666da58047728a2b1872ae8f6b74bdabc2a0f4d'

AutorestCI · 2019-06-06T23:58:39Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 7666da58047728a2b1872ae8f6b74bdabc2a0f4d
  stderr: 'fatal: reference is not a tree: 7666da58047728a2b1872ae8f6b74bdabc2a0f4d'

lagalbra · 2019-06-07T00:22:54Z

See #6259 - this is the most recent copy

* AvailabilitySet swagger changes and examples * Using struct for avSet props. * Updated availability set from array to object * Changing object to array of objects for vm * Checkpoint swagger changes * Updating the examples * Fixing prettier check * Prettier fix 1 * Adhering to ARM naming convention * Adding identifier id i the array item * VM patch response and fix for lint diff * JSON format error fix * Model validation fix * Prettier Check Fix * Adding availability set in vm patch * Defined availability set object for vm props

Microsoft.HanaOnAzure: Remove readOnly attribute from customer-provid…

c6f1ccd

…ed properties in CreateHanaInstance

AutorestCI mentioned this pull request Jun 6, 2019

[AutoPR hanaonazure/resource-manager] Microsoft.HanaOnAzure: Remove readOnly attribute from customer-provided properties in CreateHanaInstance Azure/azure-sdk-for-python#5736

Closed

AutorestCI mentioned this pull request Jun 6, 2019

[AutoPR hanaonazure/resource-manager] Microsoft.HanaOnAzure: Remove readOnly attribute from customer-provided properties in CreateHanaInstance Azure/azure-sdk-for-js#3557

Closed

AutorestCI mentioned this pull request Jun 6, 2019

[AutoPR hanaonazure/resource-manager] Microsoft.HanaOnAzure: Remove readOnly attribute from customer-provided properties in CreateHanaInstance Azure/azure-sdk-for-go#4973

Closed

azuresdkci assigned jhendrixMSFT Jun 7, 2019

azuresdkci requested a review from jhendrixMSFT June 7, 2019 00:18

Mark remaining required properties as not read-only

e3d3034

lagalbra closed this Jun 7, 2019

lagalbra reopened this Jun 7, 2019

lagalbra closed this Jun 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsoft.HanaOnAzure: Remove readOnly attribute from customer-provided properties in CreateHanaInstance #6256

Microsoft.HanaOnAzure: Remove readOnly attribute from customer-provided properties in CreateHanaInstance #6256

lagalbra commented Jun 6, 2019

openapi-sdkautomation bot commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

lagalbra commented Jun 7, 2019

Microsoft.HanaOnAzure: Remove readOnly attribute from customer-provided properties in CreateHanaInstance #6256

Microsoft.HanaOnAzure: Remove readOnly attribute from customer-provided properties in CreateHanaInstance #6256

Conversation

lagalbra commented Jun 6, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 6, 2019 • edited Loading

SDK Automation [Logs] (Generated from e3d3034)

AutorestCI commented Jun 6, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 6, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 6, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jun 6, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 6, 2019 • edited Loading

Automation for azure-sdk-for-go

lagalbra commented Jun 7, 2019

openapi-sdkautomation bot commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading