-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blueprints] Add a new example file for using user-assigned MSI #6297
Conversation
SDK Automation [Logs] (Generated from 4a0ddd1)Go: Azure/azure-sdk-for-go
JavaScript: Azure/azure-sdk-for-js
Python: Azure/azure-sdk-for-python
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: dep ensure grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export golang.org/x/sync: failed to fetch source for https://go.googlesource.com/sync: unable to get repository: Cloning into '/tmp/tmprh1ofsfv/pkg/dep/sources/https---go.googlesource.com-sync'...
fatal: unable to access 'https://go.googlesource.com/sync/': The requested URL returned error: 502
: command failed: [git clone --recursive -v --progress https://go.googlesource.com/sync /tmp/tmprh1ofsfv/pkg/dep/sources/https---go.googlesource.com-sync]: exit status 128 |
@shahabhijeet I looked at the failing jobs. We had the same failures in our previous PR and they were suppressed and the PR was merged. You can find it here: #5872. These failures are specifically around the ParameterValueBase property and its polymorphic relation to ParameterValue. It seems like the model validation tool is not seeing this relationship and complaining that the "value" parameter in the request examples are not complaint. What would be a recommended way to solve this issue? Please let me know if we can also suppress these failures for this PR. I can create a separate PR to fix the above mentioned issue that causes some of the checks to fail. |
@sergey-shandar can you comment on the above comment about model validation "potentially" showing false negatives. |
@filizt In OpenAPI 2.0 if |
@sergey-shandar I am not sure if I understand how "additionalProperties" will fix the issue here. Adding @majastrz to help explain the issue a bit more. |
@sergey-shandar, we're basically looking for the best way to model the following JSON:
The parameter value should either be have a |
@shahabhijeet Can we suppress the checks and merge the changes? We would not want to hold the PR since the issue discussed here is not new and is not caused by the change in this PR. I can create a separate item in the repo's "Issues" section to discuss this issue in detail. Let me know if you want me to go ahead and create a new issue. |
@sergey-shandar will be the right person who can answer the question about supression. |
@majastrz for OpenAPI 2.0 it is the way. Create a type that has two optional properties. Open-API 3.0 should support |
Fix for OAV tracked in Azure/oav#431 |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.