Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blueprints] Add published blueprint object to the payload to support change notes #6399

Merged
merged 1 commit into from
Jun 25, 2019
Merged

[Blueprints] Add published blueprint object to the payload to support change notes #6399

merged 1 commit into from
Jun 25, 2019

Conversation

filizt
Copy link
Contributor

@filizt filizt commented Jun 20, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 202b235)

Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5992

@AutorestCI AutorestCI mentioned this pull request Jun 20, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jun 20, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5098

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

erich-wang
erich-wang suggested changes Jun 21, 2019
View reviewed changes
Copy link
Member

@erich-wang erich-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filizt , please make sure all checks are passed, thanks.

@filizt
Copy link
Contributor Author

filizt commented Jun 21, 2019 •
edited
Loading

@filizt , please make sure all checks are passed, thanks.

The model validation failures in the checks are caused by a tooling issue here: Azure/oav#431. We had an another PR earlier this week that had the same failures but then they were suppressed and PR was merged since the failures were also due to the tooling issue. See here: #6297

Could you help suppress the failures and merge the PR?

majastrz
majastrz reviewed Jun 21, 2019
View reviewed changes
...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/blueprintDefinition.json
"schema": {
"$ref": "#/definitions/PublishedBlueprint"
},
"description": "Published Blueprint to create or update."
}
Copy link
Member

@majastrz majastrz Jun 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for other reviewers:
The blueprint backend has always supported this and it was always optional. So SDKs generated from swaggers with and without this change will work just fine. #ByDesign

majastrz
majastrz approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from ARM side.

@majastrz majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 21, 2019
@filizt
Copy link
Contributor Author

filizt commented Jun 24, 2019

@erich-wang could you review the PR please?

erich-wang
erich-wang approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@erich-wang erich-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve the change since the check failure is caused by tool bug.

@erich-wang
Copy link
Member

@sergey-shandar, the check failure is caused by a bug in ova, please merge this PR, thanks.

@sergey-shandar sergey-shandar merged commit 5bc9786 into Azure:master Jun 25, 2019
@filizt filizt mentioned this pull request Jul 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erich-wang erich-wang erich-wang approved these changes

@majastrz majastrz majastrz approved these changes

Assignees

@erich-wang erich-wang

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@filizt @AutorestCI @azuresdkci @erich-wang @majastrz @sergey-shandar