-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSIS File System Support #6548
SSIS File System Support #6548
Conversation
SDK Automation [Logs] (Generated from 29f3be5)Python: Azure/azure-sdk-for-python [Logs]
Java: Azure/azure-sdk-for-java [Logs]
Go: Azure/azure-sdk-for-go [Logs]
JavaScript: Azure/azure-sdk-for-js [Logs]
|
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
.../resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Pipeline.json
Show resolved
Hide resolved
This is heavily modifying the schema of this resource and will cause issues with clients that would be mix of new and old SDKs. Refers to: specification/datafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Pipeline.json:1999 in 29f3be5. [](commit_id = 29f3be5, deletion_comment = False) |
Ensure to add/update examples |
also I just couldn't find CRUD api for this resource in the repo.. In reply to: 508885125 [](ancestors = 508885125) Refers to: specification/datafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Pipeline.json:1999 in 29f3be5. [](commit_id = 29f3be5, deletion_comment = False) |
@@ -2156,6 +2195,72 @@ | |||
"password" | |||
] | |||
}, | |||
"SSISAccessCredential": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSISAccessCredential [](start = 5, length = 20)
This must be excluded in GET calls.. to avoid revealing secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the actual resource requires different schema for GET
In reply to: 300815583 [](ancestors = 300815583)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have GET calls on the resource.
@sanjaiganesh, we don't have CRUD apis (and examples) on individual activities, they are always included in a pipeline. Moreover, shall I remove my change in 2017-09-01-preview version and only keep it in 2018-06-01? |
@haoqian@microsoft.com Didn't follow. Could you please explain how are these resources created ?.. both are existing api versions . so SDK issues concern apply equally to both. In reply to: 509058430 [](ancestors = 509058430) |
@sanjaiganesh , activity is not a standalone resource. It's a sub resource of pipeline. When creating the pipeline resource, the activity resources in the pipeline are created. Activity resources can't be created directly. Moreover, we don't introduce any breaking change here. We only add more properties which are optional. The existing payloads always work. We don't need to create a new api-version. |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.