Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSIS File System Support #6548

Merged
merged 1 commit into from
Jul 17, 2019
Merged

SSIS File System Support #6548

merged 1 commit into from
Jul 17, 2019

Conversation

HaoQian-MS
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 3, 2019

SDK Automation [Logs] (Generated from 29f3be5)

Failed Python: Azure/azure-sdk-for-python [Logs]
  • No packages generated.
In-Progress Java: Azure/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: Azure/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: Azure/azure-sdk-for-js [Logs]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Jul 3, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5747

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jul 3, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5269

@AutorestCI
Copy link

AutorestCI commented Jul 3, 2019

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3084

@jhendrixMSFT jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 3, 2019
@sanjaiganesh
Copy link
Contributor

"ExecuteSSISPackageActivity": {

This is heavily modifying the schema of this resource and will cause issues with clients that would be mix of new and old SDKs.
pls introduce them under new api version.


Refers to: specification/datafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Pipeline.json:1999 in 29f3be5. [](commit_id = 29f3be5, deletion_comment = False)

@sanjaiganesh sanjaiganesh added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 6, 2019
@sanjaiganesh
Copy link
Contributor

Ensure to add/update examples

@sanjaiganesh
Copy link
Contributor

"ExecuteSSISPackageActivity": {

also I just couldn't find CRUD api for this resource in the repo..


In reply to: 508885125 [](ancestors = 508885125)


Refers to: specification/datafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Pipeline.json:1999 in 29f3be5. [](commit_id = 29f3be5, deletion_comment = False)

@@ -2156,6 +2195,72 @@
"password"
]
},
"SSISAccessCredential": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSISAccessCredential [](start = 5, length = 20)

This must be excluded in GET calls.. to avoid revealing secrets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the actual resource requires different schema for GET


In reply to: 300815583 [](ancestors = 300815583)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have GET calls on the resource.

@HaoQian-MS
Copy link
Contributor Author

@sanjaiganesh, we don't have CRUD apis (and examples) on individual activities, they are always included in a pipeline. Moreover, shall I remove my change in 2017-09-01-preview version and only keep it in 2018-06-01?

@sanjaiganesh
Copy link
Contributor

@haoqian@microsoft.com Didn't follow. Could you please explain how are these resources created ?.. both are existing api versions . so SDK issues concern apply equally to both.


In reply to: 509058430 [](ancestors = 509058430)

@HaoQian-MS
Copy link
Contributor Author

@sanjaiganesh , activity is not a standalone resource. It's a sub resource of pipeline. When creating the pipeline resource, the activity resources in the pipeline are created. Activity resources can't be created directly. Moreover, we don't introduce any breaking change here. We only add more properties which are optional. The existing payloads always work. We don't need to create a new api-version.

@sanjaiganesh sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants