Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoPR] datafactory/resource-manager #5747

Closed
wants to merge 21 commits into from
Closed

[AutoPR] datafactory/resource-manager #5747

wants to merge 21 commits into from

Conversation

AutorestCI
Copy link
Contributor

Created to accumulate context: datafactory/resource-manager

@AutorestCI AutorestCI requested a review from hvermis as a code owner June 7, 2019 15:58
This was referenced Jun 7, 2019
Merged
Merged
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jun 7, 2019 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-datafactory

You can install the package azure-mgmt-datafactory of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_datafactory/resource-manager#egg=azure-mgmt-datafactory&subdirectory=azure-mgmt-datafactory"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_datafactory/resource-manager#egg=azure-mgmt-datafactory&subdirectory=azure-mgmt-datafactory"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_datafactory/resource-manager
  • pip install -e ./azure-mgmt-datafactory

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_datafactory/resource-manager
  • pip wheel --no-deps ./azure-mgmt-datafactory

Direct download

Your files can be directly downloaded here:

This was referenced Jun 11, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Jun 19, 2019
Closed
Merged
Merged
Closed
Closed
This was referenced Jun 26, 2019
Merged
Merged
This was referenced Jul 5, 2019
Closed
Merged
Closed
Merged
Merged
Merged
This was referenced Jul 15, 2019
Merged
Merged
Merged
Merged
Merged
Merged
@AutorestCI AutorestCI mentioned this pull request Jul 23, 2019
Merged
@AutorestCI
[AutoPR datafactory/resource-manager] [DataFactory]SapBwCube and Syba…
9379260 
…se Dataset (#6518)

* Generated from b88af2e2b065a6ff559d879d690d65096d1bb56f

[DataFactory]SapBwCube and Sybase Dataset

* Generated from b88af2e2b065a6ff559d879d690d65096d1bb56f

[DataFactory]SapBwCube and Sybase Dataset
@AutorestCI
[AutoPR datafactory/resource-manager] Enable Avro Dataset in public s…
f5d3db0 
…wagger (#6567)

* Generated from ec112148bf30430557ff3fac0c74f0706b1042de

Enable Avro Dataset in public swagger

* Generated from e41431428e45beaa5bbb12344d3332479c095e31

UPDATE
@AutorestCI
Generated from ccc8c92e96ab27329cf637c7214ebb35da8dce23 (#6625)
64a07f2 
Fix model validation
@zikalino zikalino force-pushed the restapi_auto_datafactory/resource-manager branch from 982c56d to 64a07f2 Compare August 6, 2019 22:33
hvermis
hvermis reviewed Aug 6, 2019
View reviewed changes
sdk/datafactory/azure-mgmt-datafactory/HISTORY.rst

**Breaking changes**

- Operation PipelinesOperations.create_run has a new signature
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate rows

hvermis
hvermis reviewed Aug 6, 2019
View reviewed changes
sdk/datafactory/azure-mgmt-datafactory/azure/mgmt/datafactory/models/tabular_translator.py
@@ -1,51 +0,0 @@
# coding=utf-8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file gets removed due to Autorest bug - it is treated as not used, but in fact our customers need it. Please do not remove it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will check this.

hvermis
hvermis reviewed Aug 6, 2019
View reviewed changes
sdk/datafactory/azure-mgmt-datafactory/azure/mgmt/datafactory/models/tabular_translator_py3.py
@@ -1,51 +0,0 @@
# coding=utf-8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

hvermis
hvermis reviewed Aug 6, 2019
View reviewed changes
sdk/datafactory/azure-mgmt-datafactory/HISTORY.rst
@@ -3,6 +3,156 @@
Release History
===============

0.8.0 (2019-08-07)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given there are SDK breaking changes in this release, shouldn't the major version change?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily (https://github.com/Azure/azure-sdk-for-python/blob/master/doc/dev/mgmt/mgmt_release.md - pls check bottom of the page).
0.7.0 also had breaking changes.
Unless you want to specifically change to 1.0.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, let's re;ease with 0.8.0. Thanks!

This was referenced Aug 7, 2019
Merged
Merged
Closed
Merged
Merged
Merged
@AutorestCI AutorestCI mentioned this pull request Aug 14, 2019
Merged
@AutorestCI AutorestCI mentioned this pull request Aug 14, 2019
Merged
@hvermis
Copy link
Contributor

hvermis commented Aug 14, 2019

@zikalino Something went wrong - why are all these files getting deleted?

@AutorestCI AutorestCI mentioned this pull request Aug 15, 2019
Merged
5 tasks
This was referenced Aug 15, 2019
Merged
Merged
Merged
Closed
@zikalino zikalino closed this Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvermis hvermis hvermis approved these changes

@zikalino zikalino Awaiting requested review from zikalino

Assignees
No one assigned
Labels
ServicePR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AutorestCI @hvermis @zikalino