Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datafactory] Add three new connectors #6578

Merged
merged 2 commits into from
Jul 11, 2019
Merged

[Datafactory] Add three new connectors #6578

merged 2 commits into from
Jul 11, 2019

Conversation

davidzhaoyue
Copy link
Contributor

@davidzhaoyue davidzhaoyue commented Jul 10, 2019 •
edited
Loading

  1. Azure SQL Database Managed Instance
  2. Dynamics CRM
  3. Common Data Service for Apps

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 10, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from e164e42, Iteration 4)

Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
In-Progress Java: Azure/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: Azure/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: Azure/azure-sdk-for-js [Logs]
  • Package generation in progress.

@azuresdkci azuresdkci requested a review from kpajdzik July 10, 2019 08:22
@AutorestCI AutorestCI mentioned this pull request Jul 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI AutorestCI mentioned this pull request Jul 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5189

@AutorestCI AutorestCI mentioned this pull request Jul 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3084

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@kpajdzik kpajdzik added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 10, 2019
ryansbenson
ryansbenson approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 10, 2019
@kpajdzik kpajdzik merged commit 808cfe2 into Azure:master Jul 11, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@davidzhaoyue @celikcigdem
[Datafactory] Add three new connectors (Azure#6578)
5fc89b1 
* [Datafactory] Add Azure SQL Database Managed Instance, Dynamics CRM and Common Data Service for Apps

* Change enum type to string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpajdzik kpajdzik kpajdzik approved these changes

@ryansbenson ryansbenson ryansbenson approved these changes

Assignees

@kpajdzik kpajdzik

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidzhaoyue @AutorestCI @azuresdkci @kpajdzik @ryansbenson