-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataFactory]Add AzurePostgreSql Sink and Oracle/SapTable/Netezza Partitions and Several Relational sets #6617
Conversation
…titoins and dedicated datasets for relational
The local SDK building and testing looks good. Details can be referred from https://github.com/wenbof/azure-sdk-for-net/tree/b0715 |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Can one of the admins verify this patch? |
SDK Automation [Logs] (Generated from 7f632e8, Iteration 4)Python: Azure/azure-sdk-for-python [Logs] [Diff]
Java: Azure/azure-sdk-for-java [Logs]
Go: Azure/azure-sdk-for-go [Logs]
JavaScript: Azure/azure-sdk-for-js [Logs]
|
@praries880 Ping... could you please review? thanks. |
@KrisBash can you kindly review this? |
I executed AUTOREST locally while it seems there is no error. the targeted line 1489:4, 1472:4 looks good as well. I also built local SDK which can be built successfully. if there are any changes needed from my side, could you please advise? thanks Line 1472 "SybaseTableDataset": { |
@hvermis , @praries880 , @KrisBash Ping... could you please kindly review and merge? thanks. |
@KrisBash Waiting for you review to unblock our SDK release, please help. |
...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
Outdated
Show resolved
Hide resolved
...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
Show resolved
Hide resolved
...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…titoins and dedicated datasets for relational
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.