Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - [DataFactory]Add json dataset support in ADF #6915

Merged
merged 2 commits into from
Aug 15, 2019
Merged

PR - [DataFactory]Add json dataset support in ADF #6915

merged 2 commits into from
Aug 15, 2019

Conversation

shawnxzq
Copy link
Member

@shawnxzq shawnxzq commented Aug 9, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5507

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@erich-wang erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 9, 2019
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as #6739

@ryansbenson ryansbenson added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review potential-sdk-breaking-change labels Aug 9, 2019
@shawnxzq shawnxzq changed the title PR - Add json dataset support in ADF PR - Add json dataset support in ADF [Don't merge] Aug 13, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2019

In Testing, Please Ignore

[Logs] (Generated from d4f7403, Iteration 4)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Warning datafactory/resource-manager/v2017_09_01_preview [Logs]
  • Failed datafactory/resource-manager/v2018_06_01 [Logs]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@shawnxzq shawnxzq changed the title PR - Add json dataset support in ADF [Don't merge] PR - Add json dataset support in ADF [Don't Merge] Aug 13, 2019
@ravbhatnagar
Copy link
Contributor

As discussed in the in person meeting, this is a breaking change as per the current Microsoft REST API guideline for Azure. The scenario is understood on why its not feasible for service team to keep reving the api-version for every such change.
This needs to be closed with MarkRuss and JohnGos. GauravBh will provide a write up for review and use ADF as a use case.
For now, signing off on this from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 14, 2019
@shawnxzq shawnxzq changed the title PR - Add json dataset support in ADF [Don't Merge] PR - [DataFactory]Add json dataset support in ADF [Don't Merge] Aug 14, 2019
@yungezz yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 14, 2019
@shawnxzq shawnxzq changed the title PR - [DataFactory]Add json dataset support in ADF [Don't Merge] PR - [DataFactory]Add json dataset support in ADF Aug 15, 2019
@yungezz yungezz removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 15, 2019
@erich-wang erich-wang merged commit 3df6932 into Azure:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants