Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Subscription to add version preview/2018-11-01-preview #7352

Merged
merged 5 commits into from
Oct 8, 2019
Merged

[Hub Generated] Review request for Microsoft.Subscription to add version preview/2018-11-01-preview #7352

merged 5 commits into from
Oct 8, 2019

Conversation

sriramvu
Copy link
Contributor

@sriramvu sriramvu commented Sep 27, 2019 •
edited by H-Huang
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 27, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 12cf92b, Iteration 4)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress preview/subscription/mgmt/2017-11-01-preview [Logs]
  • In-Progress preview/subscription/mgmt/2018-03-01-preview [Logs]
Failed Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • Failed azure-mgmt-subscription [Logs]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Sep 27, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 27, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7684

@AutorestCI
Copy link

AutorestCI commented Sep 27, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 27, 2019
Merged
@erich-wang erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 29, 2019
@ryansbenson ryansbenson added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 30, 2019
@sriramvu
Copy link
Contributor Author

sriramvu commented Oct 3, 2019

@ryansbenson - can you please review the change.

@sriramvu sriramvu removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 4, 2019
@sriramvu
Copy link
Contributor Author

sriramvu commented Oct 7, 2019

@ryansbenson / @erich-wang : can you please review the changes.

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 7, 2019
ryansbenson
ryansbenson reviewed Oct 7, 2019
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@erich-wang erich-wang merged commit 8a09f94 into Azure:master Oct 8, 2019
@AutorestCI AutorestCI mentioned this pull request Oct 8, 2019
Merged
@sriramvu sriramvu mentioned this pull request Oct 17, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansbenson ryansbenson ryansbenson left review comments

@erich-wang erich-wang erich-wang approved these changes

Assignees

@erich-wang erich-wang

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sriramvu @azuresdkci @AutorestCI @erich-wang @ryansbenson