Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Subscription: Removed an unused API to make things simple, also corrected examples #7540

Conversation

sriramvu
Copy link
Contributor

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@sriramvu sriramvu requested review from navysingla and removed request for xseeseesee October 17, 2019 17:21
@AutorestCI
Copy link

AutorestCI commented Oct 17, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmplg_7b9cz/rest/specification/subscription/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp0xonvvez']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@AutorestCI
Copy link

AutorestCI commented Oct 17, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@sriramvu sriramvu changed the title [Hub Generated] Review request for Microsoft.Subscription to add version preview/2018-11-01-preview [Hub Generated] Review request for Microsoft.Subscription: Removed an unused API to make things simple, also corrected examples Oct 17, 2019
@sriramvu
Copy link
Contributor Author

We have introduced the removed API as part of PR #7352 (around week back).
There are 2 routes to create WebDirect / EA subscription - sticking with the one latest for simplicity.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sriramvu
Copy link
Contributor Author

"public.rest-api-specs In progress — This check has started..." > running for last 5.5 hours.
Corresponding Azure pipeline details show completed (https://dev.azure.com/azure-sdk/public/_build/results?buildId=154250&view=results)

Making minor change to rerun the checks as public.rest-api-specs check is reporting as running for more than a day when it has actually got completed.
@sriramvu
Copy link
Contributor Author

@xccc-msft can you please review and merge the PR.

@xseeseesee xseeseesee added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 22, 2019
@sriramvu
Copy link
Contributor Author

@arm review team - can one of you please review the changes?
@xccc-msft - tried pinging ARM OnCall for this couple of days back. What is the approach we are supposed to take? It's been 11 days PR opened and 7 days on WaitForARMFeedback - please suggest.

@xseeseesee
Copy link
Contributor

@sriramvu I dropped message with this PR to ARM reviewers.

@pilor pilor added ARMReviewInProgress and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 31, 2019
@pilor pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 31, 2019
Copy link
Contributor

@pilor pilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actual API changes in this PR

@sriramvu
Copy link
Contributor Author

@xccc-msft - can you please merge the changes.

@xseeseesee xseeseesee merged commit c153b68 into Azure:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants