Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Subscription: Removed an unused API to make things simple, also corrected examples #7540

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"parameters": {
"billingAccountName": "cd3ae1d5-9cb9-5950-9ffc-bc522547dbad:34756dd9-25b9-40c6-bc85-c25f68bff94f_2018-09-30",
"customerName": "0ec9a816-e305-4571-8963-32db796dc43d",
"billingAccountName": "2bc54a6f-8d8a-5be1-5bff-bb4f285f512b:11a72812-d9a4-446e-9a1e-70c8bcadf5c0_2019-05-31",
"customerName": "e33ba30d-3718-4b15-bfaa-5627a57cda6f",
"api-version": "2018-11-01-preview",
"body": {
"displayName": "Contoso MCA subscription",
Expand All @@ -11,7 +11,7 @@
"responses": {
"202": {
"headers": {
"Location": "/providers/Microsoft.Subscription/subscriptionOperations/aeb76128-ebde-4f5a-a9ed-e7bbf2dbc994?api-version=2018-11-01-preview",
"Location": "https://management.azure.com/providers/Microsoft.Subscription/subscriptionOperations/MzcwYzI3MDItNjA1MC00NTZkLTgyMTgtZjM0NDcyMjkwMTY0?api-version=2018-03-01-preview",
"Retry-After": 8
}
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
{
"parameters": {
"billingAccountName": "12a6eed9-5d39-4103-a5db-2db1db0a8c67",
"invoiceSectionName": "b859d705-1ed7-4769-9d4b-19238e9e8ac2_10_31",
"billingAccountName": "0aa27f2b-ec7f-5a65-71f6-a5ff0897bd55:ae0dae1e-de9a-41f6-8257-76b055d98372_2019-05-31",
"billingProfileName": "27VR-HDWX-BG7-TGB",
"invoiceSectionName": "JGF7-NSBG-PJA-TGB",
"api-version": "2018-11-01-preview",
"body": {
"displayName": "Contoso MCA subscription",
"billingProfileId": "/providers/Microsoft.Billing/billingAccounts/12a6eed9-5d39-4103-a5db-2db1db0a8c67/billingProfiles/dbcb81c8-cda9-4b01-b9fc-831e6a2e152e",
"billingProfileId": "/providers/Microsoft.Billing/billingAccounts/0aa27f2b-ec7f-5a65-71f6-a5ff0897bd55:ae0dae1e-de9a-41f6-8257-76b055d98372_2019-05-31/billingProfiles/27VR-HDWX-BG7-TGB",
"skuId": "0001",
"costCenter": "135366376",
"owner": {
"objectId": "973034ff-acb7-409c-b731-e789672c7b31"
"objectId": "973034ff-acb7-409c-b731-e789672c7b32"
}
}
},
"responses": {
"202": {
"headers": {
"Location": "/providers/Microsoft.Subscription/subscriptionOperations/aeb76128-ebde-4f5a-a9ed-e7bbf2dbc994?api-version=2018-11-01-preview",
"Location": "https://management.azure.com/providers/Microsoft.Subscription/subscriptionOperations/ODdmYTU0MDktODc5YS00ZTEzLTg2MWItNTQ4ZjYxNzBlOTQw?api-version=2018-03-01-preview",
"Retry-After": 8
}
},
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@
]
}
},
"/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/invoiceSections/{invoiceSectionName}/providers/Microsoft.Subscription/createSubscription": {
"/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/invoiceSections/{invoiceSectionName}/providers/Microsoft.Subscription/createSubscription": {
"post": {
"description": "The operation to create a new WebDirect or EA Azure subscription.",
"operationId": "Subscriptions_CreateSubscription",
"operationId": "SubscriptionFactory_CreateSubscription",
"x-ms-examples": {
"createSubscription": {
"$ref": "./examples/createSubscription.json"
Expand Down Expand Up @@ -97,73 +97,6 @@
}
}
},
"parameters": [
{
"name": "billingAccountName",
"in": "path",
"description": "The name of the Microsoft Customer Agreement billing account for which you want to create the subscription.",
"required": true,
"type": "string"
},
{
"name": "invoiceSectionName",
"in": "path",
"description": "The name of the invoice section in the billing account for which you want to create the subscription.",
"required": true,
"type": "string"
},
{
"$ref": "#/parameters/apiVersionParameter"
},
{
"name": "body",
"in": "body",
"description": "The subscription creation parameters.",
"required": true,
"schema": {
"$ref": "#/definitions/ModernSubscriptionCreationParameters"
}
}
]
}
},
"/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/invoiceSections/{invoiceSectionName}/providers/Microsoft.Subscription/createSubscription": {
"post": {
"description": "The operation to create a new WebDirect or EA Azure subscription (under billingProfiles).",
"operationId": "Subscriptions_CreateSubscriptionUnderBillingProfile",
"x-ms-examples": {
"createSubscription": {
"$ref": "./examples/createSubscriptionUnderBillingProfile.json"
}
},
"x-ms-long-running-operation": true,
"responses": {
"200": {
"description": "Normal response for a successful query. The response body will contain the data that matches the filters specified in the query parameters.",
"schema": {
"$ref": "#/definitions/SubscriptionCreationResult"
}
},
"202": {
"description": "Accepted. Subscription creation is in progress.",
"headers": {
"Location": {
"description": "GET this URL to retrieve the status of the asynchronous operation.",
"type": "string"
},
"Retry-After": {
"description": "The amount of delay to use while the status of the operation is checked. The value is expressed in seconds.",
"type": "integer"
}
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
},
"parameters": [
{
"name": "billingAccountName",
Expand Down Expand Up @@ -204,7 +137,7 @@
"/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/customers/{customerName}/providers/Microsoft.Subscription/createSubscription": {
"post": {
"description": "The operation to create a new CSP subscription.",
"operationId": "Subscriptions_CreateCspSubscription",
"operationId": "SubscriptionFactory_CreateCspSubscription",
"x-ms-examples": {
"createSubscription": {
"$ref": "./examples/createCspSubscription.json"
Expand Down