Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private link scope default resource type -JEDI #8286

Merged
merged 20 commits into from
Feb 5, 2020
Merged

private link scope default resource type -JEDI #8286

merged 20 commits into from
Feb 5, 2020

Conversation

arolshan
Copy link
Contributor

@arolshan arolshan commented Feb 3, 2020 •
edited
Loading

We expose a new default resource type for Azure Monitor to solve the case for private link on global endpoints. This resource will store reference to Azure Monitor resource required for private link access.

This is an urgent JEDI ask.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

3 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 3, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 69747e1 with merge commit b6dd2c0. SDK Automation 13.0.17.20191226.1
  • ⚠️appinsights/mgmt/2015-05-01 [Logs]  
      No file is changed.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Feb 3, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Feb 3, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 69747e1 with merge commit b6dd2c0. SDK Automation 13.0.17.20191226.1
    • ️✔️azure-mgmt-applicationinsights [Logs]  [Release SDK Changes] 
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Feb 3, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 69747e1 with merge commit b6dd2c0. SDK Automation 13.0.17.20191226.1
    • ️✔️@azure/arm-appinsights [Logs]  [Release SDK Changes] 
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/applicationInsightsManagementClient.js → ./dist/arm-appinsights.js...
[npmPack] created ./dist/arm-appinsights.js in 557ms

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Feb 3, 2020 •
    edited
    Loading

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 69747e1 with merge commit b6dd2c0. SDK Automation 13.0.17.20191226.1 
      [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.ApplicationInsights [Logs]  [Release SDK Changes]
        No Artifact Generated.

      This was referenced Feb 3, 2020
      Closed
      Closed
      Closed
      @arolshan arolshan requested a review from pilor February 3, 2020 22:04
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 4, 2020
      @pilor
      Copy link
      Contributor

      pilor commented Feb 4, 2020

      @akning-ms ready for you

      @arolshan arolshan requested a review from pilor February 5, 2020 08:38
      @akning-ms akning-ms merged commit b6dd2c0 into Azure:master Feb 5, 2020
      ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
      @arolshan @ssripadham
      private link scope default resource type -JEDI (Azure#8286)
      3b606bd 
      * private link scope default resource type

JEDI - URGENT !

* add PEs APIs

* Update readme.md

* Update PrivateLinkScopes_API.json

* a

* a

* Update privateLinkScopes_API.json

* Update privateLinkScopes_API.json

* add workspace members

* fix code review

* Update privateLinkScopes_API.json

* fix build

* Update privateLinkScopes_API.json

* Revert "Update privateLinkScopes_API.json"

This reverts commit 83f3e92.

* Revert "fix build"

This reverts commit da0aef4.

* Revert "Update privateLinkScopes_API.json"

This reverts commit 59d3f3d.

* Revert "fix code review"

This reverts commit 79d7fb8.

* fix code review

* Update privateLinkScopes_API.json

* Update PrivateLinkScopesDelete.json
      00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
      @arolshan @00Kai0
      private link scope default resource type -JEDI (Azure#8286)
      85e2ea5 
      * private link scope default resource type

JEDI - URGENT !

* add PEs APIs

* Update readme.md

* Update PrivateLinkScopes_API.json

* a

* a

* Update privateLinkScopes_API.json

* Update privateLinkScopes_API.json

* add workspace members

* fix code review

* Update privateLinkScopes_API.json

* fix build

* Update privateLinkScopes_API.json

* Revert "Update privateLinkScopes_API.json"

This reverts commit 83f3e92.

* Revert "fix build"

This reverts commit da0aef4.

* Revert "Update privateLinkScopes_API.json"

This reverts commit 59d3f3d.

* Revert "fix code review"

This reverts commit 79d7fb8.

* fix code review

* Update privateLinkScopes_API.json

* Update PrivateLinkScopesDelete.json
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers

      @avidhanju avidhanju Awaiting requested review from avidhanju

      @pilor pilor Awaiting requested review from pilor

      Assignees

      @KrisBash KrisBash

      @akning-ms akning-ms

      Labels
      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      5 participants
      @arolshan @pilor @avidhanju @KrisBash @akning-ms